You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jnaous (via GitHub)" <gi...@apache.org> on 2023/03/31 18:11:42 UTC

[GitHub] [arrow-ballista] jnaous opened a new pull request, #731: Fix nodejs issues in Docker build

jnaous opened a new pull request, #731:
URL: https://github.com/apache/arrow-ballista/pull/731

   Closes #717
   
   Fixes the issue by installing the right version of nodejs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-ballista] avantgardnerio commented on pull request #731: Fix nodejs issues in Docker build

Posted by "avantgardnerio (via GitHub)" <gi...@apache.org>.
avantgardnerio commented on PR #731:
URL: https://github.com/apache/arrow-ballista/pull/731#issuecomment-1567351276

   It looks like it did fix it, and the checks passed in the branch, but it failed when [merged to main](https://github.com/apache/arrow-ballista/actions/runs/5113530837/jobs/9192844132#step:5:23):
   
   ```
   yarn install v1.22.19
   [1/4] Resolving packages...
   [2/4] Fetching packages...
   [3/4] Linking dependencies...
   warning " > @chakra-ui/icons@1.1.7" has unmet peer dependency "@chakra-ui/system@>=1.0.0".
   warning "@chakra-ui/icons > @chakra-ui/icon@2.0.5" has unmet peer dependency "@chakra-ui/system@>=1.0.0".
   warning " > @testing-library/user-event@12.8.3" has unmet peer dependency "@testing-library/dom@>=7.21.4".
   [4/4] Building fresh packages...
   Done in 37.20s.
   yarn run v1.22.1[9](https://github.com/apache/arrow-ballista/actions/runs/5113530837/jobs/9192844132#step:5:10)
   $ react-scripts --openssl-legacy-provider build
   /usr/bin/node: bad option: --openssl-legacy-provider
   error Command failed with exit code 9.
   info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
   Error: Process completed with exit code 9.
   ```
   
   Does anyone know why that error might be happening there?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-ballista] avantgardnerio merged pull request #731: Fix nodejs issues in Docker build

Posted by "avantgardnerio (via GitHub)" <gi...@apache.org>.
avantgardnerio merged PR #731:
URL: https://github.com/apache/arrow-ballista/pull/731


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-ballista] paolorechia commented on pull request #731: Fix nodejs issues in Docker build

Posted by "paolorechia (via GitHub)" <gi...@apache.org>.
paolorechia commented on PR #731:
URL: https://github.com/apache/arrow-ballista/pull/731#issuecomment-1567360812

   Hi, @avantgardnerio, my first hunch is that the installed node version does not match what we expect (18)
   
   If I’m not mistaken, this OpenSSL flag is added to node 17+
   
   When peeking at the build logs, I saw this (nodejs v12):
   
   https://github.com/apache/arrow-ballista/actions/runs/5113530837/jobs/9192844132#step:4:1079
   
   I hope I read it correctly, hard to search the logs in my mobile phone :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-ballista] jnaous commented on pull request #731: Fix nodejs issues in Docker build

Posted by "jnaous (via GitHub)" <gi...@apache.org>.
jnaous commented on PR #731:
URL: https://github.com/apache/arrow-ballista/pull/731#issuecomment-1566162388

   Waiting for a committer... perhaps @andygrove?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-ballista] paolorechia commented on pull request #731: Fix nodejs issues in Docker build

Posted by "paolorechia (via GitHub)" <gi...@apache.org>.
paolorechia commented on PR #731:
URL: https://github.com/apache/arrow-ballista/pull/731#issuecomment-1492431875

   LGTM - I didn't test this though :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-ballista] kylebrooks-8451 commented on pull request #731: Fix nodejs issues in Docker build

Posted by "kylebrooks-8451 (via GitHub)" <gi...@apache.org>.
kylebrooks-8451 commented on PR #731:
URL: https://github.com/apache/arrow-ballista/pull/731#issuecomment-1566142307

   Can we merge this? I was hoping to get the docker build to run again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-ballista] r4ntix commented on pull request #731: Fix nodejs issues in Docker build

Posted by "r4ntix (via GitHub)" <gi...@apache.org>.
r4ntix commented on PR #731:
URL: https://github.com/apache/arrow-ballista/pull/731#issuecomment-1566169837

   > @r4ntix Can we merge this? I was hoping to get the docker build to run again.
   
   Sorry, I don't have permission to merge the PR.
   
   @andygrove @yahoNanJing @Ted-Jiang  Could you help review it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-ballista] avantgardnerio commented on pull request #731: Fix nodejs issues in Docker build

Posted by "avantgardnerio (via GitHub)" <gi...@apache.org>.
avantgardnerio commented on PR #731:
URL: https://github.com/apache/arrow-ballista/pull/731#issuecomment-1567410145

   Hi all, PTAL at https://github.com/apache/arrow-ballista/pull/794 since this seems like it will fix the build.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org