You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by zjffdu <gi...@git.apache.org> on 2017/03/22 12:37:29 UTC
[GitHub] zeppelin pull request #2175: [ZEPPELIN-2294]. Interpreter fail exception is ...
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/2175
[ZEPPELIN-2294]. Interpreter fail exception is not propagated to frontend
### What is this PR for?
This PR would address the issue of Interpreter fail exception is not propagated to frontend. This is due to the bug fix of restarting button issue.
### What type of PR is it?
[Bug Fix | Improvement]
### Todos
* [ ] - Task
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-2294
### How should this be tested?
I don't have time to write test, just verify zombie process issue manually in the following scenario
* Per User + Isolated
* Per Note + Isolated
* Per User + Scoped
* Per Note + Scoped
The combination of user and note still doesn't work (maybe it doesn't work even before this PR). As I doubt whether user can understand this combination and need this. And fix for the combination would require more big change and refactoring. I would suggest put it into next release.
### Screenshots (if appropriate)
Before
After
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-2294
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2175.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2175
----
commit 03b59956c36ea299844941bd4fc4adbe701fec09
Author: Jeff Zhang <zj...@apache.org>
Date: 2017-03-22T07:19:42Z
[ZEPPELIN-2294]. Interpreter fail exception is not propagated to frontend
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2175: [ZEPPELIN-2294]. Interpreter fail exception is not pro...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2175
@jongyoul @Leemoonsoo Please help review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2175: [ZEPPELIN-2294]. Interpreter fail exception is not pro...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2175
And can you add '[HOTFIX]' into the title of this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2175: [ZEPPELIN-2294]. Interpreter fail exception is not pro...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2175
I saw your changes and understood what you want to do. It looks better to handle reference count. I'm testing several modes which you mentioned.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2175: [HOTFIX][ZEPPELIN-2294]. Interpreter fail exception is...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2175
Tested restart with notebook and interpreter tab
1. Per user/scoped
2. Per user/isolated
3. Per note/scoped
4. Per note/isolated
5. Shared
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2175: [HOTFIX][ZEPPELIN-2294]. Interpreter fail excep...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2175
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2175: [HOTFIX][ZEPPELIN-2294]. Interpreter fail exception is...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2175
Will merge it as an hotfix into master and branch-0.7
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---