You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by thadguidry <gi...@git.apache.org> on 2016/01/21 16:57:49 UTC
[GitHub] nifi pull request: Give extra info about input dir for Windows use...
GitHub user thadguidry opened a pull request:
https://github.com/apache/nifi/pull/181
Give extra info about input dir for Windows users.
Windows users typically don't have to worry about supplying a trailing slash....until they work with some Java programs like Nifi.
An input path such as "E:\git\nifi\nifi-nar-bundles\nifi-standard-bundle\nifi-standard-processors\src\test\resources\CharacterSetConversionSamples\TestInput" that does not have a trailing slash will cause NiFi to parse everything in CharacterSetConversionSamples....not the TestInput folder. To remedy the situation, Windows users just need to add the trailing slash \ such as "E:\git\nifi\nifi-nar-bundles\nifi-standard-bundle\nifi-standard-processors\src\test\resources\CharacterSetConversionSamples\TestInput\" and then NiFi is able to use the correct path and not pickup extra files from the unexpected parent folder.
Giving this extra hint for Windows users is an easier workaround for now than doing Windows OS detection with http://commons.apache.org/proper/commons-lang/javadocs/api-release/org/apache/commons/lang3/SystemUtils.html#IS_OS_WINDOWS and providing workarounds.
I think most Windows users and developers are aware of this kind of issue that we deal with everyday, and the extra hint should be enough.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/thadguidry/nifi patch-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/181.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #181
----
commit d775514d163f10233a599f3adf1f8b59a2672b5a
Author: Thad Guidry <th...@gmail.com>
Date: 2016-01-21T15:56:33Z
Give extra info about input dir for Windows users.
Windows users typically don't have to worry about supplying a trailing slash....until they work with some Java programs like Nifi.
An input path such as "E:\git\nifi\nifi-nar-bundles\nifi-standard-bundle\nifi-standard-processors\src\test\resources\CharacterSetConversionSamples\TestInput" that does not have a trailing slash will cause NiFi to parse everything in CharacterSetConversionSamples....not the TestInput folder. To remedy the situation, Windows users just need to add the trailing slash \ such as "E:\git\nifi\nifi-nar-bundles\nifi-standard-bundle\nifi-standard-processors\src\test\resources\CharacterSetConversionSamples\TestInput\" and then NiFi is able to use the correct path and not pickup extra files from the unexpected parent folder.
Giving this extra hint for Windows users is an easier workaround for now than doing Windows OS detection with http://commons.apache.org/proper/commons-lang/javadocs/api-release/org/apache/commons/lang3/SystemUtils.html#IS_OS_WINDOWS and providing workarounds.
I think most Windows users and developers are aware of this kind of issue that we deal with everyday, and the extra hint should be enough.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: Give extra info about input dir for Windows use...
Posted by thadguidry <gi...@git.apache.org>.
Github user thadguidry commented on the pull request:
https://github.com/apache/nifi/pull/181#issuecomment-174546882
@joewitt Done! https://issues.apache.org/jira/browse/NIFI-1437
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: Give extra info about input dir for Windows use...
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the pull request:
https://github.com/apache/nifi/pull/181#issuecomment-174547227
thank you. We're digging in hard for the 050 release now so response time on this might be a bit slow. Thanks for contributing!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: Give extra info about input dir for Windows use...
Posted by thadguidry <gi...@git.apache.org>.
Github user thadguidry closed the pull request at:
https://github.com/apache/nifi/pull/181
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: Give extra info about input dir for Windows use...
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the pull request:
https://github.com/apache/nifi/pull/181#issuecomment-174398262
Hello - can you create a JIRA for this contrib and we can track/discuss there.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---