You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by vy...@apache.org on 2023/10/03 18:57:00 UTC
[logging-log4j-transform] 01/02: Document `flatten-bom` config override
This is an automated email from the ASF dual-hosted git repository.
vy pushed a commit to branch release/0.2.0
in repository https://gitbox.apache.org/repos/asf/logging-log4j-transform.git
commit 22c80c255a43abb0e0fdf318413843004e22b27b
Author: Volkan Yazıcı <vo...@yazi.ci>
AuthorDate: Tue Oct 3 20:44:07 2023 +0200
Document `flatten-bom` config override
---
pom.xml | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/pom.xml b/pom.xml
index 30e0c89..b09be1b 100644
--- a/pom.xml
+++ b/pom.xml
@@ -151,6 +151,19 @@
<inherited>false</inherited>
<configuration>
<pomElements>
+ <!-- Keep the `parent`!
+
+ This is necessary, since...
+ 1. `-parent` depends on `-bom`
+ 2. `-bom` depends on `logging-parent`
+ 3. `logging-parent` contains `dependencyManagement`, etc. that are used by `-maven-plugin` et al.
+ 4. Dependencies of `-maven-plugin` et al. is resolved *at runtime*.
+ 5. Though at runtime, the deployed `-bom` is used, which is flattened and hence doesn't have a parent!
+ 6. Hence, at runtime, all `logging-parent` logic is lost.
+ 7. To avoid this, we override the `flatten-bom` configuration to retain the parent.
+
+ This should ideally be fixed in the `flatten-bom` configuration provided by `logging-parent`.
+ You can remove `<parent>keep`, if https://github.com/apache/logging-parent/issues/37 is resolved. -->
<parent>keep</parent>
</pomElements>
</configuration>