You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "dejan2609 (via GitHub)" <gi...@apache.org> on 2023/02/25 12:14:58 UTC
[GitHub] [kafka] dejan2609 opened a new pull request, #13306: KAFKA-14680: `spotlessCheck` task is disabled
dejan2609 opened a new pull request, #13306:
URL: https://github.com/apache/kafka/pull/13306
**Note**: this solves build regression (after Gradle version was bumped from 7.6 to 8.0.1)
**Rationale**: see this comment made by @chia7712: https://github.com/apache/kafka/pull/13205#issuecomment-1444898374
@chia7712 Feel free to test/review
FIY @ijuma
Some resources used for this solution:
- https://docs.gradle.org/8.0.1/userguide/more_about_tasks.html#sec:skipping_tasks
- https://stackoverflow.com/questions/33909943/exclude-tasks-from-the-task-that-my-task-depends-on
- https://stackoverflow.com/questions/35076540/can-gradle-task-dependencies-be-set-up-to-exclude-a-task
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #13306: KAFKA-14680: `spotlessCheck` task is disabled
Posted by "ijuma (via GitHub)" <gi...@apache.org>.
ijuma commented on PR #13306:
URL: https://github.com/apache/kafka/pull/13306#issuecomment-1445456077
@dejan2609 @chia7712 Check this alternative approach and let me know what you think:
https://github.com/apache/kafka/pull/13311/files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on a diff in pull request #13306: KAFKA-14680: `spotlessCheck` task is disabled
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #13306:
URL: https://github.com/apache/kafka/pull/13306#discussion_r1118086427
##########
build.gradle:
##########
@@ -44,6 +44,14 @@ plugins {
id "io.swagger.core.v3.swagger-gradle-plugin" version "2.2.0"
}
+spotlessCheck.enabled = false
Review Comment:
Could you add comments to explain why we have to disable `spolessCheck`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #13306: KAFKA-14680: `spotlessCheck` task is disabled
Posted by "ijuma (via GitHub)" <gi...@apache.org>.
ijuma commented on PR #13306:
URL: https://github.com/apache/kafka/pull/13306#issuecomment-1445434138
Not sure about this - seems like we're better off removing spotless altogether. Let me play with it a bit and see if something better can be done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dejan2609 commented on pull request #13306: KAFKA-14680: `spotlessCheck` task is disabled
Posted by "dejan2609 (via GitHub)" <gi...@apache.org>.
dejan2609 commented on PR #13306:
URL: https://github.com/apache/kafka/pull/13306#issuecomment-1445468477
Closing in favor of #13311
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dejan2609 commented on a diff in pull request #13306: KAFKA-14680: `spotlessCheck` task is disabled
Posted by "dejan2609 (via GitHub)" <gi...@apache.org>.
dejan2609 commented on code in PR #13306:
URL: https://github.com/apache/kafka/pull/13306#discussion_r1118136738
##########
build.gradle:
##########
@@ -44,6 +44,14 @@ plugins {
id "io.swagger.core.v3.swagger-gradle-plugin" version "2.2.0"
}
+spotlessCheck.enabled = false
Review Comment:
To be honest: this line is not necessary (given a fact that spotless gradle plugin 6.13.0 tasks can be run in isolation, but not combined with other tasks: https://github.com/diffplug/spotless/issues/1572)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dejan2609 closed pull request #13306: KAFKA-14680: `spotlessCheck` task is disabled
Posted by "dejan2609 (via GitHub)" <gi...@apache.org>.
dejan2609 closed pull request #13306: KAFKA-14680: `spotlessCheck` task is disabled
URL: https://github.com/apache/kafka/pull/13306
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dejan2609 commented on pull request #13306: KAFKA-14680: `spotlessCheck` task is disabled
Posted by "dejan2609 (via GitHub)" <gi...@apache.org>.
dejan2609 commented on PR #13306:
URL: https://github.com/apache/kafka/pull/13306#issuecomment-1445443507
Got it @ijuma.
I removed redundant line (as proposed by @chia7712) but I do agree that solution is maybe an overkill, so to say.
My idea was to prevent tasks (such as `build` and `check`) that depend on spotless plugin related tasks to fail:
`./gradlew build tiTree`
```
> Task :tiTree
:build (org.gradle.api.DefaultTask)
+--- :assemble (org.gradle.api.DefaultTask)
| `--- :jar (org.gradle.api.tasks.bundling.Jar)
| +--- :classes (org.gradle.api.DefaultTask)
| | +--- :compileJava (org.gradle.api.tasks.compile.JavaCompile)
| | `--- :processResources (org.gradle.language.jvm.tasks.ProcessResources)
| `--- :compileJava (org.gradle.api.tasks.compile.JavaCompile)
`--- :check (org.gradle.api.DefaultTask)
+--- :rat (org.nosphere.apache.rat.RatTask)
+--- :spotlessCheck (org.gradle.api.DefaultTask)
| `--- :spotlessScalaCheck (com.diffplug.gradle.spotless.SpotlessCheck)
| `--- :spotlessScala (com.diffplug.gradle.spotless.SpotlessTaskImpl)
| `--- :spotlessInternalRegisterDependencies (com.diffplug.gradle.spotless.RegisterDependenciesTask)
`--- :test (org.gradle.api.tasks.testing.Test)
+--- :classes (org.gradle.api.DefaultTask)
| +--- :compileJava (org.gradle.api.tasks.compile.JavaCompile)
| `--- :processResources (org.gradle.language.jvm.tasks.ProcessResources)
+--- :compileJava (org.gradle.api.tasks.compile.JavaCompile)
+--- :compileTestJava (org.gradle.api.tasks.compile.JavaCompile)
| +--- :classes (org.gradle.api.DefaultTask)
| | +--- :compileJava (org.gradle.api.tasks.compile.JavaCompile)
| | `--- :processResources (org.gradle.language.jvm.tasks.ProcessResources)
| `--- :compileJava (org.gradle.api.tasks.compile.JavaCompile)
`--- :testClasses (org.gradle.api.DefaultTask)
+--- :compileTestJava (org.gradle.api.tasks.compile.JavaCompile)
| +--- :classes (org.gradle.api.DefaultTask)
| | +--- :compileJava (org.gradle.api.tasks.compile.JavaCompile)
| | `--- :processResources (org.gradle.language.jvm.tasks.ProcessResources)
| `--- :compileJava (org.gradle.api.tasks.compile.JavaCompile)
`--- :processTestResources (org.gradle.language.jvm.tasks.ProcessResources)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dejan2609 commented on a diff in pull request #13306: KAFKA-14680: `spotlessCheck` task is disabled
Posted by "dejan2609 (via GitHub)" <gi...@apache.org>.
dejan2609 commented on code in PR #13306:
URL: https://github.com/apache/kafka/pull/13306#discussion_r1118137513
##########
build.gradle:
##########
@@ -44,6 +44,14 @@ plugins {
id "io.swagger.core.v3.swagger-gradle-plugin" version "2.2.0"
}
+spotlessCheck.enabled = false
Review Comment:
Line removed, PR updated/force-pushed.
Thanx for a review @chia7712 !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org