You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2023/05/20 23:13:00 UTC
[jira] [Work logged] (WW-5312) ExecuteAndWaitInterceptor inconsistent wait processing behaviour
[ https://issues.apache.org/jira/browse/WW-5312?focusedWorklogId=861881&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-861881 ]
ASF GitHub Bot logged work on WW-5312:
--------------------------------------
Author: ASF GitHub Bot
Created on: 20/May/23 23:12
Start Date: 20/May/23 23:12
Worklog Time Spent: 10m
Work Description: JCgH4164838Gh792C124B5 opened a new pull request, #688:
URL: https://github.com/apache/struts/pull/688
Update:
- Improve ExecuteAndWaitInterceptor state behaviour, added debug and trace logging.
- Ensure StrutsBackgroundProcess thread done state always set on completion.
- Fix SessionMap processing issue caused by divergence of method signatures, which can result in the ancestor methods getting called (bypassing actual session processing).
- Update SessionMapTest to correspond to changes, add tests to try and detect some (put/remove) method signature behaviour changes.
Issue Time Tracking
-------------------
Worklog Id: (was: 861881)
Remaining Estimate: 0h
Time Spent: 10m
> ExecuteAndWaitInterceptor inconsistent wait processing behaviour
> ----------------------------------------------------------------
>
> Key: WW-5312
> URL: https://issues.apache.org/jira/browse/WW-5312
> Project: Struts 2
> Issue Type: Bug
> Components: Core, Core Interceptors
> Affects Versions: 6.1.2
> Environment: Java 8, Tomcat 8.5. The behaviour will likely be the same for other Java/Server combinations.
> Reporter: James Chaplin
> Priority: Minor
> Labels: pull-request-available
> Fix For: 6.2.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The _ExecuteAndWaitInterceptor_ processing appears to only execute as expected for the first run-through for any given session.
> This can be seen interactively using the Struts2 Showcase "_Execute and Wait Examples_", with the wait processing only functioning during the first attempt through each example in the same session. Clearing the session in the browser gives the expected wait behaviour again, but only one time (until clearing the session again).
> After debugging the _ExecuteAndWaitInterceptor_ flow, it appears that the removal from the _SessionMap_ did not perform as expected, resulting in a state divergence with the underlying session.
> A PR that attempts to fix the behaviour will be submitted soon.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)