[GitHub] [spark] HyukjinKwon commented on a change in pull request #28907: [SPARK-31918][R] Ignore S4 generic methods under SparkR namespace in closure cleaning to support R 4.0.0+

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #28907:
URL: https://github.com/apache/spark/pull/28907#discussion_r444160704



##########
File path: R/pkg/tests/fulltests/test_mllib_classification.R
##########
@@ -268,9 +268,9 @@ test_that("spark.logit", {
   # Test multinomial logistic regression with lowerBoundsOnCoefficients
   # and lowerBoundsOnIntercepts
   l <- matrix(c(0.0, -1.0, 0.0, -1.0, 0.0, -1.0, 0.0, -1.0), nrow = 2, ncol = 4)
-  model <- spark.logit(training, Species ~ ., family = "multinomial",
-                       lowerBoundsOnCoefficients = l,
-                       lowerBoundsOnIntercepts = as.array(c(0.0, 0.0)))
+  model <- suppressWarnings(spark.logit(training, Species ~ ., family = "multinomial",

Review comment:
       It suppress:
   
   ```
   test_mllib_classification.R:258: error: spark.logit
   (converted from warning) the condition has length > 1 and only the first element will be used
   Backtrace:
    1. SparkR::spark.logit(...) tests/fulltests/test_mllib_classification.R:258:2
    2. SparkR::spark.logit(...)
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org