You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by David Forsythe <df...@gmail.com> on 2015/11/10 07:35:52 UTC

Re: Review Request 39635: FreeBSD: Enable libprocess build and disable failing test

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39635/
-----------------------------------------------------------

(Updated Nov. 10, 2015, 6:35 a.m.)


Review request for mesos and Ian Downes.


Bugs: MESOS-1563
    https://issues.apache.org/jira/browse/MESOS-1563


Repository: mesos


Description
-------

FreeBSD: Enable libprocess build and disable failing test


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/Makefile.am b73196cfa18e0d270e2533fbf733ad91e0559286 
  3rdparty/libprocess/configure.ac 40801653a7fb9a943dfe33913161d28ef24040c3 
  3rdparty/libprocess/src/config.hpp 721816432621c78b3ff5cc3176753821e9ef7975 
  3rdparty/libprocess/src/tests/http_tests.cpp 7eb4ef187b2cb358c370d0381db65b8e18668bab 

Diff: https://reviews.apache.org/r/39635/diff/


Testing
-------

make check on ubuntu


Thanks,

David Forsythe


Re: Review Request 39635: FreeBSD: Enable libprocess build and disable failing test

Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39635/#review108381
-----------------------------------------------------------

Ship it!


Minor nits on comments. Will make the changes myself when I commit. Thanks!


3rdparty/libprocess/3rdparty/Makefile.am (line 243)
<https://reviews.apache.org/r/39635/#comment167818>

    Full stop.



3rdparty/libprocess/configure.ac (line 835)
<https://reviews.apache.org/r/39635/#comment167817>

    Full stop.



3rdparty/libprocess/src/tests/http_tests.cpp (line 897)
<https://reviews.apache.org/r/39635/#comment167819>

    Full stop.


- Ian Downes


On Nov. 27, 2015, 8:26 p.m., David Forsythe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39635/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2015, 8:26 p.m.)
> 
> 
> Review request for mesos and Ian Downes.
> 
> 
> Bugs: MESOS-1563
>     https://issues.apache.org/jira/browse/MESOS-1563
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> FreeBSD: Enable libprocess build and disable failing test
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 0adbe539afaf683e4a85582463a2930049a63998 
>   3rdparty/libprocess/configure.ac 40801653a7fb9a943dfe33913161d28ef24040c3 
>   3rdparty/libprocess/src/config.hpp 8444a6018f9bc911d59a751b5a763f73d86ab1e6 
>   3rdparty/libprocess/src/tests/http_tests.cpp 2de75ca1c7e224c36b534c368e7379dc158aa5bb 
> 
> Diff: https://reviews.apache.org/r/39635/diff/
> 
> 
> Testing
> -------
> 
> make check on ubuntu
> 
> 
> Thanks,
> 
> David Forsythe
> 
>


Re: Review Request 39635: FreeBSD: Enable libprocess build and disable failing test

Posted by David Forsythe <df...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39635/
-----------------------------------------------------------

(Updated Nov. 28, 2015, 4:26 a.m.)


Review request for mesos and Ian Downes.


Bugs: MESOS-1563
    https://issues.apache.org/jira/browse/MESOS-1563


Repository: mesos


Description
-------

FreeBSD: Enable libprocess build and disable failing test


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/Makefile.am 0adbe539afaf683e4a85582463a2930049a63998 
  3rdparty/libprocess/configure.ac 40801653a7fb9a943dfe33913161d28ef24040c3 
  3rdparty/libprocess/src/config.hpp 8444a6018f9bc911d59a751b5a763f73d86ab1e6 
  3rdparty/libprocess/src/tests/http_tests.cpp 2de75ca1c7e224c36b534c368e7379dc158aa5bb 

Diff: https://reviews.apache.org/r/39635/diff/


Testing
-------

make check on ubuntu


Thanks,

David Forsythe


Re: Review Request 39635: FreeBSD: Enable libprocess build and disable failing test

Posted by David Forsythe <df...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39635/
-----------------------------------------------------------

(Updated Nov. 14, 2015, 9:02 a.m.)


Review request for mesos and Ian Downes.


Bugs: MESOS-1563
    https://issues.apache.org/jira/browse/MESOS-1563


Repository: mesos


Description
-------

FreeBSD: Enable libprocess build and disable failing test


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/Makefile.am 0adbe539afaf683e4a85582463a2930049a63998 
  3rdparty/libprocess/configure.ac 40801653a7fb9a943dfe33913161d28ef24040c3 
  3rdparty/libprocess/src/config.hpp 721816432621c78b3ff5cc3176753821e9ef7975 
  3rdparty/libprocess/src/tests/http_tests.cpp 5e70f1896a86104ac01dfe725eb4d7d1d25bee77 

Diff: https://reviews.apache.org/r/39635/diff/


Testing
-------

make check on ubuntu


Thanks,

David Forsythe


Re: Review Request 39635: FreeBSD: Enable libprocess build and disable failing test

Posted by David Forsythe <df...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39635/
-----------------------------------------------------------

(Updated Nov. 10, 2015, 8:33 a.m.)


Review request for mesos and Ian Downes.


Bugs: MESOS-1563
    https://issues.apache.org/jira/browse/MESOS-1563


Repository: mesos


Description
-------

FreeBSD: Enable libprocess build and disable failing test


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/Makefile.am b73196cfa18e0d270e2533fbf733ad91e0559286 
  3rdparty/libprocess/configure.ac 40801653a7fb9a943dfe33913161d28ef24040c3 
  3rdparty/libprocess/src/config.hpp 721816432621c78b3ff5cc3176753821e9ef7975 
  3rdparty/libprocess/src/tests/http_tests.cpp 7eb4ef187b2cb358c370d0381db65b8e18668bab 

Diff: https://reviews.apache.org/r/39635/diff/


Testing
-------

make check on ubuntu


Thanks,

David Forsythe