You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/04/15 19:06:26 UTC

[GitHub] [helix] xyuanlu commented on pull request #1691: Improve the WAGED.ConstraintBasedAlgorithm sorting logic to prioritize replica with larger impact

xyuanlu commented on pull request #1691:
URL: https://github.com/apache/helix/pull/1691#issuecomment-820665685


   > Question: a general question, seemed this sorting to be happened in every pipeline. Can we add some checks there? If no condition needed for such sorting, we skip it?
   
   Thanks for the question. 
   In my understanding, we sort replicas for two reasons:
   1. For every rebalance, the assignment of each replicas should be in the same sequence. This is already garnered in the original design.
   2. We want to place replicas with larger impact first to solve the failure by placing very large partition after small partitions.  We only know the placement will fail afterward. So it is hard to know is we need to sort beforehand. 
   Hope my explain is clear. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org