You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/03/21 08:00:44 UTC
[GitHub] [flink] liuyongvs opened a new pull request #11471: [FLINK-16692]
flink joblistener can register from config
liuyongvs opened a new pull request #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)*
## Brief change log
*(for example:)*
- *The TaskInfo is stored in the blob store on job creation time as a persistent artifact*
- *Deployments RPC transmits only the blob storage reference*
- *TaskManagers retrieve the TaskInfo from the blob cache*
## Verifying this change
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (100MB)*
- *Extended integration test for recovery after master (JobManager) failure*
- *Added test that validates that TaskInfo is transferred only once across recoveries*
- *Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11471: [FLINK-16692]
flink joblistener can register from config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471#issuecomment-602012274
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6464",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
}, {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154358312",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
}, {
"hash" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154513464",
"triggerID" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"triggerType" : "PUSH"
}, {
"hash" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6493",
"triggerID" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"triggerType" : "PUSH"
}, {
"hash" : "7f0c7e868fce22437c1b4b7a02fece52afb70f4a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7f0c7e868fce22437c1b4b7a02fece52afb70f4a",
"triggerType" : "PUSH"
}, {
"hash" : "57f1b99ac6db6626e6c78cb7b39e2026b59d1282",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "57f1b99ac6db6626e6c78cb7b39e2026b59d1282",
"triggerType" : "PUSH"
}, {
"hash" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154537643",
"triggerID" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"triggerType" : "PUSH"
}, {
"hash" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6506",
"triggerID" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"triggerType" : "PUSH"
}, {
"hash" : "897c7ac6b19baac21a7876c4eff087e774e8a928",
"status" : "CANCELED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154587664",
"triggerID" : "897c7ac6b19baac21a7876c4eff087e774e8a928",
"triggerType" : "PUSH"
}, {
"hash" : "897c7ac6b19baac21a7876c4eff087e774e8a928",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6534",
"triggerID" : "897c7ac6b19baac21a7876c4eff087e774e8a928",
"triggerType" : "PUSH"
}, {
"hash" : "9358d99d522ca3aa6e769742f70624c85e46a149",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9358d99d522ca3aa6e769742f70624c85e46a149",
"triggerType" : "PUSH"
}, {
"hash" : "94c305ee8759318a1c18b9c795a957c44ba0d358",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "94c305ee8759318a1c18b9c795a957c44ba0d358",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7f0c7e868fce22437c1b4b7a02fece52afb70f4a UNKNOWN
* 57f1b99ac6db6626e6c78cb7b39e2026b59d1282 UNKNOWN
* 897c7ac6b19baac21a7876c4eff087e774e8a928 Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/154587664) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6534)
* 9358d99d522ca3aa6e769742f70624c85e46a149 UNKNOWN
* 94c305ee8759318a1c18b9c795a957c44ba0d358 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11471: [FLINK-16692]
flink joblistener can register from config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471#issuecomment-602012274
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6464",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
}, {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154358312",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
}, {
"hash" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154513464",
"triggerID" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"triggerType" : "PUSH"
}, {
"hash" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6493",
"triggerID" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 88e613d77d95f9edf47e1c59f2ce078e3717383f Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/154358312) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6464)
* ad9049971efa640a2b22ee8f258b0a0d7f64cc47 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/154513464) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6493)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] liuyongvs commented on issue #11471: [FLINK-16692] flink
joblistener can register from config
Posted by GitBox <gi...@apache.org>.
liuyongvs commented on issue #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471#issuecomment-603114690
Hi @kl0u , it is ok now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11471: [FLINK-16692]
flink joblistener can register from config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471#issuecomment-602012274
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6464",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
}, {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154358312",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
}, {
"hash" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154513464",
"triggerID" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"triggerType" : "PUSH"
}, {
"hash" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6493",
"triggerID" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"triggerType" : "PUSH"
}, {
"hash" : "7f0c7e868fce22437c1b4b7a02fece52afb70f4a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7f0c7e868fce22437c1b4b7a02fece52afb70f4a",
"triggerType" : "PUSH"
}, {
"hash" : "57f1b99ac6db6626e6c78cb7b39e2026b59d1282",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "57f1b99ac6db6626e6c78cb7b39e2026b59d1282",
"triggerType" : "PUSH"
}, {
"hash" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154537643",
"triggerID" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"triggerType" : "PUSH"
}, {
"hash" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6506",
"triggerID" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"triggerType" : "PUSH"
}, {
"hash" : "897c7ac6b19baac21a7876c4eff087e774e8a928",
"status" : "CANCELED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154587664",
"triggerID" : "897c7ac6b19baac21a7876c4eff087e774e8a928",
"triggerType" : "PUSH"
}, {
"hash" : "897c7ac6b19baac21a7876c4eff087e774e8a928",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6534",
"triggerID" : "897c7ac6b19baac21a7876c4eff087e774e8a928",
"triggerType" : "PUSH"
}, {
"hash" : "9358d99d522ca3aa6e769742f70624c85e46a149",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9358d99d522ca3aa6e769742f70624c85e46a149",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7f0c7e868fce22437c1b4b7a02fece52afb70f4a UNKNOWN
* 57f1b99ac6db6626e6c78cb7b39e2026b59d1282 UNKNOWN
* 897c7ac6b19baac21a7876c4eff087e774e8a928 Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/154587664) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6534)
* 9358d99d522ca3aa6e769742f70624c85e46a149 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] kl0u commented on a change in pull request #11471:
[FLINK-16692] flink joblistener can register from config
Posted by GitBox <gi...@apache.org>.
kl0u commented on a change in pull request #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471#discussion_r396289410
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
##########
@@ -761,6 +768,20 @@ public void configure(ReadableConfig configuration, ClassLoader classLoader) {
});
config.configure(configuration, classLoader);
checkpointCfg.configure(configuration);
+ configuration.getOptional(ExecutionOptions.JOB_LISTENERS)
+ .ifPresent(l -> {
+ for (String listener : l) {
+ try {
Review comment:
You can use the method `InstantiationUtil#instantiate(final String className, final Class<T> targetType, final ClassLoader classLoader)`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11471: [FLINK-16692]
flink joblistener can register from config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471#issuecomment-602012274
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6464",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
}, {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154358312",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
}, {
"hash" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"status" : "CANCELED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154513464",
"triggerID" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"triggerType" : "PUSH"
}, {
"hash" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6493",
"triggerID" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"triggerType" : "PUSH"
}, {
"hash" : "7f0c7e868fce22437c1b4b7a02fece52afb70f4a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7f0c7e868fce22437c1b4b7a02fece52afb70f4a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ad9049971efa640a2b22ee8f258b0a0d7f64cc47 Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/154513464) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6493)
* 7f0c7e868fce22437c1b4b7a02fece52afb70f4a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11471: [FLINK-16692]
flink joblistener can register from config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471#issuecomment-602012274
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6464",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
}, {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154358312",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
}, {
"hash" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154513464",
"triggerID" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"triggerType" : "PUSH"
}, {
"hash" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6493",
"triggerID" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"triggerType" : "PUSH"
}, {
"hash" : "7f0c7e868fce22437c1b4b7a02fece52afb70f4a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7f0c7e868fce22437c1b4b7a02fece52afb70f4a",
"triggerType" : "PUSH"
}, {
"hash" : "57f1b99ac6db6626e6c78cb7b39e2026b59d1282",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "57f1b99ac6db6626e6c78cb7b39e2026b59d1282",
"triggerType" : "PUSH"
}, {
"hash" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154537643",
"triggerID" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"triggerType" : "PUSH"
}, {
"hash" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6506",
"triggerID" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7f0c7e868fce22437c1b4b7a02fece52afb70f4a UNKNOWN
* 57f1b99ac6db6626e6c78cb7b39e2026b59d1282 UNKNOWN
* 84606e23725fc6c688ce72da42d06b8f30ac4910 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/154537643) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6506)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11471: [FLINK-16692]
flink joblistener can register from config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471#issuecomment-602012274
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6464",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
}, {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154358312",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
}, {
"hash" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154513464",
"triggerID" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"triggerType" : "PUSH"
}, {
"hash" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6493",
"triggerID" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"triggerType" : "PUSH"
}, {
"hash" : "7f0c7e868fce22437c1b4b7a02fece52afb70f4a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7f0c7e868fce22437c1b4b7a02fece52afb70f4a",
"triggerType" : "PUSH"
}, {
"hash" : "57f1b99ac6db6626e6c78cb7b39e2026b59d1282",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "57f1b99ac6db6626e6c78cb7b39e2026b59d1282",
"triggerType" : "PUSH"
}, {
"hash" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154537643",
"triggerID" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"triggerType" : "PUSH"
}, {
"hash" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6506",
"triggerID" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"triggerType" : "PUSH"
}, {
"hash" : "897c7ac6b19baac21a7876c4eff087e774e8a928",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154587664",
"triggerID" : "897c7ac6b19baac21a7876c4eff087e774e8a928",
"triggerType" : "PUSH"
}, {
"hash" : "897c7ac6b19baac21a7876c4eff087e774e8a928",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6534",
"triggerID" : "897c7ac6b19baac21a7876c4eff087e774e8a928",
"triggerType" : "PUSH"
}, {
"hash" : "9358d99d522ca3aa6e769742f70624c85e46a149",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9358d99d522ca3aa6e769742f70624c85e46a149",
"triggerType" : "PUSH"
}, {
"hash" : "94c305ee8759318a1c18b9c795a957c44ba0d358",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154708769",
"triggerID" : "94c305ee8759318a1c18b9c795a957c44ba0d358",
"triggerType" : "PUSH"
}, {
"hash" : "94c305ee8759318a1c18b9c795a957c44ba0d358",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6549",
"triggerID" : "94c305ee8759318a1c18b9c795a957c44ba0d358",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7f0c7e868fce22437c1b4b7a02fece52afb70f4a UNKNOWN
* 57f1b99ac6db6626e6c78cb7b39e2026b59d1282 UNKNOWN
* 9358d99d522ca3aa6e769742f70624c85e46a149 UNKNOWN
* 94c305ee8759318a1c18b9c795a957c44ba0d358 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/154708769) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6549)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] kl0u commented on issue #11471: [FLINK-16692] flink
joblistener can register from config
Posted by GitBox <gi...@apache.org>.
kl0u commented on issue #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471#issuecomment-603134439
Hi @liuyongvs there is no need to run on your PC in order to create a new branch. You can just go to a clean master branch on your laptop, create a new branch, cherry pick all the commits from this PR, squash them and push to github :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11471: [FLINK-16692]
flink joblistener can register from config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471#issuecomment-602012274
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6464",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
}, {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154358312",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
}, {
"hash" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154513464",
"triggerID" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"triggerType" : "PUSH"
}, {
"hash" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6493",
"triggerID" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"triggerType" : "PUSH"
}, {
"hash" : "7f0c7e868fce22437c1b4b7a02fece52afb70f4a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7f0c7e868fce22437c1b4b7a02fece52afb70f4a",
"triggerType" : "PUSH"
}, {
"hash" : "57f1b99ac6db6626e6c78cb7b39e2026b59d1282",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "57f1b99ac6db6626e6c78cb7b39e2026b59d1282",
"triggerType" : "PUSH"
}, {
"hash" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154537643",
"triggerID" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"triggerType" : "PUSH"
}, {
"hash" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6506",
"triggerID" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"triggerType" : "PUSH"
}, {
"hash" : "897c7ac6b19baac21a7876c4eff087e774e8a928",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154587664",
"triggerID" : "897c7ac6b19baac21a7876c4eff087e774e8a928",
"triggerType" : "PUSH"
}, {
"hash" : "897c7ac6b19baac21a7876c4eff087e774e8a928",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6534",
"triggerID" : "897c7ac6b19baac21a7876c4eff087e774e8a928",
"triggerType" : "PUSH"
}, {
"hash" : "9358d99d522ca3aa6e769742f70624c85e46a149",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9358d99d522ca3aa6e769742f70624c85e46a149",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7f0c7e868fce22437c1b4b7a02fece52afb70f4a UNKNOWN
* 57f1b99ac6db6626e6c78cb7b39e2026b59d1282 UNKNOWN
* 84606e23725fc6c688ce72da42d06b8f30ac4910 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/154537643) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6506)
* 897c7ac6b19baac21a7876c4eff087e774e8a928 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/154587664) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6534)
* 9358d99d522ca3aa6e769742f70624c85e46a149 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] liuyongvs commented on a change in pull request #11471:
[FLINK-16692] flink joblistener can register from config
Posted by GitBox <gi...@apache.org>.
liuyongvs commented on a change in pull request #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471#discussion_r396857369
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
##########
@@ -761,6 +768,20 @@ public void configure(ReadableConfig configuration, ClassLoader classLoader) {
});
config.configure(configuration, classLoader);
checkpointCfg.configure(configuration);
+ configuration.getOptional(ExecutionOptions.JOB_LISTENERS)
+ .ifPresent(l -> {
+ for (String listener : l) {
+ try {
Review comment:
I have used this tool
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11471: [FLINK-16692]
flink joblistener can register from config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471#issuecomment-602012274
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6464",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
}, {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154358312",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
}, {
"hash" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"status" : "CANCELED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154513464",
"triggerID" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"triggerType" : "PUSH"
}, {
"hash" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6493",
"triggerID" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"triggerType" : "PUSH"
}, {
"hash" : "7f0c7e868fce22437c1b4b7a02fece52afb70f4a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7f0c7e868fce22437c1b4b7a02fece52afb70f4a",
"triggerType" : "PUSH"
}, {
"hash" : "57f1b99ac6db6626e6c78cb7b39e2026b59d1282",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "57f1b99ac6db6626e6c78cb7b39e2026b59d1282",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ad9049971efa640a2b22ee8f258b0a0d7f64cc47 Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/154513464) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6493)
* 7f0c7e868fce22437c1b4b7a02fece52afb70f4a UNKNOWN
* 57f1b99ac6db6626e6c78cb7b39e2026b59d1282 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11471: [FLINK-16692]
flink joblistener can register from config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471#issuecomment-602012274
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6464",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
}, {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154358312",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
}, {
"hash" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154513464",
"triggerID" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"triggerType" : "PUSH"
}, {
"hash" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6493",
"triggerID" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"triggerType" : "PUSH"
}, {
"hash" : "7f0c7e868fce22437c1b4b7a02fece52afb70f4a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7f0c7e868fce22437c1b4b7a02fece52afb70f4a",
"triggerType" : "PUSH"
}, {
"hash" : "57f1b99ac6db6626e6c78cb7b39e2026b59d1282",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "57f1b99ac6db6626e6c78cb7b39e2026b59d1282",
"triggerType" : "PUSH"
}, {
"hash" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154537643",
"triggerID" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"triggerType" : "PUSH"
}, {
"hash" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6506",
"triggerID" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"triggerType" : "PUSH"
}, {
"hash" : "897c7ac6b19baac21a7876c4eff087e774e8a928",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154587664",
"triggerID" : "897c7ac6b19baac21a7876c4eff087e774e8a928",
"triggerType" : "PUSH"
}, {
"hash" : "897c7ac6b19baac21a7876c4eff087e774e8a928",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6534",
"triggerID" : "897c7ac6b19baac21a7876c4eff087e774e8a928",
"triggerType" : "PUSH"
}, {
"hash" : "9358d99d522ca3aa6e769742f70624c85e46a149",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9358d99d522ca3aa6e769742f70624c85e46a149",
"triggerType" : "PUSH"
}, {
"hash" : "94c305ee8759318a1c18b9c795a957c44ba0d358",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154708769",
"triggerID" : "94c305ee8759318a1c18b9c795a957c44ba0d358",
"triggerType" : "PUSH"
}, {
"hash" : "94c305ee8759318a1c18b9c795a957c44ba0d358",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6549",
"triggerID" : "94c305ee8759318a1c18b9c795a957c44ba0d358",
"triggerType" : "PUSH"
}, {
"hash" : "558b2912c90948b03302d9462f7d91b4058b5bac",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154730068",
"triggerID" : "558b2912c90948b03302d9462f7d91b4058b5bac",
"triggerType" : "PUSH"
}, {
"hash" : "558b2912c90948b03302d9462f7d91b4058b5bac",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6559",
"triggerID" : "558b2912c90948b03302d9462f7d91b4058b5bac",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7f0c7e868fce22437c1b4b7a02fece52afb70f4a UNKNOWN
* 57f1b99ac6db6626e6c78cb7b39e2026b59d1282 UNKNOWN
* 9358d99d522ca3aa6e769742f70624c85e46a149 UNKNOWN
* 558b2912c90948b03302d9462f7d91b4058b5bac Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/154730068) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6559)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] liuyongvs commented on a change in pull request #11471:
[FLINK-16692] flink joblistener can register from config
Posted by GitBox <gi...@apache.org>.
liuyongvs commented on a change in pull request #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471#discussion_r396857109
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/ExecutionOptions.java
##########
@@ -55,4 +56,11 @@
"throughput")
)
.build());
+
+ public static final ConfigOption<List<String>> JOB_LISTENERS =
Review comment:
i have moved the argument from ExecutionOptions to DeploymentOptions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11471: [FLINK-16692]
flink joblistener can register from config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471#issuecomment-602012274
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6464",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
}, {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154358312",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
}, {
"hash" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154513464",
"triggerID" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"triggerType" : "PUSH"
}, {
"hash" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6493",
"triggerID" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"triggerType" : "PUSH"
}, {
"hash" : "7f0c7e868fce22437c1b4b7a02fece52afb70f4a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7f0c7e868fce22437c1b4b7a02fece52afb70f4a",
"triggerType" : "PUSH"
}, {
"hash" : "57f1b99ac6db6626e6c78cb7b39e2026b59d1282",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "57f1b99ac6db6626e6c78cb7b39e2026b59d1282",
"triggerType" : "PUSH"
}, {
"hash" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154537643",
"triggerID" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"triggerType" : "PUSH"
}, {
"hash" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6506",
"triggerID" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"triggerType" : "PUSH"
}, {
"hash" : "897c7ac6b19baac21a7876c4eff087e774e8a928",
"status" : "CANCELED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154587664",
"triggerID" : "897c7ac6b19baac21a7876c4eff087e774e8a928",
"triggerType" : "PUSH"
}, {
"hash" : "897c7ac6b19baac21a7876c4eff087e774e8a928",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6534",
"triggerID" : "897c7ac6b19baac21a7876c4eff087e774e8a928",
"triggerType" : "PUSH"
}, {
"hash" : "9358d99d522ca3aa6e769742f70624c85e46a149",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9358d99d522ca3aa6e769742f70624c85e46a149",
"triggerType" : "PUSH"
}, {
"hash" : "94c305ee8759318a1c18b9c795a957c44ba0d358",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154708769",
"triggerID" : "94c305ee8759318a1c18b9c795a957c44ba0d358",
"triggerType" : "PUSH"
}, {
"hash" : "94c305ee8759318a1c18b9c795a957c44ba0d358",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6549",
"triggerID" : "94c305ee8759318a1c18b9c795a957c44ba0d358",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7f0c7e868fce22437c1b4b7a02fece52afb70f4a UNKNOWN
* 57f1b99ac6db6626e6c78cb7b39e2026b59d1282 UNKNOWN
* 897c7ac6b19baac21a7876c4eff087e774e8a928 Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/154587664) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6534)
* 9358d99d522ca3aa6e769742f70624c85e46a149 UNKNOWN
* 94c305ee8759318a1c18b9c795a957c44ba0d358 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/154708769) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6549)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] kl0u commented on issue #11471: [FLINK-16692] flink
joblistener can register from config
Posted by GitBox <gi...@apache.org>.
kl0u commented on issue #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471#issuecomment-603155869
Changes look good, I will merge as soon as my travis gives green. Thanks for the work @liuyongvs !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11471: [FLINK-16692]
flink joblistener can register from config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471#issuecomment-602012274
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6464",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
}, {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154358312",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
}, {
"hash" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"status" : "CANCELED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154513464",
"triggerID" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"triggerType" : "PUSH"
}, {
"hash" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6493",
"triggerID" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"triggerType" : "PUSH"
}, {
"hash" : "7f0c7e868fce22437c1b4b7a02fece52afb70f4a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7f0c7e868fce22437c1b4b7a02fece52afb70f4a",
"triggerType" : "PUSH"
}, {
"hash" : "57f1b99ac6db6626e6c78cb7b39e2026b59d1282",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "57f1b99ac6db6626e6c78cb7b39e2026b59d1282",
"triggerType" : "PUSH"
}, {
"hash" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ad9049971efa640a2b22ee8f258b0a0d7f64cc47 Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/154513464) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6493)
* 7f0c7e868fce22437c1b4b7a02fece52afb70f4a UNKNOWN
* 57f1b99ac6db6626e6c78cb7b39e2026b59d1282 UNKNOWN
* 84606e23725fc6c688ce72da42d06b8f30ac4910 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11471: [FLINK-16692] flink
joblistener can register from config
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471#issuecomment-602012274
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 88e613d77d95f9edf47e1c59f2ce078e3717383f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11471: [FLINK-16692]
flink joblistener can register from config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471#issuecomment-602012274
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6464",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
}, {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154358312",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
}, {
"hash" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154513464",
"triggerID" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"triggerType" : "PUSH"
}, {
"hash" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6493",
"triggerID" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"triggerType" : "PUSH"
}, {
"hash" : "7f0c7e868fce22437c1b4b7a02fece52afb70f4a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7f0c7e868fce22437c1b4b7a02fece52afb70f4a",
"triggerType" : "PUSH"
}, {
"hash" : "57f1b99ac6db6626e6c78cb7b39e2026b59d1282",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "57f1b99ac6db6626e6c78cb7b39e2026b59d1282",
"triggerType" : "PUSH"
}, {
"hash" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154537643",
"triggerID" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"triggerType" : "PUSH"
}, {
"hash" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6506",
"triggerID" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"triggerType" : "PUSH"
}, {
"hash" : "897c7ac6b19baac21a7876c4eff087e774e8a928",
"status" : "CANCELED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154587664",
"triggerID" : "897c7ac6b19baac21a7876c4eff087e774e8a928",
"triggerType" : "PUSH"
}, {
"hash" : "897c7ac6b19baac21a7876c4eff087e774e8a928",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6534",
"triggerID" : "897c7ac6b19baac21a7876c4eff087e774e8a928",
"triggerType" : "PUSH"
}, {
"hash" : "9358d99d522ca3aa6e769742f70624c85e46a149",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9358d99d522ca3aa6e769742f70624c85e46a149",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7f0c7e868fce22437c1b4b7a02fece52afb70f4a UNKNOWN
* 57f1b99ac6db6626e6c78cb7b39e2026b59d1282 UNKNOWN
* 897c7ac6b19baac21a7876c4eff087e774e8a928 Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/154587664) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6534)
* 9358d99d522ca3aa6e769742f70624c85e46a149 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11471: [FLINK-16692]
flink joblistener can register from config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471#issuecomment-602012274
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6464",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
}, {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154358312",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 88e613d77d95f9edf47e1c59f2ce078e3717383f Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/154358312) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6464)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] kl0u closed pull request #11471: [FLINK-16692] flink
joblistener can register from config
Posted by GitBox <gi...@apache.org>.
kl0u closed pull request #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11471: [FLINK-16692]
flink joblistener can register from config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471#issuecomment-602012274
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6464",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
}, {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154358312",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
}, {
"hash" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154513464",
"triggerID" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"triggerType" : "PUSH"
}, {
"hash" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6493",
"triggerID" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"triggerType" : "PUSH"
}, {
"hash" : "7f0c7e868fce22437c1b4b7a02fece52afb70f4a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7f0c7e868fce22437c1b4b7a02fece52afb70f4a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 88e613d77d95f9edf47e1c59f2ce078e3717383f Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/154358312) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6464)
* ad9049971efa640a2b22ee8f258b0a0d7f64cc47 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/154513464) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6493)
* 7f0c7e868fce22437c1b4b7a02fece52afb70f4a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] kl0u commented on a change in pull request #11471:
[FLINK-16692] flink joblistener can register from config
Posted by GitBox <gi...@apache.org>.
kl0u commented on a change in pull request #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471#discussion_r396291783
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/ExecutionOptions.java
##########
@@ -55,4 +56,11 @@
"throughput")
)
.build());
+
+ public static final ConfigOption<List<String>> JOB_LISTENERS =
Review comment:
I would suggest to move it to the `DeploymentOptions`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11471: [FLINK-16692]
flink joblistener can register from config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471#issuecomment-602012274
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6464",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
}, {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154358312",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
}, {
"hash" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 88e613d77d95f9edf47e1c59f2ce078e3717383f Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/154358312) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6464)
* ad9049971efa640a2b22ee8f258b0a0d7f64cc47 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11471: [FLINK-16692]
flink joblistener can register from config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471#issuecomment-602012274
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6464",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
}, {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154358312",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
}, {
"hash" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"status" : "CANCELED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154513464",
"triggerID" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"triggerType" : "PUSH"
}, {
"hash" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6493",
"triggerID" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"triggerType" : "PUSH"
}, {
"hash" : "7f0c7e868fce22437c1b4b7a02fece52afb70f4a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7f0c7e868fce22437c1b4b7a02fece52afb70f4a",
"triggerType" : "PUSH"
}, {
"hash" : "57f1b99ac6db6626e6c78cb7b39e2026b59d1282",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "57f1b99ac6db6626e6c78cb7b39e2026b59d1282",
"triggerType" : "PUSH"
}, {
"hash" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154537643",
"triggerID" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"triggerType" : "PUSH"
}, {
"hash" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6506",
"triggerID" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ad9049971efa640a2b22ee8f258b0a0d7f64cc47 Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/154513464) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6493)
* 7f0c7e868fce22437c1b4b7a02fece52afb70f4a UNKNOWN
* 57f1b99ac6db6626e6c78cb7b39e2026b59d1282 UNKNOWN
* 84606e23725fc6c688ce72da42d06b8f30ac4910 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/154537643) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6506)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] kl0u commented on a change in pull request #11471:
[FLINK-16692] flink joblistener can register from config
Posted by GitBox <gi...@apache.org>.
kl0u commented on a change in pull request #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471#discussion_r396281963
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
##########
@@ -237,6 +237,13 @@ public ExecutionConfig getConfig() {
return cacheFile;
}
+ /**
+ * Gets the config JobListeners.
+ */
Review comment:
Annotate as `@PublicEvolving`. And I would prefer if we did not even add a new method in the `env`, if possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] liuyongvs commented on issue #11471: [FLINK-16692] flink
joblistener can register from config
Posted by GitBox <gi...@apache.org>.
liuyongvs commented on issue #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471#issuecomment-603163417
Thanks @kl0u , I read the commits , all my changes are included
> @liuyongvs I am reviewing currently your PR. This is the branch https://github.com/kl0u/flink/tree/listeners that I created based on your commits. Please check if all your changes are included, and if I have any comments, please integrate them on that branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11471: [FLINK-16692]
flink joblistener can register from config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471#issuecomment-602012274
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6464",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
}, {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154358312",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
}, {
"hash" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154513464",
"triggerID" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"triggerType" : "PUSH"
}, {
"hash" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6493",
"triggerID" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"triggerType" : "PUSH"
}, {
"hash" : "7f0c7e868fce22437c1b4b7a02fece52afb70f4a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7f0c7e868fce22437c1b4b7a02fece52afb70f4a",
"triggerType" : "PUSH"
}, {
"hash" : "57f1b99ac6db6626e6c78cb7b39e2026b59d1282",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "57f1b99ac6db6626e6c78cb7b39e2026b59d1282",
"triggerType" : "PUSH"
}, {
"hash" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154537643",
"triggerID" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"triggerType" : "PUSH"
}, {
"hash" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6506",
"triggerID" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"triggerType" : "PUSH"
}, {
"hash" : "897c7ac6b19baac21a7876c4eff087e774e8a928",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154587664",
"triggerID" : "897c7ac6b19baac21a7876c4eff087e774e8a928",
"triggerType" : "PUSH"
}, {
"hash" : "897c7ac6b19baac21a7876c4eff087e774e8a928",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6534",
"triggerID" : "897c7ac6b19baac21a7876c4eff087e774e8a928",
"triggerType" : "PUSH"
}, {
"hash" : "9358d99d522ca3aa6e769742f70624c85e46a149",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9358d99d522ca3aa6e769742f70624c85e46a149",
"triggerType" : "PUSH"
}, {
"hash" : "94c305ee8759318a1c18b9c795a957c44ba0d358",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154708769",
"triggerID" : "94c305ee8759318a1c18b9c795a957c44ba0d358",
"triggerType" : "PUSH"
}, {
"hash" : "94c305ee8759318a1c18b9c795a957c44ba0d358",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6549",
"triggerID" : "94c305ee8759318a1c18b9c795a957c44ba0d358",
"triggerType" : "PUSH"
}, {
"hash" : "558b2912c90948b03302d9462f7d91b4058b5bac",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154730068",
"triggerID" : "558b2912c90948b03302d9462f7d91b4058b5bac",
"triggerType" : "PUSH"
}, {
"hash" : "558b2912c90948b03302d9462f7d91b4058b5bac",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6559",
"triggerID" : "558b2912c90948b03302d9462f7d91b4058b5bac",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7f0c7e868fce22437c1b4b7a02fece52afb70f4a UNKNOWN
* 57f1b99ac6db6626e6c78cb7b39e2026b59d1282 UNKNOWN
* 9358d99d522ca3aa6e769742f70624c85e46a149 UNKNOWN
* 558b2912c90948b03302d9462f7d91b4058b5bac Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/154730068) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6559)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] liuyongvs commented on a change in pull request #11471:
[FLINK-16692] flink joblistener can register from config
Posted by GitBox <gi...@apache.org>.
liuyongvs commented on a change in pull request #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471#discussion_r396392748
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
##########
@@ -237,6 +237,13 @@ public ExecutionConfig getConfig() {
return cacheFile;
}
+ /**
+ * Gets the config JobListeners.
+ */
Review comment:
thanks, but ExecutionEnvironment is for Dataset api not DatatStream Api.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] kl0u commented on a change in pull request #11471:
[FLINK-16692] flink joblistener can register from config
Posted by GitBox <gi...@apache.org>.
kl0u commented on a change in pull request #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471#discussion_r396402442
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
##########
@@ -237,6 +237,13 @@ public ExecutionConfig getConfig() {
return cacheFile;
}
+ /**
+ * Gets the config JobListeners.
+ */
Review comment:
Yes, `ExecutionEnvironment` is for the `DataSet` API and there are also `JobListeners` there. So why not adding it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11471: [FLINK-16692]
flink joblistener can register from config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471#issuecomment-602012274
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6464",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
}, {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154358312",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
}, {
"hash" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154513464",
"triggerID" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"triggerType" : "PUSH"
}, {
"hash" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6493",
"triggerID" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"triggerType" : "PUSH"
}, {
"hash" : "7f0c7e868fce22437c1b4b7a02fece52afb70f4a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7f0c7e868fce22437c1b4b7a02fece52afb70f4a",
"triggerType" : "PUSH"
}, {
"hash" : "57f1b99ac6db6626e6c78cb7b39e2026b59d1282",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "57f1b99ac6db6626e6c78cb7b39e2026b59d1282",
"triggerType" : "PUSH"
}, {
"hash" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154537643",
"triggerID" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"triggerType" : "PUSH"
}, {
"hash" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6506",
"triggerID" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7f0c7e868fce22437c1b4b7a02fece52afb70f4a UNKNOWN
* 57f1b99ac6db6626e6c78cb7b39e2026b59d1282 UNKNOWN
* 84606e23725fc6c688ce72da42d06b8f30ac4910 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/154537643) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6506)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] liuyongvs commented on a change in pull request #11471:
[FLINK-16692] flink joblistener can register from config
Posted by GitBox <gi...@apache.org>.
liuyongvs commented on a change in pull request #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471#discussion_r396418575
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
##########
@@ -237,6 +237,13 @@ public ExecutionConfig getConfig() {
return cacheFile;
}
+ /**
+ * Gets the config JobListeners.
+ */
Review comment:
hi i have added
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11471: [FLINK-16692]
flink joblistener can register from config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471#issuecomment-602012274
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6464",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
}, {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154358312",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
}, {
"hash" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"status" : "CANCELED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154513464",
"triggerID" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"triggerType" : "PUSH"
}, {
"hash" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6493",
"triggerID" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"triggerType" : "PUSH"
}, {
"hash" : "7f0c7e868fce22437c1b4b7a02fece52afb70f4a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7f0c7e868fce22437c1b4b7a02fece52afb70f4a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ad9049971efa640a2b22ee8f258b0a0d7f64cc47 Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/154513464) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6493)
* 7f0c7e868fce22437c1b4b7a02fece52afb70f4a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] liuyongvs commented on issue #11471: [FLINK-16692] flink
joblistener can register from config
Posted by GitBox <gi...@apache.org>.
liuyongvs commented on issue #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471#issuecomment-602476909
Thanks you so much. Becase my personal PC doen't run fast. so i just not run on my PC and commits directly. i will commit with one commits next time.
> Hi @liuyongvs . Thanks for the work, I had some comments on the JIRA and I will have a better look at the PR now.
>
> In the meantime, could you make your changes as a single commit and rename your branch? Although not forced yet, we do not allow merge commits in the repo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] kl0u commented on a change in pull request #11471:
[FLINK-16692] flink joblistener can register from config
Posted by GitBox <gi...@apache.org>.
kl0u commented on a change in pull request #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471#discussion_r396289877
##########
File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironmentComplexConfigurationTest.java
##########
@@ -97,4 +105,47 @@ public void testNotOverridingCachedFilesFromConfiguration() {
Tuple2.of("file3", new DistributedCache.DistributedCacheEntry("/tmp3", true))
)));
}
+
+ @Test
+ public void testLoadingListenersFromConfiguration() {
+ StreamExecutionEnvironment envFromConfiguration = StreamExecutionEnvironment.getExecutionEnvironment();
+ List<Class> listenersClass = Arrays.asList(BasicJobSubmittedCounter.class, BasicJobExecutedCounter.class);
+
+ Configuration configuration = new Configuration();
+ configuration.setString("execution.job-listeners", listenersClass.stream().map(l -> l.getName()).collect(Collectors.joining(";")));
+
Review comment:
You can use the `ConfigUtils#encodeCollectionToConfig()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] kl0u commented on a change in pull request #11471:
[FLINK-16692] flink joblistener can register from config
Posted by GitBox <gi...@apache.org>.
kl0u commented on a change in pull request #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471#discussion_r396281963
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
##########
@@ -237,6 +237,13 @@ public ExecutionConfig getConfig() {
return cacheFile;
}
+ /**
+ * Gets the config JobListeners.
+ */
Review comment:
Annotate as `@PublicEvolving`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11471: [FLINK-16692]
flink joblistener can register from config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471#issuecomment-602012274
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6464",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
}, {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154358312",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
}, {
"hash" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154513464",
"triggerID" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"triggerType" : "PUSH"
}, {
"hash" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6493",
"triggerID" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"triggerType" : "PUSH"
}, {
"hash" : "7f0c7e868fce22437c1b4b7a02fece52afb70f4a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7f0c7e868fce22437c1b4b7a02fece52afb70f4a",
"triggerType" : "PUSH"
}, {
"hash" : "57f1b99ac6db6626e6c78cb7b39e2026b59d1282",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "57f1b99ac6db6626e6c78cb7b39e2026b59d1282",
"triggerType" : "PUSH"
}, {
"hash" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154537643",
"triggerID" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"triggerType" : "PUSH"
}, {
"hash" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6506",
"triggerID" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"triggerType" : "PUSH"
}, {
"hash" : "897c7ac6b19baac21a7876c4eff087e774e8a928",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "897c7ac6b19baac21a7876c4eff087e774e8a928",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7f0c7e868fce22437c1b4b7a02fece52afb70f4a UNKNOWN
* 57f1b99ac6db6626e6c78cb7b39e2026b59d1282 UNKNOWN
* 84606e23725fc6c688ce72da42d06b8f30ac4910 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/154537643) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6506)
* 897c7ac6b19baac21a7876c4eff087e774e8a928 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] liuyongvs edited a comment on issue #11471: [FLINK-16692]
flink joblistener can register from config
Posted by GitBox <gi...@apache.org>.
liuyongvs edited a comment on issue #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471#issuecomment-602476909
Thanks you so much. Becase my personal PC doesn't run fast. So i just don't run on my PC and commit directly. And i will commit with one commits next time.
> Hi @liuyongvs . Thanks for the work, I had some comments on the JIRA and I will have a better look at the PR now.
>
> In the meantime, could you make your changes as a single commit and rename your branch? Although not forced yet, we do not allow merge commits in the repo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] kl0u commented on issue #11471: [FLINK-16692] flink
joblistener can register from config
Posted by GitBox <gi...@apache.org>.
kl0u commented on issue #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471#issuecomment-602438160
Hi @liuyongvs . Thanks for the work, I had some comments on the JIRA and I will have a better look at the PR now. In the meantime, could you make your changes as a single commit? Although not forced yet, we do not allow merge commits in the repo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11471: [FLINK-16692]
flink joblistener can register from config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471#issuecomment-602012274
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6464",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
}, {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154358312",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
}, {
"hash" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154513464",
"triggerID" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"triggerType" : "PUSH"
}, {
"hash" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6493",
"triggerID" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"triggerType" : "PUSH"
}, {
"hash" : "7f0c7e868fce22437c1b4b7a02fece52afb70f4a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7f0c7e868fce22437c1b4b7a02fece52afb70f4a",
"triggerType" : "PUSH"
}, {
"hash" : "57f1b99ac6db6626e6c78cb7b39e2026b59d1282",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "57f1b99ac6db6626e6c78cb7b39e2026b59d1282",
"triggerType" : "PUSH"
}, {
"hash" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154537643",
"triggerID" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"triggerType" : "PUSH"
}, {
"hash" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6506",
"triggerID" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"triggerType" : "PUSH"
}, {
"hash" : "897c7ac6b19baac21a7876c4eff087e774e8a928",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154587664",
"triggerID" : "897c7ac6b19baac21a7876c4eff087e774e8a928",
"triggerType" : "PUSH"
}, {
"hash" : "897c7ac6b19baac21a7876c4eff087e774e8a928",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6534",
"triggerID" : "897c7ac6b19baac21a7876c4eff087e774e8a928",
"triggerType" : "PUSH"
}, {
"hash" : "9358d99d522ca3aa6e769742f70624c85e46a149",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9358d99d522ca3aa6e769742f70624c85e46a149",
"triggerType" : "PUSH"
}, {
"hash" : "94c305ee8759318a1c18b9c795a957c44ba0d358",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154708769",
"triggerID" : "94c305ee8759318a1c18b9c795a957c44ba0d358",
"triggerType" : "PUSH"
}, {
"hash" : "94c305ee8759318a1c18b9c795a957c44ba0d358",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6549",
"triggerID" : "94c305ee8759318a1c18b9c795a957c44ba0d358",
"triggerType" : "PUSH"
}, {
"hash" : "558b2912c90948b03302d9462f7d91b4058b5bac",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154730068",
"triggerID" : "558b2912c90948b03302d9462f7d91b4058b5bac",
"triggerType" : "PUSH"
}, {
"hash" : "558b2912c90948b03302d9462f7d91b4058b5bac",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6559",
"triggerID" : "558b2912c90948b03302d9462f7d91b4058b5bac",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7f0c7e868fce22437c1b4b7a02fece52afb70f4a UNKNOWN
* 57f1b99ac6db6626e6c78cb7b39e2026b59d1282 UNKNOWN
* 9358d99d522ca3aa6e769742f70624c85e46a149 UNKNOWN
* 94c305ee8759318a1c18b9c795a957c44ba0d358 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/154708769) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6549)
* 558b2912c90948b03302d9462f7d91b4058b5bac Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/154730068) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6559)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11471: [FLINK-16692] flink
joblistener can register from config
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471#issuecomment-602011515
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 88e613d77d95f9edf47e1c59f2ce078e3717383f (Sat Mar 21 08:02:53 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-16692).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] kl0u commented on issue #11471: [FLINK-16692] flink
joblistener can register from config
Posted by GitBox <gi...@apache.org>.
kl0u commented on issue #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471#issuecomment-603143301
@liuyongvs I am reviewing currently your PR. This is the branch https://github.com/kl0u/flink/tree/listeners that I created based on your commits. Please check if all your changes are included, and if I have any comments, please integrate them on that branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11471: [FLINK-16692]
flink joblistener can register from config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471#issuecomment-602012274
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6464",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
}, {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154358312",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
}, {
"hash" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154513464",
"triggerID" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"triggerType" : "PUSH"
}, {
"hash" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6493",
"triggerID" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"triggerType" : "PUSH"
}, {
"hash" : "7f0c7e868fce22437c1b4b7a02fece52afb70f4a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7f0c7e868fce22437c1b4b7a02fece52afb70f4a",
"triggerType" : "PUSH"
}, {
"hash" : "57f1b99ac6db6626e6c78cb7b39e2026b59d1282",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "57f1b99ac6db6626e6c78cb7b39e2026b59d1282",
"triggerType" : "PUSH"
}, {
"hash" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154537643",
"triggerID" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"triggerType" : "PUSH"
}, {
"hash" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6506",
"triggerID" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"triggerType" : "PUSH"
}, {
"hash" : "897c7ac6b19baac21a7876c4eff087e774e8a928",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154587664",
"triggerID" : "897c7ac6b19baac21a7876c4eff087e774e8a928",
"triggerType" : "PUSH"
}, {
"hash" : "897c7ac6b19baac21a7876c4eff087e774e8a928",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6534",
"triggerID" : "897c7ac6b19baac21a7876c4eff087e774e8a928",
"triggerType" : "PUSH"
}, {
"hash" : "9358d99d522ca3aa6e769742f70624c85e46a149",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9358d99d522ca3aa6e769742f70624c85e46a149",
"triggerType" : "PUSH"
}, {
"hash" : "94c305ee8759318a1c18b9c795a957c44ba0d358",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154708769",
"triggerID" : "94c305ee8759318a1c18b9c795a957c44ba0d358",
"triggerType" : "PUSH"
}, {
"hash" : "94c305ee8759318a1c18b9c795a957c44ba0d358",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6549",
"triggerID" : "94c305ee8759318a1c18b9c795a957c44ba0d358",
"triggerType" : "PUSH"
}, {
"hash" : "558b2912c90948b03302d9462f7d91b4058b5bac",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "558b2912c90948b03302d9462f7d91b4058b5bac",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7f0c7e868fce22437c1b4b7a02fece52afb70f4a UNKNOWN
* 57f1b99ac6db6626e6c78cb7b39e2026b59d1282 UNKNOWN
* 9358d99d522ca3aa6e769742f70624c85e46a149 UNKNOWN
* 94c305ee8759318a1c18b9c795a957c44ba0d358 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/154708769) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6549)
* 558b2912c90948b03302d9462f7d91b4058b5bac UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] liuyongvs commented on a change in pull request #11471:
[FLINK-16692] flink joblistener can register from config
Posted by GitBox <gi...@apache.org>.
liuyongvs commented on a change in pull request #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471#discussion_r396413590
##########
File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironmentComplexConfigurationTest.java
##########
@@ -97,4 +105,47 @@ public void testNotOverridingCachedFilesFromConfiguration() {
Tuple2.of("file3", new DistributedCache.DistributedCacheEntry("/tmp3", true))
)));
}
+
+ @Test
+ public void testLoadingListenersFromConfiguration() {
+ StreamExecutionEnvironment envFromConfiguration = StreamExecutionEnvironment.getExecutionEnvironment();
+ List<Class> listenersClass = Arrays.asList(BasicJobSubmittedCounter.class, BasicJobExecutedCounter.class);
+
+ Configuration configuration = new Configuration();
+ configuration.setString("execution.job-listeners", listenersClass.stream().map(l -> l.getName()).collect(Collectors.joining(";")));
+
Review comment:
hi, i have already fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] kl0u edited a comment on issue #11471: [FLINK-16692] flink
joblistener can register from config
Posted by GitBox <gi...@apache.org>.
kl0u edited a comment on issue #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471#issuecomment-602438160
Hi @liuyongvs . Thanks for the work, I had some comments on the JIRA and I will have a better look at the PR now.
In the meantime, could you make your changes as a single commit and rename your branch? Although not forced yet, we do not allow merge commits in the repo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11471: [FLINK-16692]
flink joblistener can register from config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11471: [FLINK-16692] flink joblistener can register from config
URL: https://github.com/apache/flink/pull/11471#issuecomment-602012274
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6464",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
}, {
"hash" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154358312",
"triggerID" : "88e613d77d95f9edf47e1c59f2ce078e3717383f",
"triggerType" : "PUSH"
}, {
"hash" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154513464",
"triggerID" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"triggerType" : "PUSH"
}, {
"hash" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6493",
"triggerID" : "ad9049971efa640a2b22ee8f258b0a0d7f64cc47",
"triggerType" : "PUSH"
}, {
"hash" : "7f0c7e868fce22437c1b4b7a02fece52afb70f4a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7f0c7e868fce22437c1b4b7a02fece52afb70f4a",
"triggerType" : "PUSH"
}, {
"hash" : "57f1b99ac6db6626e6c78cb7b39e2026b59d1282",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "57f1b99ac6db6626e6c78cb7b39e2026b59d1282",
"triggerType" : "PUSH"
}, {
"hash" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154537643",
"triggerID" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"triggerType" : "PUSH"
}, {
"hash" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6506",
"triggerID" : "84606e23725fc6c688ce72da42d06b8f30ac4910",
"triggerType" : "PUSH"
}, {
"hash" : "897c7ac6b19baac21a7876c4eff087e774e8a928",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154587664",
"triggerID" : "897c7ac6b19baac21a7876c4eff087e774e8a928",
"triggerType" : "PUSH"
}, {
"hash" : "897c7ac6b19baac21a7876c4eff087e774e8a928",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6534",
"triggerID" : "897c7ac6b19baac21a7876c4eff087e774e8a928",
"triggerType" : "PUSH"
}, {
"hash" : "9358d99d522ca3aa6e769742f70624c85e46a149",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9358d99d522ca3aa6e769742f70624c85e46a149",
"triggerType" : "PUSH"
}, {
"hash" : "94c305ee8759318a1c18b9c795a957c44ba0d358",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154708769",
"triggerID" : "94c305ee8759318a1c18b9c795a957c44ba0d358",
"triggerType" : "PUSH"
}, {
"hash" : "94c305ee8759318a1c18b9c795a957c44ba0d358",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6549",
"triggerID" : "94c305ee8759318a1c18b9c795a957c44ba0d358",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7f0c7e868fce22437c1b4b7a02fece52afb70f4a UNKNOWN
* 57f1b99ac6db6626e6c78cb7b39e2026b59d1282 UNKNOWN
* 9358d99d522ca3aa6e769742f70624c85e46a149 UNKNOWN
* 94c305ee8759318a1c18b9c795a957c44ba0d358 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/154708769) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6549)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services