You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wink.apache.org by "Bryant Luk (JIRA)" <ji...@apache.org> on 2009/07/12 06:31:14 UTC
[jira] Created: (WINK-75) Change
com.google.code.maven-license-plugin legal plugin to not be inherited
Change com.google.code.maven-license-plugin legal plugin to not be inherited
----------------------------------------------------------------------------
Key: WINK-75
URL: https://issues.apache.org/jira/browse/WINK-75
Project: Wink
Issue Type: Improvement
Components: Build
Affects Versions: 0.1
Reporter: Bryant Luk
Assignee: Bryant Luk
This JIRA is for changing the main pom.xml:
<plugin>
<groupId>com.google.code.maven-license-plugin</groupId>
<artifactId>maven-license-plugin</artifactId>
+ <inherited>false</inherited>
<configuration>
- <header>${module.relative.path}src/etc/header.txt</header>
+ <header>src/etc/header.txt</header>
<quiet>false</quiet>
<failIfMissing>true</failIfMissing>
<aggregate>true</aggregate>
<includes>
- <include>src/**</include>
+ <include>**/src/**</include>
<include>**/test/**</include>
</includes>
<excludes>
Random testing (removing license info on files in submodules) seemed to show this plugin working still. This will enable modules to be more easily created/moved around if necessary.
I think it's still a good idea to run the license plugin on mvn install in the default profile to give a heads up before a bad build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (WINK-75) Change
com.google.code.maven-license-plugin legal plugin to not be inherited
Posted by "Bryant Luk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-75?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryant Luk closed WINK-75.
--------------------------
Resolution: Fixed
Thanks Jason for the patch.
> Change com.google.code.maven-license-plugin legal plugin to not be inherited
> ----------------------------------------------------------------------------
>
> Key: WINK-75
> URL: https://issues.apache.org/jira/browse/WINK-75
> Project: Wink
> Issue Type: Improvement
> Components: Build
> Affects Versions: 0.1
> Reporter: Bryant Luk
> Assignee: Bryant Luk
> Fix For: 0.1
>
> Attachments: WINK-75.patch
>
>
> This JIRA is for changing the main pom.xml:
> {noformat}
> <plugin>
> <groupId>com.google.code.maven-license-plugin</groupId>
> <artifactId>maven-license-plugin</artifactId>
> + <inherited>false</inherited>
> <configuration>
> - <header>${module.relative.path}src/etc/header.txt</header>
> + <header>src/etc/header.txt</header>
> <quiet>false</quiet>
> <failIfMissing>true</failIfMissing>
> <aggregate>true</aggregate>
> <includes>
> - <include>src/**</include>
> + <include>**/src/**</include>
> <include>**/test/**</include>
> </includes>
> <excludes>
> {noformat}
> Random testing (removing license info on files in submodules) seemed to show this plugin working still. This will enable modules to be more easily created/moved around if necessary.
> I think it's still a good idea to run the license plugin on mvn install in the default profile to give a heads up before a bad build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (WINK-75) Change
com.google.code.maven-license-plugin legal plugin to not be inherited
Posted by "Bryant Luk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-75?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryant Luk closed WINK-75.
--------------------------
Resolution: Fixed
Fix Version/s: 0.1
No known problems.
> Change com.google.code.maven-license-plugin legal plugin to not be inherited
> ----------------------------------------------------------------------------
>
> Key: WINK-75
> URL: https://issues.apache.org/jira/browse/WINK-75
> Project: Wink
> Issue Type: Improvement
> Components: Build
> Affects Versions: 0.1
> Reporter: Bryant Luk
> Assignee: Bryant Luk
> Fix For: 0.1
>
>
> This JIRA is for changing the main pom.xml:
> {noformat}
> <plugin>
> <groupId>com.google.code.maven-license-plugin</groupId>
> <artifactId>maven-license-plugin</artifactId>
> + <inherited>false</inherited>
> <configuration>
> - <header>${module.relative.path}src/etc/header.txt</header>
> + <header>src/etc/header.txt</header>
> <quiet>false</quiet>
> <failIfMissing>true</failIfMissing>
> <aggregate>true</aggregate>
> <includes>
> - <include>src/**</include>
> + <include>**/src/**</include>
> <include>**/test/**</include>
> </includes>
> <excludes>
> {noformat}
> Random testing (removing license info on files in submodules) seemed to show this plugin working still. This will enable modules to be more easily created/moved around if necessary.
> I think it's still a good idea to run the license plugin on mvn install in the default profile to give a heads up before a bad build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-75) Change
com.google.code.maven-license-plugin legal plugin to not be inherited
Posted by "Martin Snitkovsky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730046#action_12730046 ]
Martin Snitkovsky commented on WINK-75:
---------------------------------------
+1 for the change. Tested the change, and it works fine
I also agree that the plug-in should run on each mvn install.
> Change com.google.code.maven-license-plugin legal plugin to not be inherited
> ----------------------------------------------------------------------------
>
> Key: WINK-75
> URL: https://issues.apache.org/jira/browse/WINK-75
> Project: Wink
> Issue Type: Improvement
> Components: Build
> Affects Versions: 0.1
> Reporter: Bryant Luk
> Assignee: Bryant Luk
>
> This JIRA is for changing the main pom.xml:
> <plugin>
> <groupId>com.google.code.maven-license-plugin</groupId>
> <artifactId>maven-license-plugin</artifactId>
> + <inherited>false</inherited>
> <configuration>
> - <header>${module.relative.path}src/etc/header.txt</header>
> + <header>src/etc/header.txt</header>
> <quiet>false</quiet>
> <failIfMissing>true</failIfMissing>
> <aggregate>true</aggregate>
> <includes>
> - <include>src/**</include>
> + <include>**/src/**</include>
> <include>**/test/**</include>
> </includes>
> <excludes>
> Random testing (removing license info on files in submodules) seemed to show this plugin working still. This will enable modules to be more easily created/moved around if necessary.
> I think it's still a good idea to run the license plugin on mvn install in the default profile to give a heads up before a bad build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-75) Change
com.google.code.maven-license-plugin legal plugin to not be inherited
Posted by "Bryant Luk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730903#action_12730903 ]
Bryant Luk commented on WINK-75:
--------------------------------
>The verify phase executes before the install phase.
Ahh, good to know. Still new to this whole Maven stuff.
> Change com.google.code.maven-license-plugin legal plugin to not be inherited
> ----------------------------------------------------------------------------
>
> Key: WINK-75
> URL: https://issues.apache.org/jira/browse/WINK-75
> Project: Wink
> Issue Type: Improvement
> Components: Build
> Affects Versions: 0.1
> Reporter: Bryant Luk
> Assignee: Bryant Luk
> Fix For: 0.1
>
> Attachments: WINK-75.patch
>
>
> This JIRA is for changing the main pom.xml:
> {noformat}
> <plugin>
> <groupId>com.google.code.maven-license-plugin</groupId>
> <artifactId>maven-license-plugin</artifactId>
> + <inherited>false</inherited>
> <configuration>
> - <header>${module.relative.path}src/etc/header.txt</header>
> + <header>src/etc/header.txt</header>
> <quiet>false</quiet>
> <failIfMissing>true</failIfMissing>
> <aggregate>true</aggregate>
> <includes>
> - <include>src/**</include>
> + <include>**/src/**</include>
> <include>**/test/**</include>
> </includes>
> <excludes>
> {noformat}
> Random testing (removing license info on files in submodules) seemed to show this plugin working still. This will enable modules to be more easily created/moved around if necessary.
> I think it's still a good idea to run the license plugin on mvn install in the default profile to give a heads up before a bad build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-75) Change
com.google.code.maven-license-plugin legal plugin to not be inherited
Posted by "Jason Dillon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730686#action_12730686 ]
Jason Dillon commented on WINK-75:
----------------------------------
This does work, but is missing a few files. Specifically the excludes of *.apt. It would also be nice if some of the internal non/spec required files like wink-providers and such could have some sort of extension to clue the scanner that these files can use script style comments, and those files that can take them should all have a header applied.
> Change com.google.code.maven-license-plugin legal plugin to not be inherited
> ----------------------------------------------------------------------------
>
> Key: WINK-75
> URL: https://issues.apache.org/jira/browse/WINK-75
> Project: Wink
> Issue Type: Improvement
> Components: Build
> Affects Versions: 0.1
> Reporter: Bryant Luk
> Assignee: Bryant Luk
> Fix For: 0.1
>
>
> This JIRA is for changing the main pom.xml:
> {noformat}
> <plugin>
> <groupId>com.google.code.maven-license-plugin</groupId>
> <artifactId>maven-license-plugin</artifactId>
> + <inherited>false</inherited>
> <configuration>
> - <header>${module.relative.path}src/etc/header.txt</header>
> + <header>src/etc/header.txt</header>
> <quiet>false</quiet>
> <failIfMissing>true</failIfMissing>
> <aggregate>true</aggregate>
> <includes>
> - <include>src/**</include>
> + <include>**/src/**</include>
> <include>**/test/**</include>
> </includes>
> <excludes>
> {noformat}
> Random testing (removing license info on files in submodules) seemed to show this plugin working still. This will enable modules to be more easily created/moved around if necessary.
> I think it's still a good idea to run the license plugin on mvn install in the default profile to give a heads up before a bad build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-75) Change
com.google.code.maven-license-plugin legal plugin to not be inherited
Posted by "Bryant Luk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730884#action_12730884 ]
Bryant Luk commented on WINK-75:
--------------------------------
I'll go ahead and apply this patch. This did change the phase to "verify" instead of "install" but I don't see too much of an issue there and it makes better "Maven sense" I think.
> Change com.google.code.maven-license-plugin legal plugin to not be inherited
> ----------------------------------------------------------------------------
>
> Key: WINK-75
> URL: https://issues.apache.org/jira/browse/WINK-75
> Project: Wink
> Issue Type: Improvement
> Components: Build
> Affects Versions: 0.1
> Reporter: Bryant Luk
> Assignee: Bryant Luk
> Fix For: 0.1
>
> Attachments: WINK-75.patch
>
>
> This JIRA is for changing the main pom.xml:
> {noformat}
> <plugin>
> <groupId>com.google.code.maven-license-plugin</groupId>
> <artifactId>maven-license-plugin</artifactId>
> + <inherited>false</inherited>
> <configuration>
> - <header>${module.relative.path}src/etc/header.txt</header>
> + <header>src/etc/header.txt</header>
> <quiet>false</quiet>
> <failIfMissing>true</failIfMissing>
> <aggregate>true</aggregate>
> <includes>
> - <include>src/**</include>
> + <include>**/src/**</include>
> <include>**/test/**</include>
> </includes>
> <excludes>
> {noformat}
> Random testing (removing license info on files in submodules) seemed to show this plugin working still. This will enable modules to be more easily created/moved around if necessary.
> I think it's still a good idea to run the license plugin on mvn install in the default profile to give a heads up before a bad build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-75) Change
com.google.code.maven-license-plugin legal plugin to not be inherited
Posted by "Jason Dillon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730889#action_12730889 ]
Jason Dillon commented on WINK-75:
----------------------------------
The verify phase executes before the install phase. This means that if there are legal header problems that the jars will not make it into the repository.
> Change com.google.code.maven-license-plugin legal plugin to not be inherited
> ----------------------------------------------------------------------------
>
> Key: WINK-75
> URL: https://issues.apache.org/jira/browse/WINK-75
> Project: Wink
> Issue Type: Improvement
> Components: Build
> Affects Versions: 0.1
> Reporter: Bryant Luk
> Assignee: Bryant Luk
> Fix For: 0.1
>
> Attachments: WINK-75.patch
>
>
> This JIRA is for changing the main pom.xml:
> {noformat}
> <plugin>
> <groupId>com.google.code.maven-license-plugin</groupId>
> <artifactId>maven-license-plugin</artifactId>
> + <inherited>false</inherited>
> <configuration>
> - <header>${module.relative.path}src/etc/header.txt</header>
> + <header>src/etc/header.txt</header>
> <quiet>false</quiet>
> <failIfMissing>true</failIfMissing>
> <aggregate>true</aggregate>
> <includes>
> - <include>src/**</include>
> + <include>**/src/**</include>
> <include>**/test/**</include>
> </includes>
> <excludes>
> {noformat}
> Random testing (removing license info on files in submodules) seemed to show this plugin working still. This will enable modules to be more easily created/moved around if necessary.
> I think it's still a good idea to run the license plugin on mvn install in the default profile to give a heads up before a bad build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WINK-75) Change
com.google.code.maven-license-plugin legal plugin to not be inherited
Posted by "Jason Dillon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-75?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason Dillon updated WINK-75:
-----------------------------
Patch Info: [Patch Available]
> Change com.google.code.maven-license-plugin legal plugin to not be inherited
> ----------------------------------------------------------------------------
>
> Key: WINK-75
> URL: https://issues.apache.org/jira/browse/WINK-75
> Project: Wink
> Issue Type: Improvement
> Components: Build
> Affects Versions: 0.1
> Reporter: Bryant Luk
> Assignee: Bryant Luk
> Fix For: 0.1
>
> Attachments: WINK-75.patch
>
>
> This JIRA is for changing the main pom.xml:
> {noformat}
> <plugin>
> <groupId>com.google.code.maven-license-plugin</groupId>
> <artifactId>maven-license-plugin</artifactId>
> + <inherited>false</inherited>
> <configuration>
> - <header>${module.relative.path}src/etc/header.txt</header>
> + <header>src/etc/header.txt</header>
> <quiet>false</quiet>
> <failIfMissing>true</failIfMissing>
> <aggregate>true</aggregate>
> <includes>
> - <include>src/**</include>
> + <include>**/src/**</include>
> <include>**/test/**</include>
> </includes>
> <excludes>
> {noformat}
> Random testing (removing license info on files in submodules) seemed to show this plugin working still. This will enable modules to be more easily created/moved around if necessary.
> I think it's still a good idea to run the license plugin on mvn install in the default profile to give a heads up before a bad build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Work started: (WINK-75) Change
com.google.code.maven-license-plugin legal plugin to not be inherited
Posted by "Bryant Luk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-75?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on WINK-75 started by Bryant Luk.
> Change com.google.code.maven-license-plugin legal plugin to not be inherited
> ----------------------------------------------------------------------------
>
> Key: WINK-75
> URL: https://issues.apache.org/jira/browse/WINK-75
> Project: Wink
> Issue Type: Improvement
> Components: Build
> Affects Versions: 0.1
> Reporter: Bryant Luk
> Assignee: Bryant Luk
>
> This JIRA is for changing the main pom.xml:
> <plugin>
> <groupId>com.google.code.maven-license-plugin</groupId>
> <artifactId>maven-license-plugin</artifactId>
> + <inherited>false</inherited>
> <configuration>
> - <header>${module.relative.path}src/etc/header.txt</header>
> + <header>src/etc/header.txt</header>
> <quiet>false</quiet>
> <failIfMissing>true</failIfMissing>
> <aggregate>true</aggregate>
> <includes>
> - <include>src/**</include>
> + <include>**/src/**</include>
> <include>**/test/**</include>
> </includes>
> <excludes>
> Random testing (removing license info on files in submodules) seemed to show this plugin working still. This will enable modules to be more easily created/moved around if necessary.
> I think it's still a good idea to run the license plugin on mvn install in the default profile to give a heads up before a bad build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-75) Change
com.google.code.maven-license-plugin legal plugin to not be inherited
Posted by "Jason Dillon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730047#action_12730047 ]
Jason Dillon commented on WINK-75:
----------------------------------
It seems to check fast enough to leave in the default build.
> Change com.google.code.maven-license-plugin legal plugin to not be inherited
> ----------------------------------------------------------------------------
>
> Key: WINK-75
> URL: https://issues.apache.org/jira/browse/WINK-75
> Project: Wink
> Issue Type: Improvement
> Components: Build
> Affects Versions: 0.1
> Reporter: Bryant Luk
> Assignee: Bryant Luk
>
> This JIRA is for changing the main pom.xml:
> <plugin>
> <groupId>com.google.code.maven-license-plugin</groupId>
> <artifactId>maven-license-plugin</artifactId>
> + <inherited>false</inherited>
> <configuration>
> - <header>${module.relative.path}src/etc/header.txt</header>
> + <header>src/etc/header.txt</header>
> <quiet>false</quiet>
> <failIfMissing>true</failIfMissing>
> <aggregate>true</aggregate>
> <includes>
> - <include>src/**</include>
> + <include>**/src/**</include>
> <include>**/test/**</include>
> </includes>
> <excludes>
> Random testing (removing license info on files in submodules) seemed to show this plugin working still. This will enable modules to be more easily created/moved around if necessary.
> I think it's still a good idea to run the license plugin on mvn install in the default profile to give a heads up before a bad build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-75) Change
com.google.code.maven-license-plugin legal plugin to not be inherited
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730936#action_12730936 ]
Hudson commented on WINK-75:
----------------------------
Integrated in Wink-Trunk-JDK1.5 #3 (See [http://hudson.zones.apache.org/hudson/job/Wink-Trunk-JDK1.5/3/])
More changes to license headers scanning.
Patch from Jason Dillon. Note that this
changes license scanning to verify
phase.
See [].
> Change com.google.code.maven-license-plugin legal plugin to not be inherited
> ----------------------------------------------------------------------------
>
> Key: WINK-75
> URL: https://issues.apache.org/jira/browse/WINK-75
> Project: Wink
> Issue Type: Improvement
> Components: Build
> Affects Versions: 0.1
> Reporter: Bryant Luk
> Assignee: Bryant Luk
> Fix For: 0.1
>
> Attachments: WINK-75.patch
>
>
> This JIRA is for changing the main pom.xml:
> {noformat}
> <plugin>
> <groupId>com.google.code.maven-license-plugin</groupId>
> <artifactId>maven-license-plugin</artifactId>
> + <inherited>false</inherited>
> <configuration>
> - <header>${module.relative.path}src/etc/header.txt</header>
> + <header>src/etc/header.txt</header>
> <quiet>false</quiet>
> <failIfMissing>true</failIfMissing>
> <aggregate>true</aggregate>
> <includes>
> - <include>src/**</include>
> + <include>**/src/**</include>
> <include>**/test/**</include>
> </includes>
> <excludes>
> {noformat}
> Random testing (removing license info on files in submodules) seemed to show this plugin working still. This will enable modules to be more easily created/moved around if necessary.
> I think it's still a good idea to run the license plugin on mvn install in the default profile to give a heads up before a bad build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-75) Change
com.google.code.maven-license-plugin legal plugin to not be inherited
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730048#action_12730048 ]
Hudson commented on WINK-75:
----------------------------
Integrated in Wink-Trunk-JDK15 #22 (See [http://hudson.zones.apache.org/hudson/job/Wink-Trunk-JDK15/22/])
Do not use maven-license-plugin in submodules
See []
> Change com.google.code.maven-license-plugin legal plugin to not be inherited
> ----------------------------------------------------------------------------
>
> Key: WINK-75
> URL: https://issues.apache.org/jira/browse/WINK-75
> Project: Wink
> Issue Type: Improvement
> Components: Build
> Affects Versions: 0.1
> Reporter: Bryant Luk
> Assignee: Bryant Luk
>
> This JIRA is for changing the main pom.xml:
> <plugin>
> <groupId>com.google.code.maven-license-plugin</groupId>
> <artifactId>maven-license-plugin</artifactId>
> + <inherited>false</inherited>
> <configuration>
> - <header>${module.relative.path}src/etc/header.txt</header>
> + <header>src/etc/header.txt</header>
> <quiet>false</quiet>
> <failIfMissing>true</failIfMissing>
> <aggregate>true</aggregate>
> <includes>
> - <include>src/**</include>
> + <include>**/src/**</include>
> <include>**/test/**</include>
> </includes>
> <excludes>
> Random testing (removing license info on files in submodules) seemed to show this plugin working still. This will enable modules to be more easily created/moved around if necessary.
> I think it's still a good idea to run the license plugin on mvn install in the default profile to give a heads up before a bad build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (WINK-75) Change
com.google.code.maven-license-plugin legal plugin to not be inherited
Posted by "Jason Dillon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-75?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason Dillon reopened WINK-75:
------------------------------
Needs a few minor changes
> Change com.google.code.maven-license-plugin legal plugin to not be inherited
> ----------------------------------------------------------------------------
>
> Key: WINK-75
> URL: https://issues.apache.org/jira/browse/WINK-75
> Project: Wink
> Issue Type: Improvement
> Components: Build
> Affects Versions: 0.1
> Reporter: Bryant Luk
> Assignee: Bryant Luk
> Fix For: 0.1
>
> Attachments: WINK-75.patch
>
>
> This JIRA is for changing the main pom.xml:
> {noformat}
> <plugin>
> <groupId>com.google.code.maven-license-plugin</groupId>
> <artifactId>maven-license-plugin</artifactId>
> + <inherited>false</inherited>
> <configuration>
> - <header>${module.relative.path}src/etc/header.txt</header>
> + <header>src/etc/header.txt</header>
> <quiet>false</quiet>
> <failIfMissing>true</failIfMissing>
> <aggregate>true</aggregate>
> <includes>
> - <include>src/**</include>
> + <include>**/src/**</include>
> <include>**/test/**</include>
> </includes>
> <excludes>
> {noformat}
> Random testing (removing license info on files in submodules) seemed to show this plugin working still. This will enable modules to be more easily created/moved around if necessary.
> I think it's still a good idea to run the license plugin on mvn install in the default profile to give a heads up before a bad build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WINK-75) Change
com.google.code.maven-license-plugin legal plugin to not be inherited
Posted by "Jason Dillon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-75?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason Dillon updated WINK-75:
-----------------------------
Attachment: WINK-75.patch
> Change com.google.code.maven-license-plugin legal plugin to not be inherited
> ----------------------------------------------------------------------------
>
> Key: WINK-75
> URL: https://issues.apache.org/jira/browse/WINK-75
> Project: Wink
> Issue Type: Improvement
> Components: Build
> Affects Versions: 0.1
> Reporter: Bryant Luk
> Assignee: Bryant Luk
> Fix For: 0.1
>
> Attachments: WINK-75.patch
>
>
> This JIRA is for changing the main pom.xml:
> {noformat}
> <plugin>
> <groupId>com.google.code.maven-license-plugin</groupId>
> <artifactId>maven-license-plugin</artifactId>
> + <inherited>false</inherited>
> <configuration>
> - <header>${module.relative.path}src/etc/header.txt</header>
> + <header>src/etc/header.txt</header>
> <quiet>false</quiet>
> <failIfMissing>true</failIfMissing>
> <aggregate>true</aggregate>
> <includes>
> - <include>src/**</include>
> + <include>**/src/**</include>
> <include>**/test/**</include>
> </includes>
> <excludes>
> {noformat}
> Random testing (removing license info on files in submodules) seemed to show this plugin working still. This will enable modules to be more easily created/moved around if necessary.
> I think it's still a good idea to run the license plugin on mvn install in the default profile to give a heads up before a bad build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WINK-75) Change
com.google.code.maven-license-plugin legal plugin to not be inherited
Posted by "Jason Dillon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-75?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason Dillon updated WINK-75:
-----------------------------
Description:
This JIRA is for changing the main pom.xml:
{noformat}
<plugin>
<groupId>com.google.code.maven-license-plugin</groupId>
<artifactId>maven-license-plugin</artifactId>
+ <inherited>false</inherited>
<configuration>
- <header>${module.relative.path}src/etc/header.txt</header>
+ <header>src/etc/header.txt</header>
<quiet>false</quiet>
<failIfMissing>true</failIfMissing>
<aggregate>true</aggregate>
<includes>
- <include>src/**</include>
+ <include>**/src/**</include>
<include>**/test/**</include>
</includes>
<excludes>
{noformat}
Random testing (removing license info on files in submodules) seemed to show this plugin working still. This will enable modules to be more easily created/moved around if necessary.
I think it's still a good idea to run the license plugin on mvn install in the default profile to give a heads up before a bad build.
was:
This JIRA is for changing the main pom.xml:
<plugin>
<groupId>com.google.code.maven-license-plugin</groupId>
<artifactId>maven-license-plugin</artifactId>
+ <inherited>false</inherited>
<configuration>
- <header>${module.relative.path}src/etc/header.txt</header>
+ <header>src/etc/header.txt</header>
<quiet>false</quiet>
<failIfMissing>true</failIfMissing>
<aggregate>true</aggregate>
<includes>
- <include>src/**</include>
+ <include>**/src/**</include>
<include>**/test/**</include>
</includes>
<excludes>
Random testing (removing license info on files in submodules) seemed to show this plugin working still. This will enable modules to be more easily created/moved around if necessary.
I think it's still a good idea to run the license plugin on mvn install in the default profile to give a heads up before a bad build.
> Change com.google.code.maven-license-plugin legal plugin to not be inherited
> ----------------------------------------------------------------------------
>
> Key: WINK-75
> URL: https://issues.apache.org/jira/browse/WINK-75
> Project: Wink
> Issue Type: Improvement
> Components: Build
> Affects Versions: 0.1
> Reporter: Bryant Luk
> Assignee: Bryant Luk
>
> This JIRA is for changing the main pom.xml:
> {noformat}
> <plugin>
> <groupId>com.google.code.maven-license-plugin</groupId>
> <artifactId>maven-license-plugin</artifactId>
> + <inherited>false</inherited>
> <configuration>
> - <header>${module.relative.path}src/etc/header.txt</header>
> + <header>src/etc/header.txt</header>
> <quiet>false</quiet>
> <failIfMissing>true</failIfMissing>
> <aggregate>true</aggregate>
> <includes>
> - <include>src/**</include>
> + <include>**/src/**</include>
> <include>**/test/**</include>
> </includes>
> <excludes>
> {noformat}
> Random testing (removing license info on files in submodules) seemed to show this plugin working still. This will enable modules to be more easily created/moved around if necessary.
> I think it's still a good idea to run the license plugin on mvn install in the default profile to give a heads up before a bad build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-75) Change
com.google.code.maven-license-plugin legal plugin to not be inherited
Posted by "Bryant Luk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730042#action_12730042 ]
Bryant Luk commented on WINK-75:
--------------------------------
I'll go ahead and make the change to see if any unforseen issues come up.
> Change com.google.code.maven-license-plugin legal plugin to not be inherited
> ----------------------------------------------------------------------------
>
> Key: WINK-75
> URL: https://issues.apache.org/jira/browse/WINK-75
> Project: Wink
> Issue Type: Improvement
> Components: Build
> Affects Versions: 0.1
> Reporter: Bryant Luk
> Assignee: Bryant Luk
>
> This JIRA is for changing the main pom.xml:
> <plugin>
> <groupId>com.google.code.maven-license-plugin</groupId>
> <artifactId>maven-license-plugin</artifactId>
> + <inherited>false</inherited>
> <configuration>
> - <header>${module.relative.path}src/etc/header.txt</header>
> + <header>src/etc/header.txt</header>
> <quiet>false</quiet>
> <failIfMissing>true</failIfMissing>
> <aggregate>true</aggregate>
> <includes>
> - <include>src/**</include>
> + <include>**/src/**</include>
> <include>**/test/**</include>
> </includes>
> <excludes>
> Random testing (removing license info on files in submodules) seemed to show this plugin working still. This will enable modules to be more easily created/moved around if necessary.
> I think it's still a good idea to run the license plugin on mvn install in the default profile to give a heads up before a bad build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.