You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@datasketches.apache.org by Charlie Dickens <ch...@yahooinc.com.INVALID> on 2023/12/05 10:33:00 UTC

Re: [E] [VOTE] Release Apache DataSketches-java 5.0.0-RC1

+1
Downloaded and install using java version "1.8.0_391" on mac os ventura 13.6
Ran mvn clean test and all tests ran with 0 failures.

On Tue, 5 Dec 2023 at 07:19, Lee Rhodes <le...@gmail.com> wrote:

> ### clean-up and consolidation of quantiles APIs
> ### Added new Partitioner tool that can be leveraged to partition very
> large data sets.
> ### Fixed a quantiles bug in the previous
> version's getPartitionBoundaries(...).
> ### Some minor changes in the APIs
>
> Hello Apache DataSketches PMC and Community,
>
> 1. This is a call for vote to release Apache DataSketches-java candidate
> version:  5.0.0-RC1
>
>     NOTE 1: This is the core Java component of the DataSketches library
> that includes all the sketch algorithms in production-ready packages. These
> sketches can be called directly from this component or used in conjunction
> with the adaptor components such as Hadoop Pig, Hadoop Hive, or the
> aggregator adaptors built into Apache Druid.
>
> 2. Source repository:
>     - https://github.com/apache/datasketches-java
> <https://urldefense.com/v3/__https://github.com/apache/datasketches-java__;!!Op6eflyXZCqGR5I!ALclkZVxbSooGHNps4D9XKss3gjD4rldOcmct1Cv0vi1PFxRBI78lz7X_EKtJOrf7-_pxwvChvkqIUwIM45QxM4$>
>
>     Git Tag for this release:
>     - https://github.com/apache/datasketches-java/releases/tag/5.0.0-RC1
> <https://urldefense.com/v3/__https://github.com/apache/datasketches-java/releases/tag/5.0.0-RC1__;!!Op6eflyXZCqGR5I!ALclkZVxbSooGHNps4D9XKss3gjD4rldOcmct1Cv0vi1PFxRBI78lz7X_EKtJOrf7-_pxwvChvkqIUwIfMxt878$>
> on branch 5.0.X
>
>     Git HashId for this release starts with: 9acc425
>
> 3. The Release Candidate / Zip Repository:
>     - https://dist.apache.org/repos/dist/dev/datasketches/java/5.0.0-RC1
> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/java/5.0.0-RC1__;!!Op6eflyXZCqGR5I!ALclkZVxbSooGHNps4D9XKss3gjD4rldOcmct1Cv0vi1PFxRBI78lz7X_EKtJOrf7-_pxwvChvkqIUwIz9QrqUE$>
>
>     The public signing key can be found in the KEYS file:
>     - https://dist.apache.org/repos/dist/dev/datasketches/KEYS
> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!ALclkZVxbSooGHNps4D9XKss3gjD4rldOcmct1Cv0vi1PFxRBI78lz7X_EKtJOrf7-_pxwvChvkqIUwIXCC1bAc$>
>
>     The artifacts have been signed with --keyid-format SHORT : 8CD4A902
>
> 4. Repository: Maven Central [Nexus](http://repository.apache.org
> <https://urldefense.com/v3/__http://repository.apache.org__;!!Op6eflyXZCqGR5I!ALclkZVxbSooGHNps4D9XKss3gjD4rldOcmct1Cv0vi1PFxRBI78lz7X_EKtJOrf7-_pxwvChvkqIUwIdeD0jZQ$>)
> (Jar Artifacts):
>     -
> https://repository.apache.org/content/groups/staging/org/apache/datasketches/datasketches-java/5.0.0/
> <https://urldefense.com/v3/__https://repository.apache.org/content/groups/staging/org/apache/datasketches/datasketches-java/5.0.0/__;!!Op6eflyXZCqGR5I!ALclkZVxbSooGHNps4D9XKss3gjD4rldOcmct1Cv0vi1PFxRBI78lz7X_EKtJOrf7-_pxwvChvkqIUwI9iRrdoU$>
>
> 5. Build & Test Guide:
>     - https://github.com/apache/datasketches-java/blob/5.0.0-RC1/README.md
> <https://urldefense.com/v3/__https://github.com/apache/datasketches-java/blob/5.0.0-RC1/README.md__;!!Op6eflyXZCqGR5I!ALclkZVxbSooGHNps4D9XKss3gjD4rldOcmct1Cv0vi1PFxRBI78lz7X_EKtJOrf7-_pxwvChvkqIUwIZrs72-E$>
>
> 6. The vote will be performed as follows:
>    - This letter will be published on dev@ and remain open for at least
> 72 hours (excluding weekends and holidays), AND until at least 3 (+1) PMC
> votes or a majority of (+1) PMC votes are acquired. Anyone in the community
> can vote.  This vote will close no earlier than Thursday, Dec 7 11:30 PM
> PST.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> Lee Rhodes
> leerho@apache.org
>

Re: [E] [VOTE] Release Apache DataSketches-java 5.0.0-RC1

Posted by Lee Rhodes <le...@gmail.com>.
[VOTE-RESULT] This Vote is now closed.  Three +1(binding) votes and no
other votes cast.
I will finalize the release.

On Wed, Dec 6, 2023 at 11:54 AM Alexander Saydakov
<sa...@yahooinc.com.invalid> wrote:

> +1
> - verified GPG signature
> - checked shasum
> - LICENSE and NOTICE look good
> - "mvn test" passes
> Observation: SHA checksum (and MD5, but who cares?) was not downloaded
> from Maven central to the release candidate folder
>
>
> On Tue, Dec 5, 2023 at 12:16 PM Jon Malkin <jo...@gmail.com> wrote:
>
>> Update: I think the serialization_test_data directory was created by a
>> test job other than cross-language compatibility. But it's not in the
>> package as released. And I guess we do still need those older images.
>> Please ignore my additional questions/comments :)
>>
>>   jon
>>
>> On Tue, Dec 5, 2023 at 11:15 AM Jon Malkin <jo...@gmail.com> wrote:
>>
>>> +1 (binding)
>>>
>>> I checked:
>>> * Signature/checksum on main files as well as maven convenience packages
>>> * mvn test (java 11)
>>> * mvn test -P strict (java 8)
>>> * NOTICE and LICENSE present
>>>
>>> Additional observations/questions:
>>> 1. Now that we have explicit cross-language compatibility tests, do we
>>> still need the sketch images in src/test/resources? (Maybe, hence asking)
>>> 2. Not a blocker for this release but in the future we should not
>>> include the empty serialization_test_data directory tree in our releases
>>>
>>>   jon
>>>
>>> On Tue, Dec 5, 2023 at 2:33 AM Charlie Dickens
>>> <ch...@yahooinc.com.invalid> wrote:
>>>
>>>> +1
>>>> Downloaded and install using java version "1.8.0_391" on mac os ventura
>>>> 13.6
>>>> Ran mvn clean test and all tests ran with 0 failures.
>>>>
>>>> On Tue, 5 Dec 2023 at 07:19, Lee Rhodes <le...@gmail.com> wrote:
>>>>
>>>>> ### clean-up and consolidation of quantiles APIs
>>>>> ### Added new Partitioner tool that can be leveraged to partition very
>>>>> large data sets.
>>>>> ### Fixed a quantiles bug in the previous
>>>>> version's getPartitionBoundaries(...).
>>>>> ### Some minor changes in the APIs
>>>>>
>>>>> Hello Apache DataSketches PMC and Community,
>>>>>
>>>>> 1. This is a call for vote to release Apache DataSketches-java
>>>>> candidate version:  5.0.0-RC1
>>>>>
>>>>>     NOTE 1: This is the core Java component of the DataSketches
>>>>> library that includes all the sketch algorithms in production-ready
>>>>> packages. These sketches can be called directly from this component or used
>>>>> in conjunction with the adaptor components such as Hadoop Pig, Hadoop Hive,
>>>>> or the aggregator adaptors built into Apache Druid.
>>>>>
>>>>> 2. Source repository:
>>>>>     - https://github.com/apache/datasketches-java
>>>>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-java__;!!Op6eflyXZCqGR5I!ALclkZVxbSooGHNps4D9XKss3gjD4rldOcmct1Cv0vi1PFxRBI78lz7X_EKtJOrf7-_pxwvChvkqIUwIM45QxM4$>
>>>>>
>>>>>     Git Tag for this release:
>>>>>     -
>>>>> https://github.com/apache/datasketches-java/releases/tag/5.0.0-RC1
>>>>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-java/releases/tag/5.0.0-RC1__;!!Op6eflyXZCqGR5I!ALclkZVxbSooGHNps4D9XKss3gjD4rldOcmct1Cv0vi1PFxRBI78lz7X_EKtJOrf7-_pxwvChvkqIUwIfMxt878$>
>>>>> on branch 5.0.X
>>>>>
>>>>>     Git HashId for this release starts with: 9acc425
>>>>>
>>>>> 3. The Release Candidate / Zip Repository:
>>>>>     -
>>>>> https://dist.apache.org/repos/dist/dev/datasketches/java/5.0.0-RC1
>>>>> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/java/5.0.0-RC1__;!!Op6eflyXZCqGR5I!ALclkZVxbSooGHNps4D9XKss3gjD4rldOcmct1Cv0vi1PFxRBI78lz7X_EKtJOrf7-_pxwvChvkqIUwIz9QrqUE$>
>>>>>
>>>>>     The public signing key can be found in the KEYS file:
>>>>>     - https://dist.apache.org/repos/dist/dev/datasketches/KEYS
>>>>> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!ALclkZVxbSooGHNps4D9XKss3gjD4rldOcmct1Cv0vi1PFxRBI78lz7X_EKtJOrf7-_pxwvChvkqIUwIXCC1bAc$>
>>>>>
>>>>>     The artifacts have been signed with --keyid-format SHORT : 8CD4A902
>>>>>
>>>>> 4. Repository: Maven Central [Nexus](http://repository.apache.org
>>>>> <https://urldefense.com/v3/__http://repository.apache.org__;!!Op6eflyXZCqGR5I!ALclkZVxbSooGHNps4D9XKss3gjD4rldOcmct1Cv0vi1PFxRBI78lz7X_EKtJOrf7-_pxwvChvkqIUwIdeD0jZQ$>)
>>>>> (Jar Artifacts):
>>>>>     -
>>>>> https://repository.apache.org/content/groups/staging/org/apache/datasketches/datasketches-java/5.0.0/
>>>>> <https://urldefense.com/v3/__https://repository.apache.org/content/groups/staging/org/apache/datasketches/datasketches-java/5.0.0/__;!!Op6eflyXZCqGR5I!ALclkZVxbSooGHNps4D9XKss3gjD4rldOcmct1Cv0vi1PFxRBI78lz7X_EKtJOrf7-_pxwvChvkqIUwI9iRrdoU$>
>>>>>
>>>>> 5. Build & Test Guide:
>>>>>     -
>>>>> https://github.com/apache/datasketches-java/blob/5.0.0-RC1/README.md
>>>>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-java/blob/5.0.0-RC1/README.md__;!!Op6eflyXZCqGR5I!ALclkZVxbSooGHNps4D9XKss3gjD4rldOcmct1Cv0vi1PFxRBI78lz7X_EKtJOrf7-_pxwvChvkqIUwIZrs72-E$>
>>>>>
>>>>> 6. The vote will be performed as follows:
>>>>>    - This letter will be published on dev@ and remain open for at
>>>>> least 72 hours (excluding weekends and holidays), AND until at least 3 (+1)
>>>>> PMC votes or a majority of (+1) PMC votes are acquired. Anyone in the
>>>>> community can vote.  This vote will close no earlier than Thursday, Dec 7
>>>>> 11:30 PM PST.
>>>>>
>>>>> Please vote accordingly:
>>>>>
>>>>> [ ] +1 approve
>>>>> [ ] +0 no opinion
>>>>> [ ] -1 disapprove with the reason
>>>>>
>>>>> Thanks,
>>>>> Lee Rhodes
>>>>> leerho@apache.org
>>>>>
>>>>

Re: [E] [VOTE] Release Apache DataSketches-java 5.0.0-RC1

Posted by Alexander Saydakov <sa...@yahooinc.com.INVALID>.
+1
- verified GPG signature
- checked shasum
- LICENSE and NOTICE look good
- "mvn test" passes
Observation: SHA checksum (and MD5, but who cares?) was not downloaded from
Maven central to the release candidate folder


On Tue, Dec 5, 2023 at 12:16 PM Jon Malkin <jo...@gmail.com> wrote:

> Update: I think the serialization_test_data directory was created by a
> test job other than cross-language compatibility. But it's not in the
> package as released. And I guess we do still need those older images.
> Please ignore my additional questions/comments :)
>
>   jon
>
> On Tue, Dec 5, 2023 at 11:15 AM Jon Malkin <jo...@gmail.com> wrote:
>
>> +1 (binding)
>>
>> I checked:
>> * Signature/checksum on main files as well as maven convenience packages
>> * mvn test (java 11)
>> * mvn test -P strict (java 8)
>> * NOTICE and LICENSE present
>>
>> Additional observations/questions:
>> 1. Now that we have explicit cross-language compatibility tests, do we
>> still need the sketch images in src/test/resources? (Maybe, hence asking)
>> 2. Not a blocker for this release but in the future we should not include
>> the empty serialization_test_data directory tree in our releases
>>
>>   jon
>>
>> On Tue, Dec 5, 2023 at 2:33 AM Charlie Dickens
>> <ch...@yahooinc.com.invalid> wrote:
>>
>>> +1
>>> Downloaded and install using java version "1.8.0_391" on mac os ventura
>>> 13.6
>>> Ran mvn clean test and all tests ran with 0 failures.
>>>
>>> On Tue, 5 Dec 2023 at 07:19, Lee Rhodes <le...@gmail.com> wrote:
>>>
>>>> ### clean-up and consolidation of quantiles APIs
>>>> ### Added new Partitioner tool that can be leveraged to partition very
>>>> large data sets.
>>>> ### Fixed a quantiles bug in the previous
>>>> version's getPartitionBoundaries(...).
>>>> ### Some minor changes in the APIs
>>>>
>>>> Hello Apache DataSketches PMC and Community,
>>>>
>>>> 1. This is a call for vote to release Apache DataSketches-java
>>>> candidate version:  5.0.0-RC1
>>>>
>>>>     NOTE 1: This is the core Java component of the DataSketches library
>>>> that includes all the sketch algorithms in production-ready packages. These
>>>> sketches can be called directly from this component or used in conjunction
>>>> with the adaptor components such as Hadoop Pig, Hadoop Hive, or the
>>>> aggregator adaptors built into Apache Druid.
>>>>
>>>> 2. Source repository:
>>>>     - https://github.com/apache/datasketches-java
>>>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-java__;!!Op6eflyXZCqGR5I!ALclkZVxbSooGHNps4D9XKss3gjD4rldOcmct1Cv0vi1PFxRBI78lz7X_EKtJOrf7-_pxwvChvkqIUwIM45QxM4$>
>>>>
>>>>     Git Tag for this release:
>>>>     -
>>>> https://github.com/apache/datasketches-java/releases/tag/5.0.0-RC1
>>>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-java/releases/tag/5.0.0-RC1__;!!Op6eflyXZCqGR5I!ALclkZVxbSooGHNps4D9XKss3gjD4rldOcmct1Cv0vi1PFxRBI78lz7X_EKtJOrf7-_pxwvChvkqIUwIfMxt878$>
>>>> on branch 5.0.X
>>>>
>>>>     Git HashId for this release starts with: 9acc425
>>>>
>>>> 3. The Release Candidate / Zip Repository:
>>>>     -
>>>> https://dist.apache.org/repos/dist/dev/datasketches/java/5.0.0-RC1
>>>> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/java/5.0.0-RC1__;!!Op6eflyXZCqGR5I!ALclkZVxbSooGHNps4D9XKss3gjD4rldOcmct1Cv0vi1PFxRBI78lz7X_EKtJOrf7-_pxwvChvkqIUwIz9QrqUE$>
>>>>
>>>>     The public signing key can be found in the KEYS file:
>>>>     - https://dist.apache.org/repos/dist/dev/datasketches/KEYS
>>>> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!ALclkZVxbSooGHNps4D9XKss3gjD4rldOcmct1Cv0vi1PFxRBI78lz7X_EKtJOrf7-_pxwvChvkqIUwIXCC1bAc$>
>>>>
>>>>     The artifacts have been signed with --keyid-format SHORT : 8CD4A902
>>>>
>>>> 4. Repository: Maven Central [Nexus](http://repository.apache.org
>>>> <https://urldefense.com/v3/__http://repository.apache.org__;!!Op6eflyXZCqGR5I!ALclkZVxbSooGHNps4D9XKss3gjD4rldOcmct1Cv0vi1PFxRBI78lz7X_EKtJOrf7-_pxwvChvkqIUwIdeD0jZQ$>)
>>>> (Jar Artifacts):
>>>>     -
>>>> https://repository.apache.org/content/groups/staging/org/apache/datasketches/datasketches-java/5.0.0/
>>>> <https://urldefense.com/v3/__https://repository.apache.org/content/groups/staging/org/apache/datasketches/datasketches-java/5.0.0/__;!!Op6eflyXZCqGR5I!ALclkZVxbSooGHNps4D9XKss3gjD4rldOcmct1Cv0vi1PFxRBI78lz7X_EKtJOrf7-_pxwvChvkqIUwI9iRrdoU$>
>>>>
>>>> 5. Build & Test Guide:
>>>>     -
>>>> https://github.com/apache/datasketches-java/blob/5.0.0-RC1/README.md
>>>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-java/blob/5.0.0-RC1/README.md__;!!Op6eflyXZCqGR5I!ALclkZVxbSooGHNps4D9XKss3gjD4rldOcmct1Cv0vi1PFxRBI78lz7X_EKtJOrf7-_pxwvChvkqIUwIZrs72-E$>
>>>>
>>>> 6. The vote will be performed as follows:
>>>>    - This letter will be published on dev@ and remain open for at
>>>> least 72 hours (excluding weekends and holidays), AND until at least 3 (+1)
>>>> PMC votes or a majority of (+1) PMC votes are acquired. Anyone in the
>>>> community can vote.  This vote will close no earlier than Thursday, Dec 7
>>>> 11:30 PM PST.
>>>>
>>>> Please vote accordingly:
>>>>
>>>> [ ] +1 approve
>>>> [ ] +0 no opinion
>>>> [ ] -1 disapprove with the reason
>>>>
>>>> Thanks,
>>>> Lee Rhodes
>>>> leerho@apache.org
>>>>
>>>

Re: [E] [VOTE] Release Apache DataSketches-java 5.0.0-RC1

Posted by Jon Malkin <jo...@gmail.com>.
Update: I think the serialization_test_data directory was created by a test
job other than cross-language compatibility. But it's not in the package as
released. And I guess we do still need those older images. Please ignore my
additional questions/comments :)

  jon

On Tue, Dec 5, 2023 at 11:15 AM Jon Malkin <jo...@gmail.com> wrote:

> +1 (binding)
>
> I checked:
> * Signature/checksum on main files as well as maven convenience packages
> * mvn test (java 11)
> * mvn test -P strict (java 8)
> * NOTICE and LICENSE present
>
> Additional observations/questions:
> 1. Now that we have explicit cross-language compatibility tests, do we
> still need the sketch images in src/test/resources? (Maybe, hence asking)
> 2. Not a blocker for this release but in the future we should not include
> the empty serialization_test_data directory tree in our releases
>
>   jon
>
> On Tue, Dec 5, 2023 at 2:33 AM Charlie Dickens
> <ch...@yahooinc.com.invalid> wrote:
>
>> +1
>> Downloaded and install using java version "1.8.0_391" on mac os ventura
>> 13.6
>> Ran mvn clean test and all tests ran with 0 failures.
>>
>> On Tue, 5 Dec 2023 at 07:19, Lee Rhodes <le...@gmail.com> wrote:
>>
>>> ### clean-up and consolidation of quantiles APIs
>>> ### Added new Partitioner tool that can be leveraged to partition very
>>> large data sets.
>>> ### Fixed a quantiles bug in the previous
>>> version's getPartitionBoundaries(...).
>>> ### Some minor changes in the APIs
>>>
>>> Hello Apache DataSketches PMC and Community,
>>>
>>> 1. This is a call for vote to release Apache DataSketches-java candidate
>>> version:  5.0.0-RC1
>>>
>>>     NOTE 1: This is the core Java component of the DataSketches library
>>> that includes all the sketch algorithms in production-ready packages. These
>>> sketches can be called directly from this component or used in conjunction
>>> with the adaptor components such as Hadoop Pig, Hadoop Hive, or the
>>> aggregator adaptors built into Apache Druid.
>>>
>>> 2. Source repository:
>>>     - https://github.com/apache/datasketches-java
>>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-java__;!!Op6eflyXZCqGR5I!ALclkZVxbSooGHNps4D9XKss3gjD4rldOcmct1Cv0vi1PFxRBI78lz7X_EKtJOrf7-_pxwvChvkqIUwIM45QxM4$>
>>>
>>>     Git Tag for this release:
>>>     - https://github.com/apache/datasketches-java/releases/tag/5.0.0-RC1
>>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-java/releases/tag/5.0.0-RC1__;!!Op6eflyXZCqGR5I!ALclkZVxbSooGHNps4D9XKss3gjD4rldOcmct1Cv0vi1PFxRBI78lz7X_EKtJOrf7-_pxwvChvkqIUwIfMxt878$>
>>> on branch 5.0.X
>>>
>>>     Git HashId for this release starts with: 9acc425
>>>
>>> 3. The Release Candidate / Zip Repository:
>>>     - https://dist.apache.org/repos/dist/dev/datasketches/java/5.0.0-RC1
>>> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/java/5.0.0-RC1__;!!Op6eflyXZCqGR5I!ALclkZVxbSooGHNps4D9XKss3gjD4rldOcmct1Cv0vi1PFxRBI78lz7X_EKtJOrf7-_pxwvChvkqIUwIz9QrqUE$>
>>>
>>>     The public signing key can be found in the KEYS file:
>>>     - https://dist.apache.org/repos/dist/dev/datasketches/KEYS
>>> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!ALclkZVxbSooGHNps4D9XKss3gjD4rldOcmct1Cv0vi1PFxRBI78lz7X_EKtJOrf7-_pxwvChvkqIUwIXCC1bAc$>
>>>
>>>     The artifacts have been signed with --keyid-format SHORT : 8CD4A902
>>>
>>> 4. Repository: Maven Central [Nexus](http://repository.apache.org
>>> <https://urldefense.com/v3/__http://repository.apache.org__;!!Op6eflyXZCqGR5I!ALclkZVxbSooGHNps4D9XKss3gjD4rldOcmct1Cv0vi1PFxRBI78lz7X_EKtJOrf7-_pxwvChvkqIUwIdeD0jZQ$>)
>>> (Jar Artifacts):
>>>     -
>>> https://repository.apache.org/content/groups/staging/org/apache/datasketches/datasketches-java/5.0.0/
>>> <https://urldefense.com/v3/__https://repository.apache.org/content/groups/staging/org/apache/datasketches/datasketches-java/5.0.0/__;!!Op6eflyXZCqGR5I!ALclkZVxbSooGHNps4D9XKss3gjD4rldOcmct1Cv0vi1PFxRBI78lz7X_EKtJOrf7-_pxwvChvkqIUwI9iRrdoU$>
>>>
>>> 5. Build & Test Guide:
>>>     -
>>> https://github.com/apache/datasketches-java/blob/5.0.0-RC1/README.md
>>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-java/blob/5.0.0-RC1/README.md__;!!Op6eflyXZCqGR5I!ALclkZVxbSooGHNps4D9XKss3gjD4rldOcmct1Cv0vi1PFxRBI78lz7X_EKtJOrf7-_pxwvChvkqIUwIZrs72-E$>
>>>
>>> 6. The vote will be performed as follows:
>>>    - This letter will be published on dev@ and remain open for at least
>>> 72 hours (excluding weekends and holidays), AND until at least 3 (+1) PMC
>>> votes or a majority of (+1) PMC votes are acquired. Anyone in the community
>>> can vote.  This vote will close no earlier than Thursday, Dec 7 11:30 PM
>>> PST.
>>>
>>> Please vote accordingly:
>>>
>>> [ ] +1 approve
>>> [ ] +0 no opinion
>>> [ ] -1 disapprove with the reason
>>>
>>> Thanks,
>>> Lee Rhodes
>>> leerho@apache.org
>>>
>>

Re: [E] [VOTE] Release Apache DataSketches-java 5.0.0-RC1

Posted by Jon Malkin <jo...@gmail.com>.
+1 (binding)

I checked:
* Signature/checksum on main files as well as maven convenience packages
* mvn test (java 11)
* mvn test -P strict (java 8)
* NOTICE and LICENSE present

Additional observations/questions:
1. Now that we have explicit cross-language compatibility tests, do we
still need the sketch images in src/test/resources? (Maybe, hence asking)
2. Not a blocker for this release but in the future we should not include
the empty serialization_test_data directory tree in our releases

  jon

On Tue, Dec 5, 2023 at 2:33 AM Charlie Dickens
<ch...@yahooinc.com.invalid> wrote:

> +1
> Downloaded and install using java version "1.8.0_391" on mac os ventura
> 13.6
> Ran mvn clean test and all tests ran with 0 failures.
>
> On Tue, 5 Dec 2023 at 07:19, Lee Rhodes <le...@gmail.com> wrote:
>
>> ### clean-up and consolidation of quantiles APIs
>> ### Added new Partitioner tool that can be leveraged to partition very
>> large data sets.
>> ### Fixed a quantiles bug in the previous
>> version's getPartitionBoundaries(...).
>> ### Some minor changes in the APIs
>>
>> Hello Apache DataSketches PMC and Community,
>>
>> 1. This is a call for vote to release Apache DataSketches-java candidate
>> version:  5.0.0-RC1
>>
>>     NOTE 1: This is the core Java component of the DataSketches library
>> that includes all the sketch algorithms in production-ready packages. These
>> sketches can be called directly from this component or used in conjunction
>> with the adaptor components such as Hadoop Pig, Hadoop Hive, or the
>> aggregator adaptors built into Apache Druid.
>>
>> 2. Source repository:
>>     - https://github.com/apache/datasketches-java
>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-java__;!!Op6eflyXZCqGR5I!ALclkZVxbSooGHNps4D9XKss3gjD4rldOcmct1Cv0vi1PFxRBI78lz7X_EKtJOrf7-_pxwvChvkqIUwIM45QxM4$>
>>
>>     Git Tag for this release:
>>     - https://github.com/apache/datasketches-java/releases/tag/5.0.0-RC1
>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-java/releases/tag/5.0.0-RC1__;!!Op6eflyXZCqGR5I!ALclkZVxbSooGHNps4D9XKss3gjD4rldOcmct1Cv0vi1PFxRBI78lz7X_EKtJOrf7-_pxwvChvkqIUwIfMxt878$>
>> on branch 5.0.X
>>
>>     Git HashId for this release starts with: 9acc425
>>
>> 3. The Release Candidate / Zip Repository:
>>     - https://dist.apache.org/repos/dist/dev/datasketches/java/5.0.0-RC1
>> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/java/5.0.0-RC1__;!!Op6eflyXZCqGR5I!ALclkZVxbSooGHNps4D9XKss3gjD4rldOcmct1Cv0vi1PFxRBI78lz7X_EKtJOrf7-_pxwvChvkqIUwIz9QrqUE$>
>>
>>     The public signing key can be found in the KEYS file:
>>     - https://dist.apache.org/repos/dist/dev/datasketches/KEYS
>> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!ALclkZVxbSooGHNps4D9XKss3gjD4rldOcmct1Cv0vi1PFxRBI78lz7X_EKtJOrf7-_pxwvChvkqIUwIXCC1bAc$>
>>
>>     The artifacts have been signed with --keyid-format SHORT : 8CD4A902
>>
>> 4. Repository: Maven Central [Nexus](http://repository.apache.org
>> <https://urldefense.com/v3/__http://repository.apache.org__;!!Op6eflyXZCqGR5I!ALclkZVxbSooGHNps4D9XKss3gjD4rldOcmct1Cv0vi1PFxRBI78lz7X_EKtJOrf7-_pxwvChvkqIUwIdeD0jZQ$>)
>> (Jar Artifacts):
>>     -
>> https://repository.apache.org/content/groups/staging/org/apache/datasketches/datasketches-java/5.0.0/
>> <https://urldefense.com/v3/__https://repository.apache.org/content/groups/staging/org/apache/datasketches/datasketches-java/5.0.0/__;!!Op6eflyXZCqGR5I!ALclkZVxbSooGHNps4D9XKss3gjD4rldOcmct1Cv0vi1PFxRBI78lz7X_EKtJOrf7-_pxwvChvkqIUwI9iRrdoU$>
>>
>> 5. Build & Test Guide:
>>     -
>> https://github.com/apache/datasketches-java/blob/5.0.0-RC1/README.md
>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-java/blob/5.0.0-RC1/README.md__;!!Op6eflyXZCqGR5I!ALclkZVxbSooGHNps4D9XKss3gjD4rldOcmct1Cv0vi1PFxRBI78lz7X_EKtJOrf7-_pxwvChvkqIUwIZrs72-E$>
>>
>> 6. The vote will be performed as follows:
>>    - This letter will be published on dev@ and remain open for at least
>> 72 hours (excluding weekends and holidays), AND until at least 3 (+1) PMC
>> votes or a majority of (+1) PMC votes are acquired. Anyone in the community
>> can vote.  This vote will close no earlier than Thursday, Dec 7 11:30 PM
>> PST.
>>
>> Please vote accordingly:
>>
>> [ ] +1 approve
>> [ ] +0 no opinion
>> [ ] -1 disapprove with the reason
>>
>> Thanks,
>> Lee Rhodes
>> leerho@apache.org
>>
>