You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/06/26 18:54:42 UTC

[GitHub] [cordova-plugin-file] Lindsay-Needs-Sleep commented on issue #329: cdvfile:// Channel not fired: onFileSystemPathsReady on Android OS 4.4

Lindsay-Needs-Sleep commented on issue #329: cdvfile://  Channel not fired: onFileSystemPathsReady on Android OS 4.4
URL: https://github.com/apache/cordova-plugin-file/issues/329#issuecomment-506001990
 
 
   Yep, just about to commit to my fork.
   
       @Override
       public Boolean shouldAllowBridgeAccess(String url) {
           if (url.equals("")) {
               url = this.webView.getUrl();
               if (url.matches("^cdvfile://.*")) {
                   return true;
               }
           }
           return super.shouldAllowBridgeAccess(url);
       }
   
   What do you think? 
   
   I don't think it should break anything security-wise... but 2nd opinions are good!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org