[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #10836: feat: Stop pending queries when user close dashboard

[GitBox <gi...@apache.org>]

graceguo-supercat commented on a change in pull request #10836:
URL: https://github.com/apache/incubator-superset/pull/10836#discussion_r488969112



##########
File path: superset/db_engine_specs/base.py
##########
@@ -206,6 +206,10 @@ def is_db_column_type_match(
     def get_allow_cost_estimate(cls, version: Optional[str] = None) -> bool:
         return False
 
+    @classmethod

Review comment:
       thanks for the suggestion. fixed by remove `get_allow_stop_pending_queries` check, and add an empty `stop_queries`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org