You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Sid Wagle <sw...@hortonworks.com> on 2016/01/05 02:02:32 UTC

Review Request 41908: AMS in distributed mode fails to start with blueprint deploy

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41908/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Aravindan Vijayan, and Sumit Mohanty.


Bugs: AMBARI-14542
    https://issues.apache.org/jira/browse/AMBARI-14542


Repository: ambari


Description
-------

ZK client port is set to 61181 by default, if blueprint config does not override this property and AMS fails to start.

Ambari UI depends on stack advisor to the right thing which does not happen with blueprint deploys.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog221.java c4216bd 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-site.xml c1263ee 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 16c885b 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 7e2871b 
  ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog221Test.java 23d9a70 
  ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py e860ab7 

Diff: https://reviews.apache.org/r/41908/diff/


Testing
-------

Python test pass.
Upgrade test pass.
Manual test in progress.


Thanks,

Sid Wagle


Re: Review Request 41908: AMS in distributed mode fails to start with blueprint deploy

Posted by Aravindan Vijayan <av...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41908/#review112742
-----------------------------------------------------------

Ship it!


Ship It!

- Aravindan Vijayan


On Jan. 5, 2016, 1:02 a.m., Sid Wagle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41908/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 1:02 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Aravindan Vijayan, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-14542
>     https://issues.apache.org/jira/browse/AMBARI-14542
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> ZK client port is set to 61181 by default, if blueprint config does not override this property and AMS fails to start.
> 
> Ambari UI depends on stack advisor to the right thing which does not happen with blueprint deploys.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog221.java c4216bd 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-site.xml c1263ee 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 16c885b 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 7e2871b 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog221Test.java 23d9a70 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py e860ab7 
> 
> Diff: https://reviews.apache.org/r/41908/diff/
> 
> 
> Testing
> -------
> 
> Python test pass.
> Upgrade test pass.
> Manual test in progress.
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>


Re: Review Request 41908: AMS in distributed mode fails to start with blueprint deploy

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41908/#review112734
-----------------------------------------------------------

Ship it!


Ship It!

- Sumit Mohanty


On Jan. 5, 2016, 1:02 a.m., Sid Wagle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41908/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 1:02 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Aravindan Vijayan, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-14542
>     https://issues.apache.org/jira/browse/AMBARI-14542
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> ZK client port is set to 61181 by default, if blueprint config does not override this property and AMS fails to start.
> 
> Ambari UI depends on stack advisor to the right thing which does not happen with blueprint deploys.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog221.java c4216bd 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-site.xml c1263ee 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 16c885b 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 7e2871b 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog221Test.java 23d9a70 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py e860ab7 
> 
> Diff: https://reviews.apache.org/r/41908/diff/
> 
> 
> Testing
> -------
> 
> Python test pass.
> Upgrade test pass.
> Manual test in progress.
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>


Re: Review Request 41908: AMS in distributed mode fails to start with blueprint deploy

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41908/#review112733
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog221.java (line 256)
<https://reviews.apache.org/r/41908/#comment173222>

    This means that when Ambari is being upgraded to 2.2.1 and AMS is in distributed mode we should ask users to restart AMS after upgrade. Do we always ask users to restart AMS after upgrade?


- Sumit Mohanty


On Jan. 5, 2016, 1:02 a.m., Sid Wagle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41908/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 1:02 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Aravindan Vijayan, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-14542
>     https://issues.apache.org/jira/browse/AMBARI-14542
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> ZK client port is set to 61181 by default, if blueprint config does not override this property and AMS fails to start.
> 
> Ambari UI depends on stack advisor to the right thing which does not happen with blueprint deploys.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog221.java c4216bd 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-site.xml c1263ee 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 16c885b 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 7e2871b 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog221Test.java 23d9a70 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py e860ab7 
> 
> Diff: https://reviews.apache.org/r/41908/diff/
> 
> 
> Testing
> -------
> 
> Python test pass.
> Upgrade test pass.
> Manual test in progress.
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>