You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Alejandro Fernandez <af...@hortonworks.com> on 2016/04/07 03:46:05 UTC
Review Request 45857: RU/EU PreCheck to ensure
dfs.client.retry.policy.enable is set to false
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45857/
-----------------------------------------------------------
Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.
Bugs: AMBARI-15751
https://issues.apache.org/jira/browse/AMBARI-15751
Repository: ambari
Description
-------
Ambari used to have a PreCheck to ensure that certain client retries were enabled.
This check should be required in all RU/EUs
hdfs-site: "dfs.client.retry.policy.enabled" must be false
hive-site: "hive.metastore.failure.retries"must be greater than 0
oozie-env: "-Doozie.connection.retry.count" must be present in the "content" param
Right now, this check is disabled and there hdfs-site property is not checked.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java 79be901
ambari-server/src/main/java/org/apache/ambari/server/checks/ClientRetryPropertyCheck.java 257d575
ambari-server/src/test/java/org/apache/ambari/server/checks/ClientRetryPropertyCheckTest.java 7b8239c
Diff: https://reviews.apache.org/r/45857/diff/
Testing
-------
Ran unit test ClientRetryPropertyCheckTest
Thanks,
Alejandro Fernandez
Re: Review Request 45857: RU/EU PreCheck to ensure
dfs.client.retry.policy.enable is set to false
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45857/#review127622
-----------------------------------------------------------
Ship it!
Ship It!
- Jayush Luniya
On April 7, 2016, 1:46 a.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45857/
> -----------------------------------------------------------
>
> (Updated April 7, 2016, 1:46 a.m.)
>
>
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.
>
>
> Bugs: AMBARI-15751
> https://issues.apache.org/jira/browse/AMBARI-15751
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ambari used to have a PreCheck to ensure that certain client retries were enabled.
> This check should be required in all RU/EUs
>
> hdfs-site: "dfs.client.retry.policy.enabled" must be false
> hive-site: "hive.metastore.failure.retries"must be greater than 0
> oozie-env: "-Doozie.connection.retry.count" must be present in the "content" param
>
> Right now, this check is disabled and there hdfs-site property is not checked.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java 79be901
> ambari-server/src/main/java/org/apache/ambari/server/checks/ClientRetryPropertyCheck.java 257d575
> ambari-server/src/test/java/org/apache/ambari/server/checks/ClientRetryPropertyCheckTest.java 7b8239c
>
> Diff: https://reviews.apache.org/r/45857/diff/
>
>
> Testing
> -------
>
> Ran unit test ClientRetryPropertyCheckTest
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 45857: RU/EU PreCheck to ensure
dfs.client.retry.policy.enable is set to false
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45857/#review127777
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On April 7, 2016, 5:47 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45857/
> -----------------------------------------------------------
>
> (Updated April 7, 2016, 5:47 p.m.)
>
>
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.
>
>
> Bugs: AMBARI-15751
> https://issues.apache.org/jira/browse/AMBARI-15751
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ambari used to have a PreCheck to ensure that certain client retries were enabled.
> This check should be required in all RU/EUs
>
> hdfs-site: "dfs.client.retry.policy.enabled" must be false
> hive-site: "hive.metastore.failure.retries"must be greater than 0
> oozie-env: "-Doozie.connection.retry.count" must be present in the "content" param
>
> Right now, this check is disabled and there hdfs-site property is not checked.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java 79be901
> ambari-server/src/main/java/org/apache/ambari/server/checks/ClientRetryPropertyCheck.java 257d575
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java 65dad79
> ambari-server/src/test/java/org/apache/ambari/server/checks/ClientRetryPropertyCheckTest.java 7b8239c
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java a583d39
>
> Diff: https://reviews.apache.org/r/45857/diff/
>
>
> Testing
> -------
>
> Ran unit test ClientRetryPropertyCheckTest
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 45857: RU/EU PreCheck to ensure
dfs.client.retry.policy.enable is set to false
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45857/
-----------------------------------------------------------
(Updated April 7, 2016, 9:47 p.m.)
Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.
Bugs: AMBARI-15751
https://issues.apache.org/jira/browse/AMBARI-15751
Repository: ambari
Description
-------
Ambari used to have a PreCheck to ensure that certain client retries were enabled.
This check should be required in all RU/EUs
hdfs-site: "dfs.client.retry.policy.enabled" must be false
hive-site: "hive.metastore.failure.retries"must be greater than 0
oozie-env: "-Doozie.connection.retry.count" must be present in the "content" param
Right now, this check is disabled and there hdfs-site property is not checked.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java 79be901
ambari-server/src/main/java/org/apache/ambari/server/checks/ClientRetryPropertyCheck.java 257d575
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java 65dad79
ambari-server/src/test/java/org/apache/ambari/server/checks/ClientRetryPropertyCheckTest.java 7b8239c
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java a583d39
Diff: https://reviews.apache.org/r/45857/diff/
Testing
-------
Ran unit test ClientRetryPropertyCheckTest
Thanks,
Alejandro Fernandez