[GitHub] [submarine] jeff-901 commented on a change in pull request #758: SUBMARINE-1036. Can't import submarine in notebook

[GitBox <gi...@apache.org>]

jeff-901 commented on a change in pull request #758:
URL: https://github.com/apache/submarine/pull/758#discussion_r718088937



##########
File path: dev-support/docker-images/jupyter/Dockerfile
##########
@@ -94,21 +94,20 @@ RUN wget --quiet https://repo.continuum.io/miniconda/Miniconda3-py37_${MINICONDA
     conda clean --all -f -y && \
     rm -rf /home/$NB_USER/.cache/yarn
 
+RUN conda init bash 
 # Install latest sumbarine python sdk and notebook
-RUN git clone https://github.com/apache/submarine && \
-    pip install -e submarine/submarine-sdk/pysubmarine[tf,pytorch] && \
+RUN source ~/.bashrc && conda activate && \
+    git clone https://github.com/apache/submarine && \
+    pip install submarine/submarine-sdk/pysubmarine[tf,pytorch] && \
     conda install nodejs && \
     conda install -c conda-forge jupyterlab jupyterlab-git && \
-    jupyter lab build
+    jupyter lab build 

Review comment:
       Thanks. I will delete it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org