[GitHub] [tvm] kparzysz-quic commented on a diff in pull request #11214: [Hexagon] Add AoT capability to Hexagon launcher

[GitBox <gi...@apache.org>]

kparzysz-quic commented on code in PR #11214:
URL: https://github.com/apache/tvm/pull/11214#discussion_r865381355


##########
apps/hexagon_launcher/launcher_hexagon.cc:
##########
@@ -64,7 +64,22 @@ AEEResult __QAIC_HEADER(launcher_rpc_load)(remote_handle64 handle, const char* m
   }
 
   tvm::runtime::Module module = load_module(module_path);
-  tvm::runtime::Module executor = create_graph_executor(graph_json, module, Model::device());
+  std::string module_type = module->type_key();
+  tvm::runtime::Module executor;
+  if (module_type == "AotExecutorFactory") {
+    executor = create_aot_executor(module, Model::external());
+  } else if (module_type == "library") {
+    // We're not expecting "GraphExecutorFactory" here.

Review Comment:
   We never saved the factory for graph executor---instead we saved the library module and created the executor by hand.  This is just a reflection of how the original code worked.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org