You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2015/12/17 20:45:51 UTC
Review Request 41526: Hive Metastore alert timeout
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41526/
-----------------------------------------------------------
Review request for Ambari, Andrew Onischuk, Dmytro Sen, Jonathan Hurley, and Sumit Mohanty.
Bugs: AMBARI-14424
https://issues.apache.org/jira/browse/AMBARI-14424
Repository: ambari
Description
-------
For Hive metastore and server alerts
1) Change default timeout to 60 seconds
2) Make this a configurable script param, so people can pass this in
Diffs
-----
ambari-common/src/main/python/resource_management/libraries/functions/hive_check.py 55fd6bd
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json 55e3f78
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py c7a9102
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_thrift_port.py a04c2a6
Diff: https://reviews.apache.org/r/41526/diff/
Testing
-------
mvn clean test
Thanks,
Vitalyi Brodetskyi
Re: Review Request 41526: Hive Metastore alert timeout
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41526/#review111545
-----------------------------------------------------------
Ship it!
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog221.java
<https://reviews.apache.org/r/41526/#comment171740>
Got rid of the log statement?
- Jonathan Hurley
On Dec. 21, 2015, 3:52 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41526/
> -----------------------------------------------------------
>
> (Updated Dec. 21, 2015, 3:52 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, Jonathan Hurley, and Sumit Mohanty.
>
>
> Bugs: AMBARI-14424
> https://issues.apache.org/jira/browse/AMBARI-14424
>
>
> Repository: ambari
>
>
> Description
> -------
>
> For Hive metastore and server alerts
> 1) Change default timeout to 60 seconds
> 2) Make this a configurable script param, so people can pass this in
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/hive_check.py 55fd6bd
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 5e22f71
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog221.java PRE-CREATION
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json 55e3f78
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py c7a9102
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_thrift_port.py a04c2a6
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog221Test.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41526/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 41526: Hive Metastore alert timeout
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41526/
-----------------------------------------------------------
(Updated Гру. 21, 2015, 8:52 після полудня)
Review request for Ambari, Andrew Onischuk, Dmytro Sen, Jonathan Hurley, and Sumit Mohanty.
Bugs: AMBARI-14424
https://issues.apache.org/jira/browse/AMBARI-14424
Repository: ambari
Description
-------
For Hive metastore and server alerts
1) Change default timeout to 60 seconds
2) Make this a configurable script param, so people can pass this in
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/libraries/functions/hive_check.py 55fd6bd
ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 5e22f71
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog221.java PRE-CREATION
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json 55e3f78
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py c7a9102
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_thrift_port.py a04c2a6
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog221Test.java PRE-CREATION
Diff: https://reviews.apache.org/r/41526/diff/
Testing
-------
mvn clean test
Thanks,
Vitalyi Brodetskyi
Re: Review Request 41526: Hive Metastore alert timeout
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On Dec. 18, 2015, 12:27 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog221.java, lines 114-141
> > <https://reviews.apache.org/r/41526/diff/3/?file=1170927#file1170927line114>
> >
> > Looks like you're adding the same source to each entity - can you just put this in a loop and loop over the 2 entities?
>
> Vitalyi Brodetskyi wrote:
> Jonathan, i'm not sure i understand your note. I'm updaring sources for two different alerts, hive metastore and hive server process laerts. In the method you mentioned, i'm getting source from every alert definition, then adding(if needed) "timeout" parameter and then set it to entity.
Each if-statement is performing the same work on each entity. You could do this:
```
List alertDefinitions = new ArrayList(hiveMetastoreProcessAlertDefinitionEntity, hiveServerProcessAlertDefinitionEntity);
for( AlertDefinitionEntity definition : alertDefinitions ){
String source = definition.getSource();
definition.setScheduleInterval(3);
definition.setSource(addCheckCommandTimeoutParam(source));
definition.setHash(UUID.randomUUID().toString());
alertDefinitionDAO.merge(definition);
LOG.info("Updated the alert definition {}", definition.getName());
}
```
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41526/#review111206
-----------------------------------------------------------
On Dec. 18, 2015, 11:41 a.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41526/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2015, 11:41 a.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, Jonathan Hurley, and Sumit Mohanty.
>
>
> Bugs: AMBARI-14424
> https://issues.apache.org/jira/browse/AMBARI-14424
>
>
> Repository: ambari
>
>
> Description
> -------
>
> For Hive metastore and server alerts
> 1) Change default timeout to 60 seconds
> 2) Make this a configurable script param, so people can pass this in
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/hive_check.py 55fd6bd
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 5e22f71
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog221.java PRE-CREATION
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json 55e3f78
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py c7a9102
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_thrift_port.py a04c2a6
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog221Test.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41526/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 41526: Hive Metastore alert timeout
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
> On Гру. 18, 2015, 5:27 після полудня, Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog221.java, lines 114-141
> > <https://reviews.apache.org/r/41526/diff/3/?file=1170927#file1170927line114>
> >
> > Looks like you're adding the same source to each entity - can you just put this in a loop and loop over the 2 entities?
Jonathan, i'm not sure i understand your note. I'm updaring sources for two different alerts, hive metastore and hive server process laerts. In the method you mentioned, i'm getting source from every alert definition, then adding(if needed) "timeout" parameter and then set it to entity.
- Vitalyi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41526/#review111206
-----------------------------------------------------------
On Гру. 18, 2015, 4:41 після полудня, Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41526/
> -----------------------------------------------------------
>
> (Updated Гру. 18, 2015, 4:41 після полудня)
>
>
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, Jonathan Hurley, and Sumit Mohanty.
>
>
> Bugs: AMBARI-14424
> https://issues.apache.org/jira/browse/AMBARI-14424
>
>
> Repository: ambari
>
>
> Description
> -------
>
> For Hive metastore and server alerts
> 1) Change default timeout to 60 seconds
> 2) Make this a configurable script param, so people can pass this in
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/hive_check.py 55fd6bd
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 5e22f71
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog221.java PRE-CREATION
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json 55e3f78
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py c7a9102
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_thrift_port.py a04c2a6
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog221Test.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41526/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 41526: Hive Metastore alert timeout
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41526/#review111206
-----------------------------------------------------------
Ship it!
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog221.java (lines 114 - 141)
<https://reviews.apache.org/r/41526/#comment171306>
Looks like you're adding the same source to each entity - can you just put this in a loop and loop over the 2 entities?
- Jonathan Hurley
On Dec. 18, 2015, 11:41 a.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41526/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2015, 11:41 a.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, Jonathan Hurley, and Sumit Mohanty.
>
>
> Bugs: AMBARI-14424
> https://issues.apache.org/jira/browse/AMBARI-14424
>
>
> Repository: ambari
>
>
> Description
> -------
>
> For Hive metastore and server alerts
> 1) Change default timeout to 60 seconds
> 2) Make this a configurable script param, so people can pass this in
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/hive_check.py 55fd6bd
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 5e22f71
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog221.java PRE-CREATION
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json 55e3f78
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py c7a9102
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_thrift_port.py a04c2a6
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog221Test.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41526/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 41526: Hive Metastore alert timeout
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
> On Гру. 18, 2015, 6:05 після полудня, Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog221.java, lines 114-141
> > <https://reviews.apache.org/r/41526/diff/3/?file=1170927#file1170927line114>
> >
> > It's my impression that this type of change for alerts is not uncommon. Can we have a general function to call?
We have some usefull functions in entity as of now, so i think it will be better to add some additional there. Even if we will decide to add some functions in AbstractUpgradeCatalog, i think it should be implemented as a feature in separate jira, with Unit Tests and etc.
- Vitalyi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41526/#review111213
-----------------------------------------------------------
On Гру. 18, 2015, 4:41 після полудня, Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41526/
> -----------------------------------------------------------
>
> (Updated Гру. 18, 2015, 4:41 після полудня)
>
>
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, Jonathan Hurley, and Sumit Mohanty.
>
>
> Bugs: AMBARI-14424
> https://issues.apache.org/jira/browse/AMBARI-14424
>
>
> Repository: ambari
>
>
> Description
> -------
>
> For Hive metastore and server alerts
> 1) Change default timeout to 60 seconds
> 2) Make this a configurable script param, so people can pass this in
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/hive_check.py 55fd6bd
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 5e22f71
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog221.java PRE-CREATION
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json 55e3f78
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py c7a9102
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_thrift_port.py a04c2a6
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog221Test.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41526/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 41526: Hive Metastore alert timeout
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41526/#review111213
-----------------------------------------------------------
Ship it!
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog221.java (lines 114 - 141)
<https://reviews.apache.org/r/41526/#comment171312>
It's my impression that this type of change for alerts is not uncommon. Can we have a general function to call?
- Alejandro Fernandez
On Dec. 18, 2015, 4:41 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41526/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2015, 4:41 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, Jonathan Hurley, and Sumit Mohanty.
>
>
> Bugs: AMBARI-14424
> https://issues.apache.org/jira/browse/AMBARI-14424
>
>
> Repository: ambari
>
>
> Description
> -------
>
> For Hive metastore and server alerts
> 1) Change default timeout to 60 seconds
> 2) Make this a configurable script param, so people can pass this in
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/hive_check.py 55fd6bd
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 5e22f71
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog221.java PRE-CREATION
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json 55e3f78
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py c7a9102
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_thrift_port.py a04c2a6
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog221Test.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41526/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 41526: Hive Metastore alert timeout
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41526/
-----------------------------------------------------------
(Updated Гру. 18, 2015, 4:41 після полудня)
Review request for Ambari, Andrew Onischuk, Dmytro Sen, Jonathan Hurley, and Sumit Mohanty.
Bugs: AMBARI-14424
https://issues.apache.org/jira/browse/AMBARI-14424
Repository: ambari
Description
-------
For Hive metastore and server alerts
1) Change default timeout to 60 seconds
2) Make this a configurable script param, so people can pass this in
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/libraries/functions/hive_check.py 55fd6bd
ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 5e22f71
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog221.java PRE-CREATION
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json 55e3f78
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py c7a9102
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_thrift_port.py a04c2a6
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog221Test.java PRE-CREATION
Diff: https://reviews.apache.org/r/41526/diff/
Testing
-------
mvn clean test
Thanks,
Vitalyi Brodetskyi
Re: Review Request 41526: Hive Metastore alert timeout
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
> On Гру. 18, 2015, 4:28 після полудня, Andrew Onischuk wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog221.java, line 145
> > <https://reviews.apache.org/r/41526/diff/2/?file=1170920#file1170920line145>
> >
> > This is pretty useful function to parse alerts source json and change some values.
> > Could we move those to general functions into abstractCatalog.
> >
> > I think we will need that a lot in future.
> >
> > Let's say we can create 2 functions one returns json as map, other saves the json. Or anything else general you think is better.
>
> Andrew Onischuk wrote:
> The goal is to make future upgrade changes to alerts source look as small as possible.
We have some usefull functions in entity as of now, so i think it will be better to add some additional there. Even if we will decide to add some functions in AbstractUpgradeCatalog, i think it should be implemented as a feature in separate jira, with Unit Tests and etc.
- Vitalyi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41526/#review111196
-----------------------------------------------------------
On Гру. 18, 2015, 4:23 після полудня, Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41526/
> -----------------------------------------------------------
>
> (Updated Гру. 18, 2015, 4:23 після полудня)
>
>
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, Jonathan Hurley, and Sumit Mohanty.
>
>
> Bugs: AMBARI-14424
> https://issues.apache.org/jira/browse/AMBARI-14424
>
>
> Repository: ambari
>
>
> Description
> -------
>
> For Hive metastore and server alerts
> 1) Change default timeout to 60 seconds
> 2) Make this a configurable script param, so people can pass this in
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/hive_check.py 55fd6bd
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 5e22f71
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog221.java PRE-CREATION
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json 55e3f78
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py c7a9102
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_thrift_port.py a04c2a6
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog221Test.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41526/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 41526: Hive Metastore alert timeout
Posted by Andrew Onischuk <ao...@hortonworks.com>.
> On Dec. 18, 2015, 4:28 p.m., Andrew Onischuk wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog221.java, line 145
> > <https://reviews.apache.org/r/41526/diff/2/?file=1170920#file1170920line145>
> >
> > This is pretty useful function to parse alerts source json and change some values.
> > Could we move those to general functions into abstractCatalog.
> >
> > I think we will need that a lot in future.
> >
> > Let's say we can create 2 functions one returns json as map, other saves the json. Or anything else general you think is better.
The goal is to make future upgrade changes to alerts source look as small as possible.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41526/#review111196
-----------------------------------------------------------
On Dec. 18, 2015, 4:23 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41526/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2015, 4:23 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, Jonathan Hurley, and Sumit Mohanty.
>
>
> Bugs: AMBARI-14424
> https://issues.apache.org/jira/browse/AMBARI-14424
>
>
> Repository: ambari
>
>
> Description
> -------
>
> For Hive metastore and server alerts
> 1) Change default timeout to 60 seconds
> 2) Make this a configurable script param, so people can pass this in
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/hive_check.py 55fd6bd
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 5e22f71
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog221.java PRE-CREATION
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json 55e3f78
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py c7a9102
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_thrift_port.py a04c2a6
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog221Test.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41526/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 41526: Hive Metastore alert timeout
Posted by Andrew Onischuk <ao...@hortonworks.com>.
> On Dec. 18, 2015, 4:28 p.m., Andrew Onischuk wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog221.java, line 145
> > <https://reviews.apache.org/r/41526/diff/2/?file=1170920#file1170920line145>
> >
> > This is pretty useful function to parse alerts source json and change some values.
> > Could we move those to general functions into abstractCatalog.
> >
> > I think we will need that a lot in future.
> >
> > Let's say we can create 2 functions one returns json as map, other saves the json. Or anything else general you think is better.
>
> Andrew Onischuk wrote:
> The goal is to make future upgrade changes to alerts source look as small as possible.
>
> Vitalyi Brodetskyi wrote:
> We have some usefull functions in entity as of now, so i think it will be better to add some additional there. Even if we will decide to add some functions in AbstractUpgradeCatalog, i think it should be implemented as a feature in separate jira, with Unit Tests and etc.
Can you create a jira than?
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41526/#review111196
-----------------------------------------------------------
On Dec. 18, 2015, 4:41 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41526/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2015, 4:41 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, Jonathan Hurley, and Sumit Mohanty.
>
>
> Bugs: AMBARI-14424
> https://issues.apache.org/jira/browse/AMBARI-14424
>
>
> Repository: ambari
>
>
> Description
> -------
>
> For Hive metastore and server alerts
> 1) Change default timeout to 60 seconds
> 2) Make this a configurable script param, so people can pass this in
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/hive_check.py 55fd6bd
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 5e22f71
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog221.java PRE-CREATION
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json 55e3f78
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py c7a9102
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_thrift_port.py a04c2a6
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog221Test.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41526/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 41526: Hive Metastore alert timeout
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41526/#review111196
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog221.java (line 145)
<https://reviews.apache.org/r/41526/#comment171298>
This is pretty useful function to parse alerts source json and change some values.
Could we move those to general functions into abstractCatalog.
I think we will need that a lot in future.
Let's say we can create 2 functions one returns json as map, other saves the json. Or anything else general you think is better.
- Andrew Onischuk
On Dec. 18, 2015, 4:23 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41526/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2015, 4:23 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, Jonathan Hurley, and Sumit Mohanty.
>
>
> Bugs: AMBARI-14424
> https://issues.apache.org/jira/browse/AMBARI-14424
>
>
> Repository: ambari
>
>
> Description
> -------
>
> For Hive metastore and server alerts
> 1) Change default timeout to 60 seconds
> 2) Make this a configurable script param, so people can pass this in
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/hive_check.py 55fd6bd
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 5e22f71
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog221.java PRE-CREATION
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json 55e3f78
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py c7a9102
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_thrift_port.py a04c2a6
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog221Test.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41526/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 41526: Hive Metastore alert timeout
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41526/
-----------------------------------------------------------
(Updated Гру. 18, 2015, 4:23 після полудня)
Review request for Ambari, Andrew Onischuk, Dmytro Sen, Jonathan Hurley, and Sumit Mohanty.
Bugs: AMBARI-14424
https://issues.apache.org/jira/browse/AMBARI-14424
Repository: ambari
Description
-------
For Hive metastore and server alerts
1) Change default timeout to 60 seconds
2) Make this a configurable script param, so people can pass this in
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/libraries/functions/hive_check.py 55fd6bd
ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 5e22f71
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog221.java PRE-CREATION
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json 55e3f78
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py c7a9102
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_thrift_port.py a04c2a6
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog221Test.java PRE-CREATION
Diff: https://reviews.apache.org/r/41526/diff/
Testing
-------
mvn clean test
Thanks,
Vitalyi Brodetskyi
Re: Review Request 41526: Hive Metastore alert timeout
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41526/#review111100
-----------------------------------------------------------
Ship it!
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json (lines 17 - 22)
<https://reviews.apache.org/r/41526/#comment171082>
On upgrade from Ambari 2.x, we should also update this.
- Jonathan Hurley
On Dec. 17, 2015, 2:45 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41526/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2015, 2:45 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, Jonathan Hurley, and Sumit Mohanty.
>
>
> Bugs: AMBARI-14424
> https://issues.apache.org/jira/browse/AMBARI-14424
>
>
> Repository: ambari
>
>
> Description
> -------
>
> For Hive metastore and server alerts
> 1) Change default timeout to 60 seconds
> 2) Make this a configurable script param, so people can pass this in
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/hive_check.py 55fd6bd
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json 55e3f78
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py c7a9102
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_thrift_port.py a04c2a6
>
> Diff: https://reviews.apache.org/r/41526/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 41526: Hive Metastore alert timeout
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
> On Гру. 17, 2015, 8:56 після полудня, Andrew Onischuk wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py, line 183
> > <https://reviews.apache.org/r/41526/diff/1/?file=1170216#file1170216line183>
> >
> > Let's say we upgraded and the check_command_timeout will be null
> > int(null) will give you Exception.
>
> Andrew Onischuk wrote:
> Actually nm, my bad, seems like you have CHECK_COMMAND_TIMEOUT_DEFAULT there.
I forgot to add changes to definition during upgrade. Will do that.
- Vitalyi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41526/#review111046
-----------------------------------------------------------
On Гру. 17, 2015, 7:45 після полудня, Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41526/
> -----------------------------------------------------------
>
> (Updated Гру. 17, 2015, 7:45 після полудня)
>
>
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, Jonathan Hurley, and Sumit Mohanty.
>
>
> Bugs: AMBARI-14424
> https://issues.apache.org/jira/browse/AMBARI-14424
>
>
> Repository: ambari
>
>
> Description
> -------
>
> For Hive metastore and server alerts
> 1) Change default timeout to 60 seconds
> 2) Make this a configurable script param, so people can pass this in
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/hive_check.py 55fd6bd
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json 55e3f78
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py c7a9102
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_thrift_port.py a04c2a6
>
> Diff: https://reviews.apache.org/r/41526/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 41526: Hive Metastore alert timeout
Posted by Andrew Onischuk <ao...@hortonworks.com>.
> On Dec. 17, 2015, 8:56 p.m., Andrew Onischuk wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py, line 183
> > <https://reviews.apache.org/r/41526/diff/1/?file=1170216#file1170216line183>
> >
> > Let's say we upgraded and the check_command_timeout will be null
> > int(null) will give you Exception.
Actually nm, my bad, seems like you have CHECK_COMMAND_TIMEOUT_DEFAULT there.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41526/#review111046
-----------------------------------------------------------
On Dec. 17, 2015, 7:45 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41526/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2015, 7:45 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, Jonathan Hurley, and Sumit Mohanty.
>
>
> Bugs: AMBARI-14424
> https://issues.apache.org/jira/browse/AMBARI-14424
>
>
> Repository: ambari
>
>
> Description
> -------
>
> For Hive metastore and server alerts
> 1) Change default timeout to 60 seconds
> 2) Make this a configurable script param, so people can pass this in
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/hive_check.py 55fd6bd
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json 55e3f78
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py c7a9102
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_thrift_port.py a04c2a6
>
> Diff: https://reviews.apache.org/r/41526/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 41526: Hive Metastore alert timeout
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41526/#review111046
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py (line 183)
<https://reviews.apache.org/r/41526/#comment171038>
Let's say we upgraded and the check_command_timeout will be null
int(null) will give you Exception.
- Andrew Onischuk
On Dec. 17, 2015, 7:45 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41526/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2015, 7:45 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, Jonathan Hurley, and Sumit Mohanty.
>
>
> Bugs: AMBARI-14424
> https://issues.apache.org/jira/browse/AMBARI-14424
>
>
> Repository: ambari
>
>
> Description
> -------
>
> For Hive metastore and server alerts
> 1) Change default timeout to 60 seconds
> 2) Make this a configurable script param, so people can pass this in
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/hive_check.py 55fd6bd
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json 55e3f78
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py c7a9102
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_thrift_port.py a04c2a6
>
> Diff: https://reviews.apache.org/r/41526/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 41526: Hive Metastore alert timeout
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41526/#review111048
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Onischuk
On Dec. 17, 2015, 7:45 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41526/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2015, 7:45 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, Jonathan Hurley, and Sumit Mohanty.
>
>
> Bugs: AMBARI-14424
> https://issues.apache.org/jira/browse/AMBARI-14424
>
>
> Repository: ambari
>
>
> Description
> -------
>
> For Hive metastore and server alerts
> 1) Change default timeout to 60 seconds
> 2) Make this a configurable script param, so people can pass this in
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/hive_check.py 55fd6bd
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json 55e3f78
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py c7a9102
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_thrift_port.py a04c2a6
>
> Diff: https://reviews.apache.org/r/41526/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>