You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tvm.apache.org by Andrew Reusch via Apache TVM Discuss <no...@discuss.tvm.ai> on 2021/12/06 21:52:26 UTC

[Apache TVM Discuss] [Development/pre-RFC] [RFC][CI] Add a `[skip ci]` tag to shortcut builds and tests


Summarizing the discussion a bit here:

- There is consensus that such a bypass mechanism could be useful
- There is widespread concern of abuse. Due to this concern, it's been suggested to also improve our CI filter to skip parts of the CI for certain changes.
- There is consensus that committers should enforce that some verification be done prior to submitting the PR.

Given the above, my suggestion would be we move forward as follows:
1. We move forward with a trial period of `[skip ci]` but require it to be present in the PR title so that it's clear from `git log`.
2. We limit `[skip ci]` to quickly reverting PRs which caused breakages.
3. We implement the CI filter suggestions from @manupa-arm to avoid introducing `[skip ci]` into our regular development flow. This way, if we decide to abandon the mechanism after a period of time, we do so independent of regression in our normal development workflow.

How does this sound to everyone?





---
[Visit Topic](https://discuss.tvm.apache.org/t/rfc-ci-add-a-skip-ci-tag-to-shortcut-builds-and-tests/11589/11) to respond.

You are receiving this because you enabled mailing list mode.

To unsubscribe from these emails, [click here](https://discuss.tvm.apache.org/email/unsubscribe/c4d7f65ff04ef5a634840b4f31d261a582e0b2ae3a2ef0afb4ab914f0e2e6b46).

[Apache TVM Discuss] [Development/pre-RFC] [RFC][CI] Add a `[skip ci]` tag to shortcut builds and tests

Posted by driazati via Apache TVM Discuss <no...@discuss.tvm.ai>.

On the implementation side a bot (likely this new one: https://github.com/tvm-bot) with triage-level permissions could ensure that `[skip ci]` is present in the PR title if any of the commits in the PR have skipped CI (if a commit comes later on where CI isn't skipped, the submitter can manually remove the tag from the PR and the bot can remove the label), similar to other Apache repos with triaging bots on PRs. Optionally it could add a label as well (which has the benefit that submitters without committer status can't edit labels directly)





---
[Visit Topic](https://discuss.tvm.apache.org/t/rfc-ci-add-a-skip-ci-tag-to-shortcut-builds-and-tests/11589/12) to respond.

You are receiving this because you enabled mailing list mode.

To unsubscribe from these emails, [click here](https://discuss.tvm.apache.org/email/unsubscribe/edab6fda925c59c1487927ffe6ea1eb954d1333ce78b3db3aed69d9a801d3fa5).