[GitHub] spark pull request: [SPARK-7862][SQL]Fix the deadlock in script tr...

[zhichao-li <gi...@git.apache.org>]

Github user zhichao-li commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6404#discussion_r31406553
  
    --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala ---
    @@ -629,12 +633,24 @@ class SQLQuerySuite extends QueryTest {
           .queryExecution.analyzed
       }
     
    -  test("test script transform") {
    +  test("test script transform for stdout") {
         val data = (1 to 100000).map { i => (i, i, i) }
         data.toDF("d1", "d2", "d3").registerTempTable("script_trans")
    -    assert(100000 ===
    -      sql("SELECT TRANSFORM (d1, d2, d3) USING 'cat' AS (a,b,c) FROM script_trans")
    -      .queryExecution.toRdd.count())
    +    failAfter(Span(20000, Millis)) {
    +      assert(100000 ===
    +        sql("SELECT TRANSFORM (d1, d2, d3) USING 'cat' AS (a,b,c) FROM script_trans")
    +          .queryExecution.toRdd.count())
    +    }
    +  }
    +
    +  test("test script transform for stderr") {
    +    val data = (1 to 100000).map { i => (i, i, i) }
    +    data.toDF("d1", "d2", "d3").registerTempTable("script_trans")
    +    failAfter(Span(20000, Millis)) {
    --- End diff --
    
    Put it here just to ensure if the deadlock happen again it can be somehow detected. (although in theory it would be an option any more). Any advice ? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org