You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2016/04/15 04:09:15 UTC
Review Request 46245: Renamed Docker and CNI BASE_NAME to meaningful
name.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46245/
-----------------------------------------------------------
Review request for mesos, Gilbert Song and Jie Yu.
Repository: mesos
Description
-------
Renamed Docker and CNI BASE_NAME to meaningful name.
Diffs
-----
src/CMakeLists.txt 06f58c4a88e3c527df727df1efe11ed3ab77efa8
Diff: https://reviews.apache.org/r/46245/diff/
Testing
-------
make
make check
Thanks,
Guangya Liu
Re: Review Request 46245: Renamed Docker and CNI BASE_NAME to
meaningful name.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46245/#review129575
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On April 19, 2016, 2:48 p.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46245/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 2:48 p.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Renamed Docker and CNI BASE_NAME to meaningful name.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt aabb33dfd4b985fe5774f87bb63b4ec1ec853962
>
> Diff: https://reviews.apache.org/r/46245/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 46245: Renamed Docker and CNI BASE_NAME to
meaningful name.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46245/
-----------------------------------------------------------
(Updated 四月 19, 2016, 2:48 p.m.)
Review request for mesos, Gilbert Song and Jie Yu.
Repository: mesos
Description
-------
Renamed Docker and CNI BASE_NAME to meaningful name.
Diffs (updated)
-----
src/CMakeLists.txt aabb33dfd4b985fe5774f87bb63b4ec1ec853962
Diff: https://reviews.apache.org/r/46245/diff/
Testing
-------
make
make check
Thanks,
Guangya Liu
Re: Review Request 46245: Renamed Docker and CNI BASE_NAME to
meaningful name.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46245/
-----------------------------------------------------------
(Updated 四月 15, 2016, 2:35 a.m.)
Review request for mesos, Gilbert Song and Jie Yu.
Repository: mesos
Description
-------
Renamed Docker and CNI BASE_NAME to meaningful name.
Diffs (updated)
-----
src/CMakeLists.txt 06f58c4a88e3c527df727df1efe11ed3ab77efa8
Diff: https://reviews.apache.org/r/46245/diff/
Testing
-------
make
make check
Thanks,
Guangya Liu
Re: Review Request 46245: Renamed Docker and CNI BASE_NAME to
meaningful name.
Posted by Guangya Liu <gy...@gmail.com>.
> On 四月 15, 2016, 2:19 a.m., Jie Yu wrote:
> > src/CMakeLists.txt, line 62
> > <https://reviews.apache.org/r/46245/diff/1/?file=1346078#file1346078line62>
> >
> > You should update it, right?
> >
> > Can you make sure you test the patch using cmake? Thanks!
was testing now, just noticed this. Thanks.
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46245/#review129058
-----------------------------------------------------------
On 四月 15, 2016, 2:09 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46245/
> -----------------------------------------------------------
>
> (Updated 四月 15, 2016, 2:09 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Renamed Docker and CNI BASE_NAME to meaningful name.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 06f58c4a88e3c527df727df1efe11ed3ab77efa8
>
> Diff: https://reviews.apache.org/r/46245/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 46245: Renamed Docker and CNI BASE_NAME to
meaningful name.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46245/#review129058
-----------------------------------------------------------
src/CMakeLists.txt (line 62)
<https://reviews.apache.org/r/46245/#comment192510>
You should update it, right?
Can you make sure you test the patch using cmake? Thanks!
- Jie Yu
On April 15, 2016, 2:09 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46245/
> -----------------------------------------------------------
>
> (Updated April 15, 2016, 2:09 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Renamed Docker and CNI BASE_NAME to meaningful name.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 06f58c4a88e3c527df727df1efe11ed3ab77efa8
>
> Diff: https://reviews.apache.org/r/46245/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>