[GitHub] [ignite-3] isapego commented on a change in pull request #383: IGNITE-15686 TableExample and KeyValueBinaryViewExample fail with NPE

[GitBox <gi...@apache.org>]

isapego commented on a change in pull request #383:
URL: https://github.com/apache/ignite-3/pull/383#discussion_r722988440



##########
File path: examples/src/main/java/org/apache/ignite/example/table/KeyValueBinaryViewExample.java
##########
@@ -43,72 +46,71 @@
  */
 public class KeyValueBinaryViewExample {
     public static void main(String[] args) throws Exception {
-        Ignite ignite = IgnitionManager.start(
+        try (Ignite ignite = IgnitionManager.start(
             "node-0",
-            Files.readString(Path.of("config", "ignite-config.json").toAbsolutePath()),
+            Files.readString(Path.of("config", "ignite-config.json")),

Review comment:
       In `SqlJdbcExample` we are using path `"examples/config/ignite-config.json"`. Need to unify it (change path here or there)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org