You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/25 12:17:59 UTC

[GitHub] [arrow-datafusion] Ted-Jiang commented on a diff in pull request #2324: Implementing math power function for SQL

Ted-Jiang commented on code in PR #2324:
URL: https://github.com/apache/arrow-datafusion/pull/2324#discussion_r857562140


##########
datafusion/expr/src/function.rs:
##########
@@ -217,6 +217,11 @@ pub fn return_type(
             }
         }),
 
+        BuiltinScalarFunction::Power => match &input_expr_types[0] {
+            DataType::Int32 | DataType::Int64 => Ok(DataType::Int64),

Review Comment:
   what about Int8,Int16, UInt....



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org