You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org> on 2018/01/08 20:55:21 UTC

[kudu-CR] [tablet] Add a pre-compaction check to avoid compactions in the past

Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8887

to look at the new patch set (#3).

Change subject: [tablet] Add a pre-compaction check to avoid compactions in the past
......................................................................

[tablet] Add a pre-compaction check to avoid compactions in the past

This adds a pre-compaction check that gets the max timestamp of all
the rows that will be considered for compaction and makes sure that
timestamp is considered committed under the compaction snapshot.

This is generalization of the repro introduced in previous patches
for KUDU-2233 but that now applies to all compactions in the past
and not only those which have duplicated rows in the inputs.

This is not a fix yet, that's left for follow up patches.

Change-Id: I80edc9dc8d5eec475998a9c721b9f591eb6180dc
---
M src/kudu/tablet/compaction.cc
M src/kudu/tablet/compaction.h
M src/kudu/tablet/delta_tracker.cc
M src/kudu/tablet/delta_tracker.h
M src/kudu/tablet/diskrowset.cc
M src/kudu/tablet/diskrowset.h
M src/kudu/tablet/memrowset.cc
M src/kudu/tablet/memrowset.h
M src/kudu/tablet/mock-rowsets.h
M src/kudu/tablet/rowset.cc
M src/kudu/tablet/rowset.h
M src/kudu/tablet/tablet.cc
12 files changed, 153 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/87/8887/3
-- 
To view, visit http://gerrit.cloudera.org:8080/8887
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I80edc9dc8d5eec475998a9c721b9f591eb6180dc
Gerrit-Change-Number: 8887
Gerrit-PatchSet: 3
Gerrit-Owner: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins