You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@apache.org> on 2019/12/20 02:49:09 UTC
Re: Review Request 71930: ATLAS-3566: improvements in upgrade patches,
to avoid full-scan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71930/#review219072
-----------------------------------------------------------
Ship it!
Ship It!
- Sarath Subramanian
On Dec. 19, 2019, 5:14 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71930/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2019, 5:14 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Nikhil Bonte, Nixon Rodrigues, Saqeeb Shaikh, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3566
> https://issues.apache.org/jira/browse/ATLAS-3566
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Patches that update for vertices for unique-attributes and classification-text fields currently perform a full-scan, which can cause a long delay before processing can begin. Updated this to process entities one type after another - which avoids full-scan, as the query uses indexes on typeName field.
>
> For classfication-text field update, the processing is updated to scan for classfication vertices and find the entity vertices for each classification found. This would also avoid full-scan, and in addition avoid additional cost of fetching entities that don't have classifications attached.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/patches/ClassificationTextPatch.java 2af50ba4d
> repository/src/main/java/org/apache/atlas/repository/patches/ConcurrentPatchProcessor.java 3eedb9839
> repository/src/main/java/org/apache/atlas/repository/patches/UniqueAttributePatch.java bd5e32b30
>
>
> Diff: https://reviews.apache.org/r/71930/diff/1/
>
>
> Testing
> -------
>
> - verified manually
> - pre-commit tests run: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1594/
>
>
> Thanks,
>
> Madhan Neethiraj
>
>