[jira] [Created] (ISIS-1060) An exception is logged when the provided credentials are invalid

["Martin Grigorov (JIRA)" <ji...@apache.org>]

Martin Grigorov created ISIS-1060:
-------------------------------------

             Summary: An exception is logged when the provided credentials are invalid
                 Key: ISIS-1060
                 URL: https://issues.apache.org/jira/browse/ISIS-1060
             Project: Isis
          Issue Type: Wish
          Components: Core
    Affects Versions: core-1.8.0
            Reporter: Martin Grigorov
            Assignee: Martin Grigorov


If trying to authenticate with wrong credentials Isis Shiro integration logs an ERROR with its complete stacktrace.
This is not an error in the application so I think it should be logged with lower level, e.g. WARN (but even WARN looks too much to me for this normal use case).
The second change that I'd recommend is to not dump the stacktrace.
Instead of:
  LOG.error("Unable to authenticate", ae);
do:
  LOG.error("Unable to authenticate. Reason: " + ae.getMessage());



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)