You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampipes.apache.org by GitBox <gi...@apache.org> on 2023/01/16 20:39:53 UTC
[GitHub] [streampipes] bossenti opened a new issue, #1102: Execute jobs in pr validation workflow only when required
bossenti opened a new issue, #1102:
URL: https://github.com/apache/streampipes/issues/1102
### Body
With our current [PR validation](https://github.com/apache/streampipes/blob/dev/.github/workflows/pr-validation.yml) workflow all jobs for checking the PR are run no matter what changes are contained.
This results in lot of wasted runs, e.g., running the Python checks when only Java code is commited, and higher run times.
As an outcome of this issue, the individual jobs of the PR validation workflow should only be run when they are required by the changes of the underlying PR.
### Mentoring
As this ticket is marked as good first issue: @tenthe, @dominikriemer or @bossenti are happy to provide help for getting started.
This issue migh be especially suitable for first-time committers having some experiences with GitHub actions.
### StreamPipes Committer
I acknowledge that I am a maintainer/committer of the Apache StreamPipes project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Execute jobs in pr validation workflow only when required (streampipes)
Posted by "yuktea (via GitHub)" <gi...@apache.org>.
yuktea commented on issue #1102:
URL: https://github.com/apache/streampipes/issues/1102#issuecomment-1551889291
Thank you for the review, @bossenti. I'll work on another iteration soon to factor in the modifications you suggested for the UI/backend tests. From my understanding, we'll only run the UI tests when there are UI changes and similarly for the backend.
On a separate note, I wanted to discuss the project you're mentoring for OSPP 2023. I sent you an email about this, but I wanted to confirm if email is your preferred method of communication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Execute jobs in pr validation workflow only when required (streampipes)
Posted by "bossenti (via GitHub)" <gi...@apache.org>.
bossenti commented on issue #1102:
URL: https://github.com/apache/streampipes/issues/1102#issuecomment-1548291615
The `paths` attribute of GitHub workflows might be relevant here: https://docs.github.com/de/actions/using-workflows/workflow-syntax-for-github-actions#onpushpull_requestpull_request_targetpathspaths-ignore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Execute jobs in pr validation workflow only when required (streampipes)
Posted by "bossenti (via GitHub)" <gi...@apache.org>.
bossenti commented on issue #1102:
URL: https://github.com/apache/streampipes/issues/1102#issuecomment-1548085347
welcome to StreamPipes @yuktea 👋🏼
The aim of the ticket is to run a step of our PR validation only when the PR's requires it.
Only the E2E tests as well as the Maven RAT plugin should be executed for every run.
Are there any open questions to you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Execute jobs in pr validation workflow only when required (streampipes)
Posted by "yuktea (via GitHub)" <gi...@apache.org>.
yuktea commented on issue #1102:
URL: https://github.com/apache/streampipes/issues/1102#issuecomment-1547539832
Hi @bossenti I want to work on this issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Execute jobs in pr validation workflow only when required (streampipes)
Posted by "bossenti (via GitHub)" <gi...@apache.org>.
bossenti commented on issue #1102:
URL: https://github.com/apache/streampipes/issues/1102#issuecomment-1556270724
@yuktea I just replied to your email, hope this reaches you well!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Execute jobs in pr validation workflow only when required (streampipes)
Posted by "bossenti (via GitHub)" <gi...@apache.org>.
bossenti commented on issue #1102:
URL: https://github.com/apache/streampipes/issues/1102#issuecomment-1551514903
great, @yuktea!
I think it makes sense to move the Python stuff to a dedicated workflow file.
The dependencies were only introduced to avoid the long running steps when one of the fast ones already failed. So you can safely remove the python-related dependencies.
This is good first iteration which we could already merge.
However, I could image to improve this to be even more fine granular and applying similar modifications for he UI and backend as well. But therefore we probably need something like https://github.com/dorny/paths-filter to get the desired behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Execute jobs in pr validation workflow only when required (streampipes)
Posted by "yuktea (via GitHub)" <gi...@apache.org>.
yuktea commented on issue #1102:
URL: https://github.com/apache/streampipes/issues/1102#issuecomment-1549583469
@bossenti: Hi 👋 I opened a draft [PR](#1573) for this. In my PR, I separated the python workflows into a different `yaml` file and added a `path` attribute.
Looks like the E2E tests and the Maven RAT have a dependency on some of the python workflows. If this dependency is here just so that they execute sequentially, I believe we can remove it in that case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Execute jobs in pr validation workflow only when required (streampipes)
Posted by "bossenti (via GitHub)" <gi...@apache.org>.
bossenti commented on issue #1102:
URL: https://github.com/apache/streampipes/issues/1102#issuecomment-1551894003
That sounds great, I'm already looking forward to it.
Just be aware that the E2E tests and the RAT plug-in should always run (like mentioned in the description).
Sure, email is fine
Unfortunately, I will not have the possibility to look it up until Sunday... but I will read and respond to your message for sure! 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org