You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "nsivabalan (via GitHub)" <gi...@apache.org> on 2025/04/03 21:26:46 UTC
[PR] [MINOR] Fixing master for build failure [hudi]
nsivabalan opened a new pull request, #13085:
URL: https://github.com/apache/hudi/pull/13085
### Change Logs
Fixing master for build failure
### Impact
Fixing master for build failure
### Risk level (write none, low medium or high below)
low
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none"._
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Fixing master for build failure [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13085:
URL: https://github.com/apache/hudi/pull/13085#issuecomment-2776959011
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a9afa718f7bca8020a071d9c79769567a346bafa",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4625",
"triggerID" : "a9afa718f7bca8020a071d9c79769567a346bafa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a9afa718f7bca8020a071d9c79769567a346bafa Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4625)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Fixing master for build failure [hudi]
Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan commented on code in PR #13085:
URL: https://github.com/apache/hudi/pull/13085#discussion_r2027766666
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/config/TestHoodieWriteConfig.java:
##########
@@ -103,7 +103,7 @@ public void testSupportedTableWriteVersions() {
Properties props = new Properties();
props.setProperty(HoodieWriteConfig.WRITE_TABLE_VERSION.key(), String.valueOf(version.versionCode()));
assertThrows(IllegalArgumentException.class, () -> HoodieWriteConfig.newBuilder()
- .withPath("/tmp").withProperties(props).build());
+ .withPath("/tmp").withProperties(props).build().getWriteVersion());
Review Comment:
We landed this patch w/o waiting for full CI run
https://github.com/apache/hudi/commit/c7c3532477a611d94b8bb53af592bde2f151d764
thinking it just a warn msg we are removing.
but apparently, one test is failing after this commit was merged.
Fixing the test in this patch to un block master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Fixing master for build failure [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13085:
URL: https://github.com/apache/hudi/pull/13085#issuecomment-2776956305
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a9afa718f7bca8020a071d9c79769567a346bafa",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a9afa718f7bca8020a071d9c79769567a346bafa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a9afa718f7bca8020a071d9c79769567a346bafa UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Fixing master for build failure [hudi]
Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan merged PR #13085:
URL: https://github.com/apache/hudi/pull/13085
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org