You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "lrybbs (via GitHub)" <gi...@apache.org> on 2023/03/03 05:55:09 UTC
[GitHub] [rocketmq] lrybbs opened a new pull request, #6234: Add logging exporter for metrics
lrybbs opened a new pull request, #6234:
URL: https://github.com/apache/rocketmq/pull/6234
I have completed the issue #5678 @ShadowySpirits , now broker and proxy could export metrics in terminal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] ShadowySpirits commented on a diff in pull request #6234: Add logging exporter for metrics
Posted by "ShadowySpirits (via GitHub)" <gi...@apache.org>.
ShadowySpirits commented on code in PR #6234:
URL: https://github.com/apache/rocketmq/pull/6234#discussion_r1124052605
##########
common/src/main/java/org/apache/rocketmq/common/BrokerConfig.java:
##########
@@ -376,12 +379,13 @@ public boolean isEnable() {
}
}
- private MetricsExporterType metricsExporterType = MetricsExporterType.DISABLE;
+ private MetricsExporterType metricsExporterType = MetricsExporterType.LOGGER;
Review Comment:
Please do not change the default value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] aaron-ai commented on a diff in pull request #6234: Add logging exporter for metrics
Posted by "aaron-ai (via GitHub)" <gi...@apache.org>.
aaron-ai commented on code in PR #6234:
URL: https://github.com/apache/rocketmq/pull/6234#discussion_r1124072102
##########
common/src/main/java/org/apache/rocketmq/common/BrokerConfig.java:
##########
@@ -376,12 +379,13 @@ public boolean isEnable() {
}
}
- private MetricsExporterType metricsExporterType = MetricsExporterType.DISABLE;
+ private MetricsExporterType metricsExporterType = MetricsExporterType.LOGGER;
Review Comment:
Actually there is [an official bridge from SLF4j](https://www.slf4j.org/legacy.html#:~:text=endless%20loop.-,jul%2Dto%2Dslf4j%20bridge,-The%20jul%2Dto), @lrybbs just try it out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #6234: Add logging exporter for metrics
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6234:
URL: https://github.com/apache/rocketmq/pull/6234#issuecomment-1453061705
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/6234?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6234](https://codecov.io/gh/apache/rocketmq/pull/6234?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f7d0271) into [develop](https://codecov.io/gh/apache/rocketmq/commit/543c11820028c0e9ffd9c6ab5895512d73149370?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (543c118) will **increase** coverage by `0.00%`.
> The diff coverage is `12.12%`.
> :exclamation: Current head f7d0271 differs from pull request most recent head c8f1c9a. Consider uploading reports for the commit c8f1c9a to get more accurate results
```diff
@@ Coverage Diff @@
## develop #6234 +/- ##
==========================================
Coverage 43.18% 43.19%
- Complexity 8851 8858 +7
==========================================
Files 1094 1094
Lines 77184 77216 +32
Branches 10070 10076 +6
==========================================
+ Hits 33334 33351 +17
- Misses 39684 39694 +10
- Partials 4166 4171 +5
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/6234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../rocketmq/broker/metrics/BrokerMetricsManager.java](https://codecov.io/gh/apache/rocketmq/pull/6234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvbWV0cmljcy9Ccm9rZXJNZXRyaWNzTWFuYWdlci5qYXZh) | `11.80% <0.00%> (-0.42%)` | :arrow_down: |
| [...he/rocketmq/proxy/metrics/ProxyMetricsManager.java](https://codecov.io/gh/apache/rocketmq/pull/6234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L21ldHJpY3MvUHJveHlNZXRyaWNzTWFuYWdlci5qYXZh) | `6.45% <0.00%> (-0.63%)` | :arrow_down: |
| [.../org/apache/rocketmq/proxy/config/ProxyConfig.java](https://codecov.io/gh/apache/rocketmq/pull/6234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L2NvbmZpZy9Qcm94eUNvbmZpZy5qYXZh) | `44.73% <25.00%> (-0.14%)` | :arrow_down: |
| [.../java/org/apache/rocketmq/common/BrokerConfig.java](https://codecov.io/gh/apache/rocketmq/pull/6234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vQnJva2VyQ29uZmlnLmphdmE=) | `27.97% <42.85%> (+0.05%)` | :arrow_up: |
| [...controller/impl/DefaultBrokerHeartbeatManager.java](https://codecov.io/gh/apache/rocketmq/pull/6234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvY29udHJvbGxlci9pbXBsL0RlZmF1bHRCcm9rZXJIZWFydGJlYXRNYW5hZ2VyLmphdmE=) | `82.27% <0.00%> (-3.80%)` | :arrow_down: |
| [...ketmq/proxy/grpc/v2/channel/GrpcClientChannel.java](https://codecov.io/gh/apache/rocketmq/pull/6234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L2dycGMvdjIvY2hhbm5lbC9HcnBjQ2xpZW50Q2hhbm5lbC5qYXZh) | `49.07% <0.00%> (-2.78%)` | :arrow_down: |
| [...ent/impl/consumer/DefaultLitePullConsumerImpl.java](https://codecov.io/gh/apache/rocketmq/pull/6234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9EZWZhdWx0TGl0ZVB1bGxDb25zdW1lckltcGwuamF2YQ==) | `67.53% <0.00%> (-0.62%)` | :arrow_down: |
| [.../org/apache/rocketmq/store/ha/DefaultHAClient.java](https://codecov.io/gh/apache/rocketmq/pull/6234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2hhL0RlZmF1bHRIQUNsaWVudC5qYXZh) | `61.34% <0.00%> (-0.52%)` | :arrow_down: |
| [...che/rocketmq/test/lmq/benchmark/BenchLmqStore.java](https://codecov.io/gh/apache/rocketmq/pull/6234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC9sbXEvYmVuY2htYXJrL0JlbmNoTG1xU3RvcmUuamF2YQ==) | `50.24% <0.00%> (-0.50%)` | :arrow_down: |
| [...he/rocketmq/client/trace/AsyncTraceDispatcher.java](https://codecov.io/gh/apache/rocketmq/pull/6234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvdHJhY2UvQXN5bmNUcmFjZURpc3BhdGNoZXIuamF2YQ==) | `83.65% <0.00%> (-0.49%)` | :arrow_down: |
| ... and [11 more](https://codecov.io/gh/apache/rocketmq/pull/6234?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] ShadowySpirits commented on a diff in pull request #6234: Add logging exporter for metrics
Posted by "ShadowySpirits (via GitHub)" <gi...@apache.org>.
ShadowySpirits commented on code in PR #6234:
URL: https://github.com/apache/rocketmq/pull/6234#discussion_r1124694311
##########
common/src/main/java/org/apache/rocketmq/common/BrokerConfig.java:
##########
@@ -376,12 +379,13 @@ public boolean isEnable() {
}
}
- private MetricsExporterType metricsExporterType = MetricsExporterType.DISABLE;
+ private MetricsExporterType metricsExporterType = MetricsExporterType.LOGGER;
Review Comment:
> Actually there is [an official bridge from SLF4j](https://www.slf4j.org/legacy.html#:~:text=endless%20loop.-,jul%2Dto%2Dslf4j%20bridge,-The%20jul%2Dto), @lrybbs just try it out.
You are right, but we should make it compatible with shaded sl4j. Can you give some guide for @lrybbs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lrybbs commented on a diff in pull request #6234: Add logging exporter for metrics
Posted by "lrybbs (via GitHub)" <gi...@apache.org>.
lrybbs commented on code in PR #6234:
URL: https://github.com/apache/rocketmq/pull/6234#discussion_r1127767490
##########
common/src/main/java/org/apache/rocketmq/common/BrokerConfig.java:
##########
@@ -376,12 +379,13 @@ public boolean isEnable() {
}
}
- private MetricsExporterType metricsExporterType = MetricsExporterType.DISABLE;
+ private MetricsExporterType metricsExporterType = MetricsExporterType.LOGGER;
Review Comment:
@aaron-ai Now, broker metrics and proxy metric could output to "rocketmqlogs" folder. Their names are "broker_metric.log" and "proxy_metric.log", respectively.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] aaron-ai commented on a diff in pull request #6234: Add logging exporter for metrics
Posted by "aaron-ai (via GitHub)" <gi...@apache.org>.
aaron-ai commented on code in PR #6234:
URL: https://github.com/apache/rocketmq/pull/6234#discussion_r1124072102
##########
common/src/main/java/org/apache/rocketmq/common/BrokerConfig.java:
##########
@@ -376,12 +379,13 @@ public boolean isEnable() {
}
}
- private MetricsExporterType metricsExporterType = MetricsExporterType.DISABLE;
+ private MetricsExporterType metricsExporterType = MetricsExporterType.LOGGER;
Review Comment:
Actually there is [an official bridge from SLF4j](https://www.slf4j.org/legacy.html#:~:text=endless%20loop.-,jul%2Dto%2Dslf4j%20bridge,-The%20jul%2Dto).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] ShadowySpirits commented on a diff in pull request #6234: Add logging exporter for metrics
Posted by "ShadowySpirits (via GitHub)" <gi...@apache.org>.
ShadowySpirits commented on code in PR #6234:
URL: https://github.com/apache/rocketmq/pull/6234#discussion_r1124054767
##########
common/src/main/java/org/apache/rocketmq/common/BrokerConfig.java:
##########
@@ -376,12 +379,13 @@ public boolean isEnable() {
}
}
- private MetricsExporterType metricsExporterType = MetricsExporterType.DISABLE;
+ private MetricsExporterType metricsExporterType = MetricsExporterType.LOGGER;
Review Comment:
@aaron-ai Could you please approve running the ci? And we need to add a jul to sl4j bridge in [aliyunmq/rocketmq-shaded-slf4j-api-bridge](https://github.com/aliyunmq/rocketmq-shaded-slf4j-api-bridge/tree/master).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] aaron-ai commented on a diff in pull request #6234: Add logging exporter for metrics
Posted by "aaron-ai (via GitHub)" <gi...@apache.org>.
aaron-ai commented on code in PR #6234:
URL: https://github.com/apache/rocketmq/pull/6234#discussion_r1126125246
##########
common/src/main/java/org/apache/rocketmq/common/BrokerConfig.java:
##########
@@ -376,12 +379,13 @@ public boolean isEnable() {
}
}
- private MetricsExporterType metricsExporterType = MetricsExporterType.DISABLE;
+ private MetricsExporterType metricsExporterType = MetricsExporterType.LOGGER;
Review Comment:
Since https://github.com/apache/rocketmq/pull/5959 has been merge, the unshaded SLF4j is compatible with the shaded SLF4j we introduced now. This means that after using the [jul-to-slf4j bridge](https://www.slf4j.org/legacy.html#:~:text=endless%20loop.-,jul%2Dto%2Dslf4j%20bridge,-The%20jul%2Dto), the logs can be automatically redirected to the shaded SLF4j.
Here is the related link you could refer to: https://stackoverflow.com/questions/9117030/jul-to-slf4j-bridge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] aaron-ai merged pull request #6234: [ISSUE #5678] Add logging exporter for metrics
Posted by "aaron-ai (via GitHub)" <gi...@apache.org>.
aaron-ai merged PR #6234:
URL: https://github.com/apache/rocketmq/pull/6234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org