You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@heron.apache.org by GitBox <gi...@apache.org> on 2019/01/29 20:01:20 UTC

[GitHub] xiaoyao1991 commented on a change in pull request #3180: [Streamlet] Fix streamlet config to apply cpu and ram in topology

xiaoyao1991 commented on a change in pull request #3180: [Streamlet] Fix streamlet config to apply cpu and ram in topology
URL: https://github.com/apache/incubator-heron/pull/3180#discussion_r251994573
 
 

 ##########
 File path: heron/api/src/java/org/apache/heron/streamlet/Config.java
 ##########
 @@ -196,16 +200,18 @@ public Builder setPerContainerCpu(double perContainerCpu) {
      * @param perContainerRam Per-container (per-instance) RAM expressed as a Long.
      */
     public Builder setPerContainerRam(long perContainerRam) {
-      this.ram = perContainerRam;
-      return this;
+      return setPerContainerRamInBytes(perContainerRam);
 
 Review comment:
   This indirection seems unnecessary

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services