You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/11/19 19:37:10 UTC
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8289:
Move from MVC FAB menu to Superset React menu
codecov-io edited a comment on issue #8289: Move from MVC FAB menu to Superset React menu
URL: https://github.com/apache/incubator-superset/pull/8289#issuecomment-537274666
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8289?src=pr&el=h1) Report
> Merging [#8289](https://codecov.io/gh/apache/incubator-superset/pull/8289?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/59bc220602a1e74f3df19902978512f276ee2d88?src=pr&el=desc) will **decrease** coverage by `1.06%`.
> The diff coverage is `63.33%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/8289/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/8289?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8289 +/- ##
==========================================
- Coverage 66.75% 65.69% -1.07%
==========================================
Files 450 479 +29
Lines 22734 23641 +907
Branches 2366 2587 +221
==========================================
+ Hits 15177 15530 +353
- Misses 7419 7942 +523
- Partials 138 169 +31
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8289?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8289/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.06% <ø> (ø)` | :arrow_up: |
| [superset/assets/src/welcome/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8289/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy93ZWxjb21lL0FwcC5qc3g=) | `0% <0%> (ø)` | :arrow_up: |
| [superset/assets/src/components/Menu/MenuObject.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8289/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL01lbnUvTWVudU9iamVjdC5qc3g=) | `20% <20%> (ø)` | |
| [...rset/assets/src/components/Menu/LanguagePicker.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8289/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL01lbnUvTGFuZ3VhZ2VQaWNrZXIuanN4) | `33.33% <33.33%> (ø)` | |
| [superset/assets/src/components/Menu/UserMenu.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8289/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL01lbnUvVXNlck1lbnUuanN4) | `50% <50%> (ø)` | |
| [superset/assets/src/components/Menu/NewMenu.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8289/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL01lbnUvTmV3TWVudS5qc3g=) | `60% <60%> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/8289/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.18% <83.33%> (+0.63%)` | :arrow_up: |
| [superset/assets/src/components/Menu/Menu.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8289/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL01lbnUvTWVudS5qc3g=) | `87.5% <87.5%> (ø)` | |
| [superset/views/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/8289/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi5weQ==) | `56.57% <0%> (-29.34%)` | :arrow_down: |
| [.../assets/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8289/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9UYWJiZWRTcWxFZGl0b3JzLmpzeA==) | `74.81% <0%> (-8.23%)` | :arrow_down: |
| ... and [72 more](https://codecov.io/gh/apache/incubator-superset/pull/8289/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8289?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8289?src=pr&el=footer). Last update [59bc220...6bfee70](https://codecov.io/gh/apache/incubator-superset/pull/8289?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org