You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "hangc0276 (via GitHub)" <gi...@apache.org> on 2023/10/29 05:34:53 UTC
[PR] Increase journal thread priority [bookkeeper]
hangc0276 opened a new pull request, #4120:
URL: https://github.com/apache/bookkeeper/pull/4120
### Motivation
When deploying Bookie on K8s with limited CPU resources, once the CPU is throttled, the journal write latency will increase.
One case of causing CPU throttle is garbage collection triggered.
<img width="1711" alt="image" src="https://github.com/apache/bookkeeper/assets/5436568/26bdd6d8-a52d-4e42-a157-9cac3684e9f7">
The journal write latency is sensitive with the journal CPU, especially when the CPU is throttled.
### Modifications
Increase the JournalThread and ForceWriteThread priority to reduce the latency impaction when the CPU is being throttled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Increase journal thread priority [bookkeeper]
Posted by "hangc0276 (via GitHub)" <gi...@apache.org>.
hangc0276 commented on PR #4120:
URL: https://github.com/apache/bookkeeper/pull/4120#issuecomment-1849403309
@merlimat @eolivelli @zymap @dlg99 @lhotari Please help take a look at this PR, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Increase journal thread priority [bookkeeper]
Posted by "zymap (via GitHub)" <gi...@apache.org>.
zymap commented on code in PR #4120:
URL: https://github.com/apache/bookkeeper/pull/4120#discussion_r1423351852
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java:
##########
@@ -471,6 +471,7 @@ public ForceWriteThread(Thread threadToNotifyOnEx,
boolean enableGroupForceWrites,
StatsLogger statsLogger) {
super("ForceWriteThread");
+ this.setPriority(Thread.MAX_PRIORITY);
Review Comment:
How about using a configuration to specify it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Increase journal thread priority [bookkeeper]
Posted by "merlimat (via GitHub)" <gi...@apache.org>.
merlimat merged PR #4120:
URL: https://github.com/apache/bookkeeper/pull/4120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org