You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by ji...@apache.org on 2020/08/24 17:59:23 UTC
[incubator-pinot] branch master updated: [TE] frontend -
harleyjj/units - Add notes and tooltips explaining SI prefix symbols
(#5886)
This is an automated email from the ASF dual-hosted git repository.
jihao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new ec27472 [TE] frontend - harleyjj/units - Add notes and tooltips explaining SI prefix symbols (#5886)
ec27472 is described below
commit ec27472bea8bb44ca65d29323108c54c1171b037
Author: Harley Jackson <hj...@linkedin.com>
AuthorDate: Mon Aug 24 10:59:10 2020 -0700
[TE] frontend - harleyjj/units - Add notes and tooltips explaining SI prefix symbols (#5886)
Add notes and tooltips explaining SI prefix symbols
---
.../app/pods/components/alert-details/template.hbs | 3 +++
.../app/pods/components/anomaly-summary/template.hbs | 4 +++-
.../app/pods/components/rootcause-anomaly/template.hbs | 4 ++++
.../app/pods/custom/anomalies-table/current-wow/template.hbs | 5 ++++-
thirdeye/thirdeye-frontend/app/pods/partials/si-note/template.hbs | 1 +
.../thirdeye-frontend/app/pods/partials/si-tooltip/template.hbs | 8 ++++++++
.../thirdeye-frontend/app/styles/components/rootcause-header.scss | 1 +
7 files changed, 24 insertions(+), 2 deletions(-)
diff --git a/thirdeye/thirdeye-frontend/app/pods/components/alert-details/template.hbs b/thirdeye/thirdeye-frontend/app/pods/components/alert-details/template.hbs
index d115fa2..3aac031 100644
--- a/thirdeye/thirdeye-frontend/app/pods/components/alert-details/template.hbs
+++ b/thirdeye/thirdeye-frontend/app/pods/components/alert-details/template.hbs
@@ -341,6 +341,9 @@
<div class="te-form__note">
NOTE: If you find the metric shown above is inconsistent, please email <a class="thirdeye-link-secondary" target="_blank" href="{{graphMailtoLink}}">ask_thirdeye</a>.
</div>
+ <div class="te-form__note">
+ {{partial 'partials/si-note'}}
+ </div>
{{/unless}}
{{/unless}}
</div>
diff --git a/thirdeye/thirdeye-frontend/app/pods/components/anomaly-summary/template.hbs b/thirdeye/thirdeye-frontend/app/pods/components/anomaly-summary/template.hbs
index d8b47ae..3b12567 100644
--- a/thirdeye/thirdeye-frontend/app/pods/components/anomaly-summary/template.hbs
+++ b/thirdeye/thirdeye-frontend/app/pods/components/anomaly-summary/template.hbs
@@ -69,7 +69,9 @@
</td>
<td class="te-anomaly-table__cell">
<ul class="te-anomaly-table__list">
- <li>{{anomaly.shownCurrent}} / {{anomaly.shownBaseline}}</li>
+ <li>{{anomaly.shownCurrent}} / {{anomaly.shownBaseline}}
+ {{partial 'partials/si-tooltip'}}
+ </li>
<li class="te-anomaly-table__value-label te-anomaly-table__value-label--{{calculate-direction anomaly.shownChangeRate}}">
{{#if (not anomaly.isNullChangeRate)}}
({{anomaly.shownChangeRate}}%)
diff --git a/thirdeye/thirdeye-frontend/app/pods/components/rootcause-anomaly/template.hbs b/thirdeye/thirdeye-frontend/app/pods/components/rootcause-anomaly/template.hbs
index 62d9cdc..adb62b9 100644
--- a/thirdeye/thirdeye-frontend/app/pods/components/rootcause-anomaly/template.hbs
+++ b/thirdeye/thirdeye-frontend/app/pods/components/rootcause-anomaly/template.hbs
@@ -114,6 +114,10 @@
</div>
</div>
{{/unless}}
+
+ <div class="rootcause-anomaly__body">
+ {{partial 'partials/si-note'}}
+ </div>
</div>
{{else}}
diff --git a/thirdeye/thirdeye-frontend/app/pods/custom/anomalies-table/current-wow/template.hbs b/thirdeye/thirdeye-frontend/app/pods/custom/anomalies-table/current-wow/template.hbs
index fecf9b9..14559ad 100644
--- a/thirdeye/thirdeye-frontend/app/pods/custom/anomalies-table/current-wow/template.hbs
+++ b/thirdeye/thirdeye-frontend/app/pods/custom/anomalies-table/current-wow/template.hbs
@@ -1,4 +1,7 @@
-<p class="te-anomaly-table__current-baseline">{{record.current}}/{{record.baseline}}</p>
+<p class="te-anomaly-table__current-baseline">
+ {{record.current}}/{{record.baseline}}
+ {{partial 'partials/si-tooltip'}}
+</p>
<p class="te-anomaly-table__value-label te-anomaly-table__value-label--dash te-anomaly-table__value-label--{{calculate-direction record.change}}">
({{record.humanizedChangeDisplay}})
</p>
diff --git a/thirdeye/thirdeye-frontend/app/pods/partials/si-note/template.hbs b/thirdeye/thirdeye-frontend/app/pods/partials/si-note/template.hbs
new file mode 100644
index 0000000..723e61f
--- /dev/null
+++ b/thirdeye/thirdeye-frontend/app/pods/partials/si-note/template.hbs
@@ -0,0 +1 @@
+What are the symbols being used to abbreviate long numeric values? {{partial 'partials/si-tooltip'}}
diff --git a/thirdeye/thirdeye-frontend/app/pods/partials/si-tooltip/template.hbs b/thirdeye/thirdeye-frontend/app/pods/partials/si-tooltip/template.hbs
new file mode 100644
index 0000000..4f4a8d1
--- /dev/null
+++ b/thirdeye/thirdeye-frontend/app/pods/partials/si-tooltip/template.hbs
@@ -0,0 +1,8 @@
+<span>
+ <a class="thirdeye-link thirdeye-link-secondary" href="https://en.wikipedia.org/wiki/Metric_prefix#List_of_SI_prefixes" target="_blank">
+ <i class="glyphicon glyphicon-question-sign"></i>
+ </a>
+ {{#tooltip-on-element class="te-tooltip"}}
+ Thirdeye uses SI prefix symbols to display numeric values in shorthand. Click for more info.
+ {{/tooltip-on-element}}
+</span>
diff --git a/thirdeye/thirdeye-frontend/app/styles/components/rootcause-header.scss b/thirdeye/thirdeye-frontend/app/styles/components/rootcause-header.scss
index 4a559e1..9799f35 100644
--- a/thirdeye/thirdeye-frontend/app/styles/components/rootcause-header.scss
+++ b/thirdeye/thirdeye-frontend/app/styles/components/rootcause-header.scss
@@ -32,6 +32,7 @@
resize: none;
border: none;
background: none;
+ width: 100%;
}
&--button {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org