You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Andreas Gudian (JIRA)" <ji...@codehaus.org> on 2012/12/29 17:37:13 UTC

[jira] (SUREFIRE-943) Failing tests in TEST-*.xml file contain currupt information

Andreas Gudian created SUREFIRE-943:
---------------------------------------

             Summary: Failing tests in TEST-*.xml file contain currupt information
                 Key: SUREFIRE-943
                 URL: https://jira.codehaus.org/browse/SUREFIRE-943
             Project: Maven Surefire
          Issue Type: Bug
          Components: Maven Surefire Plugin
    Affects Versions: 2.13
            Reporter: Andreas Gudian
            Priority: Critical


I have test classes with two test methods: one is {{test()}} (always passes), the other one is {{fails()}} (well, it is supposed to fail).

This is the output in the TEST-*.xml file:

{code}
  <testcase time="0.502" classname="org.sample.module.My1Test" name="org.sample.module.My1Test"/>
  <testcase time="0.503" classname="Description" name="fails">
    <failure message="Not yet implemented" type="java.lang.AssertionError">java.lang.AssertionError: Not yet implemented
	at org.junit.Assert.fail(Assert.java:88)
	at org.sample.module.My1Test.fails(My1Test.java:25)
</failure>
  </testcase>
{code}

Problem 1: for the successful testcase the {{name}} is also the class name and not the name of the test case? I would expect {{test}}, as this is the method name.

Problem 2 (that's the big one): the failed test contains "Description" as {{classname}}. That totally messes up my Hudson report and is a deal-breaker for the 2.13 version. I did not see that during the test of the staged version :(.

I used the junit47 provider and junit 4.11. 

I'll prepare a sample or an IT for that later.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] (SUREFIRE-943) Failing tests in TEST-*.xml file contain currupt information

Posted by "Kristian Rosenvold (JIRA)" <ji...@codehaus.org>.
    [ https://jira.codehaus.org/browse/SUREFIRE-943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=316447#comment-316447 ] 

Kristian Rosenvold commented on SUREFIRE-943:
---------------------------------------------

BTW; It should be possible to work around this problem by setting parallel=classes and threadCount=1, unless you are already using threadCount some different value ;)


                
> Failing tests in TEST-*.xml file contain currupt information
> ------------------------------------------------------------
>
>                 Key: SUREFIRE-943
>                 URL: https://jira.codehaus.org/browse/SUREFIRE-943
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: Maven Surefire Plugin
>    Affects Versions: 2.13
>            Reporter: Andreas Gudian
>            Priority: Critical
>         Attachments: SUREFIRE-943.patch
>
>
> I have test classes with two test methods: one is {{test()}} (always passes), the other one is {{fails()}} (well, it is supposed to fail).
> This is the output in the TEST-*.xml file:
> {code}
>   <testcase time="0.502" classname="org.sample.module.My1Test" name="org.sample.module.My1Test"/>
>   <testcase time="0.503" classname="Description" name="fails">
>     <failure message="Not yet implemented" type="java.lang.AssertionError">java.lang.AssertionError: Not yet implemented
> 	at org.junit.Assert.fail(Assert.java:88)
> 	at org.sample.module.My1Test.fails(My1Test.java:25)
> </failure>
>   </testcase>
> {code}
> Problem 1: for the successful testcase the {{name}} is also the class name and not the name of the test case? I would expect {{test}}, as this is the method name.
> Problem 2 (that's the big one): the failed test contains "Description" as {{classname}}. That totally messes up my Hudson report and is a deal-breaker for the 2.13 version. I did not see that during the test of the staged version :(.
> I used the junit47 provider and junit 4.11. 
> I'll prepare a sample or an IT for that later.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] (SUREFIRE-943) Failing tests in TEST-*.xml file contain currupt information

Posted by "Falko Modler (JIRA)" <ji...@codehaus.org>.
    [ https://jira.codehaus.org/browse/SUREFIRE-943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=317245#comment-317245 ] 

Falko Modler commented on SUREFIRE-943:
---------------------------------------

bq. That totally messes up my Hudson report and is a deal-breaker for the 2.13 version.

I second that. This issue also kills our frontend test build in Jenkins which executes a custom xsl stylesheet to aggregate the test results in a special manner.
It has been working fine "for ages" before updating to 2.13.
                
> Failing tests in TEST-*.xml file contain currupt information
> ------------------------------------------------------------
>
>                 Key: SUREFIRE-943
>                 URL: https://jira.codehaus.org/browse/SUREFIRE-943
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: Maven Surefire Plugin
>    Affects Versions: 2.13
>            Reporter: Andreas Gudian
>            Priority: Critical
>         Attachments: SUREFIRE-943.patch
>
>
> I have test classes with two test methods: one is {{test()}} (always passes), the other one is {{fails()}} (well, it is supposed to fail).
> This is the output in the TEST-*.xml file:
> {code}
>   <testcase time="0.502" classname="org.sample.module.My1Test" name="org.sample.module.My1Test"/>
>   <testcase time="0.503" classname="Description" name="fails">
>     <failure message="Not yet implemented" type="java.lang.AssertionError">java.lang.AssertionError: Not yet implemented
> 	at org.junit.Assert.fail(Assert.java:88)
> 	at org.sample.module.My1Test.fails(My1Test.java:25)
> </failure>
>   </testcase>
> {code}
> Problem 1: for the successful testcase the {{name}} is also the class name and not the name of the test case? I would expect {{test}}, as this is the method name.
> Problem 2 (that's the big one): the failed test contains "Description" as {{classname}}. That totally messes up my Hudson report and is a deal-breaker for the 2.13 version. I did not see that during the test of the staged version :(.
> I used the junit47 provider and junit 4.11. 
> I'll prepare a sample or an IT for that later.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] (SUREFIRE-943) Failing tests in TEST-*.xml file contain currupt information

Posted by "Andreas Gudian (JIRA)" <ji...@codehaus.org>.
    [ https://jira.codehaus.org/browse/SUREFIRE-943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=316356#comment-316356 ] 

Andreas Gudian commented on SUREFIRE-943:
-----------------------------------------

Opened a pull reqest with an IT and a proposed fix: https://github.com/apache/maven-surefire/pull/18
                
> Failing tests in TEST-*.xml file contain currupt information
> ------------------------------------------------------------
>
>                 Key: SUREFIRE-943
>                 URL: https://jira.codehaus.org/browse/SUREFIRE-943
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: Maven Surefire Plugin
>    Affects Versions: 2.13
>            Reporter: Andreas Gudian
>            Priority: Critical
>
> I have test classes with two test methods: one is {{test()}} (always passes), the other one is {{fails()}} (well, it is supposed to fail).
> This is the output in the TEST-*.xml file:
> {code}
>   <testcase time="0.502" classname="org.sample.module.My1Test" name="org.sample.module.My1Test"/>
>   <testcase time="0.503" classname="Description" name="fails">
>     <failure message="Not yet implemented" type="java.lang.AssertionError">java.lang.AssertionError: Not yet implemented
> 	at org.junit.Assert.fail(Assert.java:88)
> 	at org.sample.module.My1Test.fails(My1Test.java:25)
> </failure>
>   </testcase>
> {code}
> Problem 1: for the successful testcase the {{name}} is also the class name and not the name of the test case? I would expect {{test}}, as this is the method name.
> Problem 2 (that's the big one): the failed test contains "Description" as {{classname}}. That totally messes up my Hudson report and is a deal-breaker for the 2.13 version. I did not see that during the test of the staged version :(.
> I used the junit47 provider and junit 4.11. 
> I'll prepare a sample or an IT for that later.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] (SUREFIRE-943) Failing tests in TEST-*.xml file contain currupt information

Posted by "Andreas Gudian (JIRA)" <ji...@codehaus.org>.
    [ https://jira.codehaus.org/browse/SUREFIRE-943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=316453#comment-316453 ] 

Andreas Gudian commented on SUREFIRE-943:
-----------------------------------------

Right, that should actually do it. However, I'm using threadCount=3 and reusable forks (with a build that I made some weeks ago)... So I'm stuck for the moment. :(
                
> Failing tests in TEST-*.xml file contain currupt information
> ------------------------------------------------------------
>
>                 Key: SUREFIRE-943
>                 URL: https://jira.codehaus.org/browse/SUREFIRE-943
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: Maven Surefire Plugin
>    Affects Versions: 2.13
>            Reporter: Andreas Gudian
>            Priority: Critical
>         Attachments: SUREFIRE-943.patch
>
>
> I have test classes with two test methods: one is {{test()}} (always passes), the other one is {{fails()}} (well, it is supposed to fail).
> This is the output in the TEST-*.xml file:
> {code}
>   <testcase time="0.502" classname="org.sample.module.My1Test" name="org.sample.module.My1Test"/>
>   <testcase time="0.503" classname="Description" name="fails">
>     <failure message="Not yet implemented" type="java.lang.AssertionError">java.lang.AssertionError: Not yet implemented
> 	at org.junit.Assert.fail(Assert.java:88)
> 	at org.sample.module.My1Test.fails(My1Test.java:25)
> </failure>
>   </testcase>
> {code}
> Problem 1: for the successful testcase the {{name}} is also the class name and not the name of the test case? I would expect {{test}}, as this is the method name.
> Problem 2 (that's the big one): the failed test contains "Description" as {{classname}}. That totally messes up my Hudson report and is a deal-breaker for the 2.13 version. I did not see that during the test of the staged version :(.
> I used the junit47 provider and junit 4.11. 
> I'll prepare a sample or an IT for that later.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] (SUREFIRE-943) Failing tests in TEST-*.xml file contain currupt information

Posted by "Kristian Rosenvold (JIRA)" <ji...@codehaus.org>.
     [ https://jira.codehaus.org/browse/SUREFIRE-943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Rosenvold closed SUREFIRE-943.
---------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.14
         Assignee: Kristian Rosenvold
    
> Failing tests in TEST-*.xml file contain currupt information
> ------------------------------------------------------------
>
>                 Key: SUREFIRE-943
>                 URL: https://jira.codehaus.org/browse/SUREFIRE-943
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: Maven Surefire Plugin
>    Affects Versions: 2.13
>            Reporter: Andreas Gudian
>            Assignee: Kristian Rosenvold
>            Priority: Critical
>             Fix For: 2.14
>
>         Attachments: SUREFIRE-943.patch
>
>
> I have test classes with two test methods: one is {{test()}} (always passes), the other one is {{fails()}} (well, it is supposed to fail).
> This is the output in the TEST-*.xml file:
> {code}
>   <testcase time="0.502" classname="org.sample.module.My1Test" name="org.sample.module.My1Test"/>
>   <testcase time="0.503" classname="Description" name="fails">
>     <failure message="Not yet implemented" type="java.lang.AssertionError">java.lang.AssertionError: Not yet implemented
> 	at org.junit.Assert.fail(Assert.java:88)
> 	at org.sample.module.My1Test.fails(My1Test.java:25)
> </failure>
>   </testcase>
> {code}
> Problem 1: for the successful testcase the {{name}} is also the class name and not the name of the test case? I would expect {{test}}, as this is the method name.
> Problem 2 (that's the big one): the failed test contains "Description" as {{classname}}. That totally messes up my Hudson report and is a deal-breaker for the 2.13 version. I did not see that during the test of the staged version :(.
> I used the junit47 provider and junit 4.11. 
> I'll prepare a sample or an IT for that later.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] (SUREFIRE-943) Failing tests in TEST-*.xml file contain currupt information

Posted by "Kristian Rosenvold (JIRA)" <ji...@codehaus.org>.
    [ https://jira.codehaus.org/browse/SUREFIRE-943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=316396#comment-316396 ] 

Kristian Rosenvold commented on SUREFIRE-943:
---------------------------------------------

Patch applied in |
5bfd2717377ae52bb1a2e0be65f94723ca011b83, thanks for the patch !

                
> Failing tests in TEST-*.xml file contain currupt information
> ------------------------------------------------------------
>
>                 Key: SUREFIRE-943
>                 URL: https://jira.codehaus.org/browse/SUREFIRE-943
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: Maven Surefire Plugin
>    Affects Versions: 2.13
>            Reporter: Andreas Gudian
>            Priority: Critical
>         Attachments: SUREFIRE-943.patch
>
>
> I have test classes with two test methods: one is {{test()}} (always passes), the other one is {{fails()}} (well, it is supposed to fail).
> This is the output in the TEST-*.xml file:
> {code}
>   <testcase time="0.502" classname="org.sample.module.My1Test" name="org.sample.module.My1Test"/>
>   <testcase time="0.503" classname="Description" name="fails">
>     <failure message="Not yet implemented" type="java.lang.AssertionError">java.lang.AssertionError: Not yet implemented
> 	at org.junit.Assert.fail(Assert.java:88)
> 	at org.sample.module.My1Test.fails(My1Test.java:25)
> </failure>
>   </testcase>
> {code}
> Problem 1: for the successful testcase the {{name}} is also the class name and not the name of the test case? I would expect {{test}}, as this is the method name.
> Problem 2 (that's the big one): the failed test contains "Description" as {{classname}}. That totally messes up my Hudson report and is a deal-breaker for the 2.13 version. I did not see that during the test of the staged version :(.
> I used the junit47 provider and junit 4.11. 
> I'll prepare a sample or an IT for that later.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] (SUREFIRE-943) Failing tests in TEST-*.xml file contain currupt information

Posted by "Andreas Gudian (JIRA)" <ji...@codehaus.org>.
     [ https://jira.codehaus.org/browse/SUREFIRE-943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Gudian updated SUREFIRE-943:
------------------------------------

    Attachment: SUREFIRE-943.patch

Uploaded a .patch file version containing the commit of the pull-request (for keeping up with ASF rules)
                
> Failing tests in TEST-*.xml file contain currupt information
> ------------------------------------------------------------
>
>                 Key: SUREFIRE-943
>                 URL: https://jira.codehaus.org/browse/SUREFIRE-943
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: Maven Surefire Plugin
>    Affects Versions: 2.13
>            Reporter: Andreas Gudian
>            Priority: Critical
>         Attachments: SUREFIRE-943.patch
>
>
> I have test classes with two test methods: one is {{test()}} (always passes), the other one is {{fails()}} (well, it is supposed to fail).
> This is the output in the TEST-*.xml file:
> {code}
>   <testcase time="0.502" classname="org.sample.module.My1Test" name="org.sample.module.My1Test"/>
>   <testcase time="0.503" classname="Description" name="fails">
>     <failure message="Not yet implemented" type="java.lang.AssertionError">java.lang.AssertionError: Not yet implemented
> 	at org.junit.Assert.fail(Assert.java:88)
> 	at org.sample.module.My1Test.fails(My1Test.java:25)
> </failure>
>   </testcase>
> {code}
> Problem 1: for the successful testcase the {{name}} is also the class name and not the name of the test case? I would expect {{test}}, as this is the method name.
> Problem 2 (that's the big one): the failed test contains "Description" as {{classname}}. That totally messes up my Hudson report and is a deal-breaker for the 2.13 version. I did not see that during the test of the staged version :(.
> I used the junit47 provider and junit 4.11. 
> I'll prepare a sample or an IT for that later.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira