[jira] [Updated] (HDFS-10455) Logging the username when deny the setOwner operation

["Tianyin Xu (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HDFS-10455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tianyin Xu updated HDFS-10455:
------------------------------
    Status: Patch Available  (was: Open)

> Logging the username when deny the setOwner operation
> -----------------------------------------------------
>
>                 Key: HDFS-10455
>                 URL: https://issues.apache.org/jira/browse/HDFS-10455
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 2.7.2
>            Reporter: Tianyin Xu
>            Priority: Minor
>         Attachments: HDFS-10455.000.patch
>
>
> The attached patch appends the user name in the logging when the setOwner operation is denied due to insufficient permissions on this user (based on his/her name). 
> The same practice is used in {{FSPermissionChecker}} such as {{checkOwner()}} and {{checkSuperuserPrivilege()}}.
> {code:title=FSDirAttrOp.java|borderStyle=solid}
>        if (!pc.isSuperUser()) {
>          if (username != null && !pc.getUser().equals(username)) {
> -          throw new AccessControlException("Non-super user cannot change owner");
> +          throw new AccessControlException("User " + pc.getUser()
> +              + " is not a super user (non-super user cannot change owner).");
>          }
>          if (group != null && !pc.containsGroup(group)) {
> -          throw new AccessControlException("User does not belong to " + group);
> +          throw new AccessControlException("User " + pc.getUser()
> +              + " does not belong to " + group);
>          }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org