[GitHub] [spark] AngersZhuuuu commented on a change in pull request #32022: [SPARK-34932][SQL] Ignore the groupBy expressions in GROUP BY ... GROUPING SETS

[GitBox <gi...@apache.org>]

AngersZhuuuu commented on a change in pull request #32022:
URL: https://github.com/apache/spark/pull/32022#discussion_r605509697



##########
File path: docs/sql-ref-syntax-qry-select-groupby.md
##########
@@ -29,8 +29,7 @@ When a FILTER clause is attached to an aggregate function, only the matching row
 ### Syntax
 
 ```sql
-GROUP BY group_expression [ , group_expression [ , ... ] ]
-    [ { WITH ROLLUP | WITH CUBE | GROUPING SETS (grouping_set [ , ...]) } ]
+GROUP BY group_expression [ , group_expression [ , ... ] ] [ WITH { ROLLUP | CUBE } ]

Review comment:
       We also need to replace some example sql in this doc such as 
   ```
   SELECT city, car_model, sum(quantity) AS sum FROM dealer
       GROUP BY city, car_model GROUPING SETS ((city, car_model), (city), (car_model), ())
       ORDER BY city, car_model;
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org