You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/27 09:47:35 UTC
[GitHub] [spark] zhengruifeng opened a new pull request, #38411: [SPARK-40933][SQL] Make df.stat.{cov, corr} consistent with sql functions
zhengruifeng opened a new pull request, #38411:
URL: https://github.com/apache/spark/pull/38411
### What changes were proposed in this pull request?
Make df.stat.{cov, corr} consistent with sql functions
### Why are the changes needed?
it is weird to have two implemetations in SQL
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
existing UTs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #38411: [SPARK-40933][SQL] Make df.stat.{cov, corr} consistent with sql functions
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #38411:
URL: https://github.com/apache/spark/pull/38411#issuecomment-1294384281
@HyukjinKwon as far as I know, they are the seem now.
the original tests didn't cover null handling and empty dataset, I add a new UT to make sure no behavior change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #38411: [SPARK-40933][SQL] Make df.stat.{cov, corr} consistent with sql functions
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #38411:
URL: https://github.com/apache/spark/pull/38411#issuecomment-1293442088
seems different null handling, let me update this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #38411: [SPARK-40933][SQL] Reimplement df.stat.{cov, corr} with built-in sql functions
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #38411: [SPARK-40933][SQL] Reimplement df.stat.{cov, corr} with built-in sql functions
URL: https://github.com/apache/spark/pull/38411
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #38411: [SPARK-40933][SQL] Reimplement df.stat.{cov, corr} with built-in sql functions
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #38411:
URL: https://github.com/apache/spark/pull/38411#issuecomment-1295776210
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org