You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/07/19 06:58:01 UTC
[GitHub] [ozone] kerneltime commented on a diff in pull request #3594: HDDS-7009. Avoid calling getBucket in object APIs
kerneltime commented on code in PR #3594:
URL: https://github.com/apache/ozone/pull/3594#discussion_r924076536
##########
hadoop-ozone/dist/src/main/smoketest/s3/objecthead.robot:
##########
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+*** Settings ***
+Documentation S3 gateway test with aws cli
+Library OperatingSystem
+Library String
+Resource ../commonlib.robot
+Resource commonawslib.robot
+Test Timeout 5 minutes
+Suite Setup Setup s3 tests
+
+*** Variables ***
+${ENDPOINT_URL} http://s3g:9878
+${OZONE_TEST} true
+${BUCKET} generated
+
+*** Test Cases ***
+
+Head existing object
+ Execute echo "Randomtext" > /tmp/testfile
+ ${result} = Execute AWSS3APICli and checkrc put-object --bucket ${BUCKET} --key ${PREFIX}/putobject/key=value/f1 --body /tmp/testfile 0
+
+ ${result} = Execute AWSS3APICli and checkrc head-object --bucket ${BUCKET} --key ${PREFIX}/putobject/key=value/f1 0
+
+Head object in unexisting bucket
Review Comment:
```suggestion
Head object in non existing bucket
```
##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java:
##########
@@ -1976,8 +1976,8 @@ public Cache<URI, KeyProvider> getKeyProviderCache() {
@Override
public OzoneKey headObject(String volumeName, String bucketName,
String keyName) throws IOException {
- Preconditions.checkNotNull(volumeName);
- Preconditions.checkNotNull(bucketName);
+ verifyBucketName(volumeName);
Review Comment:
```suggestion
verifyVolumeName(volumeName);
```
##########
hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestPermissionCheck.java:
##########
@@ -266,9 +274,10 @@ public void testGetKey() throws IOException {
@Test
public void testPutKey() throws IOException {
Review Comment:
And others in this file.
##########
hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestPermissionCheck.java:
##########
@@ -266,9 +274,10 @@ public void testGetKey() throws IOException {
@Test
public void testPutKey() throws IOException {
Review Comment:
Nit: Not part of this review but it would be good to actually describe the intent of this test.
##########
hadoop-ozone/dist/src/main/smoketest/s3/objecthead.robot:
##########
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+*** Settings ***
+Documentation S3 gateway test with aws cli
+Library OperatingSystem
+Library String
+Resource ../commonlib.robot
+Resource commonawslib.robot
+Test Timeout 5 minutes
+Suite Setup Setup s3 tests
+
+*** Variables ***
+${ENDPOINT_URL} http://s3g:9878
+${OZONE_TEST} true
+${BUCKET} generated
+
+*** Test Cases ***
+
+Head existing object
+ Execute echo "Randomtext" > /tmp/testfile
+ ${result} = Execute AWSS3APICli and checkrc put-object --bucket ${BUCKET} --key ${PREFIX}/putobject/key=value/f1 --body /tmp/testfile 0
+
+ ${result} = Execute AWSS3APICli and checkrc head-object --bucket ${BUCKET} --key ${PREFIX}/putobject/key=value/f1 0
+
+Head object in unexisting bucket
+ ${result} = Execute AWSS3APICli and checkrc head-object --bucket ${BUCKET}-non-exitst --key ${PREFIX}/putobject/key=value/f1 255
+ Should contain ${result} 404
+ Should contain ${result} Not Found
+
+Head unexisting key
Review Comment:
```suggestion
Head non existing key
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org