You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metamodel.apache.org by kaspersorensen <gi...@git.apache.org> on 2016/05/16 04:49:23 UTC

[GitHub] metamodel pull request: METAMODEL-241: Fixed

GitHub user kaspersorensen opened a pull request:

    https://github.com/apache/metamodel/pull/102

    METAMODEL-241: Fixed

    This fix is implemented by further diving deep into the depths of OpenJDK. I'm not really fond of going down that route, but it seems to be the way to go if we really want to keep deserialization support.
    
    Thanks to @LosD for the good hint on what had changed in OpenJDK by the way!

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kaspersorensen/metamodel METAMODEL-241

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metamodel/pull/102.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #102
    
----
commit cfe3e1207ea3a753bde45c1b8108bb05cee8703b
Author: kaspersorensen <i....@gmail.com>
Date:   2016-05-16T04:47:27Z

    METAMODEL-241: Fixed
    
    This fix is implemented by further diving deep into the depths of
    OpenJDK. I'm not really fond of going down that route, but it seems to
    be the way to go if we really want to keep deserialization support.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metamodel pull request: METAMODEL-241: Fixed

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/metamodel/pull/102


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metamodel pull request: METAMODEL-241: Fixed

Posted by LosD <gi...@git.apache.org>.
Github user LosD commented on the pull request:

    https://github.com/apache/metamodel/pull/102#issuecomment-219372538
  
    Oh wow that is nasty. But if that's what it takes, that's what it takes. 
    
    LGTM! 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---