[jira] (MCHANGES-305) Provide support for private Github repos

["Ramon Chiara (JIRA)" <ji...@codehaus.org>]

    [ https://jira.codehaus.org/browse/MCHANGES-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=360586#comment-360586 ] 

Ramon Chiara commented on MCHANGES-305:
---------------------------------------

I had same doubt as Olivier Lamy: "in case of github enterprise you don't set credentials?"

In this afternoon I downloaded source code and made a patch that use the server credentials set in settings.xml (I don't like the idea of putting credentials in pom.xml directly).

I'm attaching tha patch here.

Please, I think this is a very important feature since this issue blocks the use of github enterprise.

> Provide support for private Github repos
> ----------------------------------------
>
>                 Key: MCHANGES-305
>                 URL: https://jira.codehaus.org/browse/MCHANGES-305
>             Project: Maven Changes Plugin
>          Issue Type: Improvement
>          Components: github
>            Reporter: Erik Billerby
>         Attachments: github-credentials.diff, github-credentials-update.patch
>
>
> The egit-github client provides support for both basic authentication and oauth. It should be pretty easy to implement in the github issue downloader. 



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)