You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/01/05 02:09:58 UTC

[GitHub] [dolphinscheduler] zhongjiajie commented on a change in pull request #7783: [python] Task condition missing two downstream param

zhongjiajie commented on a change in pull request #7783:
URL: https://github.com/apache/dolphinscheduler/pull/7783#discussion_r778502671



##########
File path: dolphinscheduler-python/pydolphinscheduler/src/pydolphinscheduler/tasks/condition.py
##########
@@ -182,4 +201,5 @@ def task_params(self, camel_attr: bool = True, custom_attr: set = None) -> Dict:
         """
         params = super().task_params
         params["dependence"] = self.condition.get_define()
+        params["conditionResult"] = self.condition_result

Review comment:
       Cause we can not set property `property` in class `Conditions` So I overwrite function `task_params`. It related your above comment https://github.com/apache/dolphinscheduler/pull/7783/files/2dd5134de92cca727514907e1863ab1db523055c#r778015716 .




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org