You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "abhimeee (via GitHub)" <gi...@apache.org> on 2026/06/21 12:17:31 UTC
[PR] [Fix][Translation] Remove connector-specific test dependencies from translation-base [seatunnel]
abhimeee opened a new pull request, #11155:
URL: https://github.com/apache/seatunnel/pull/11155
## Summary
Fixes #11074
- Remove `connector-file-base` and `connector-doris` test dependencies from `seatunnel-translation-base`
- Refactor `ParallelSourceTest` to use a generic `MockSource` / `MockSplitEnumerator` instead of concrete connector implementations
- The updated tests still verify round-robin split assignment across parallel readers and checkpoint state restore, without pulling unrelated connector modules into the Maven reactor via the shared translation → starter → e2e dependency chain
## Motivation
`seatunnel-translation-base` is a shared module on the incremental IT build path. Connector-specific test dependencies caused unrelated connector IT jobs (e.g. `connector-elasticsearch-v2`) to unnecessarily build `connector-file-base` and `connector-doris`, increasing CI cost and noise.
## Test plan
- [x] `./mvnw spotless:apply -pl seatunnel-translation/seatunnel-translation-base`
- [ ] `./mvnw test -pl seatunnel-translation/seatunnel-translation-base -Dtest=ParallelSourceTest`
- [ ] `./mvnw -q -DskipTests verify -pl seatunnel-translation/seatunnel-translation-base`
Made with [Cursor](https://cursor.com)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Translation] Remove connector-specific test dependencies from translation-base [seatunnel]
Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11155:
URL: https://github.com/apache/seatunnel/pull/11155#issuecomment-4788528090
Thanks for the ping. From Daniel's side, the current source revision is still the same one I already approved, so I do not have a reopened code-level blocker here.
What is still blocking merge right now is the latest `Build` check on the current head. I re-checked the check run behind `apache/seatunnel` and it is still red on the fork workflow, with the concrete failure showing up in `Run / unit-test (11, windows-latest)`, while `Run / unit-test (8, ubuntu-latest)` and `Run / unit-test (11, ubuntu-latest)` were cancelled in the same run.
So not quite gtg yet: once that Build is green again, this should be back in a mergeable state from my side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Translation] Remove connector-specific test dependencies from translation-base [seatunnel]
Posted by "abhimeee (via GitHub)" <gi...@apache.org>.
abhimeee commented on PR #11155:
URL: https://github.com/apache/seatunnel/pull/11155#issuecomment-4786402734
are we gtg?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Translation] Remove connector-specific test dependencies from translation-base [seatunnel]
Posted by "davidzollo (via GitHub)" <gi...@apache.org>.
davidzollo commented on PR #11155:
URL: https://github.com/apache/seatunnel/pull/11155#issuecomment-4764225259
Good job.
Thanks a lot for your valuable contribution to Apache SeaTunnel!
To pass the automated CI checks for this PR, could you please enable CI workflows in your forked repository first? You can refer to the check run link below as a reference for the required CI configuration ** CI check URL **
If you run into any trouble enabling CI or encounter related errors during the process, feel free to leave a comment here. Contributors are always ready to offer help~
<img width="2412" height="1472" alt="image" src="https://github.com/user-attachments/assets/6abd2ea1-da45-4d78-a81c-0158f2d7a851" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Translation] Remove connector-specific test dependencies from translation-base [seatunnel]
Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11155:
URL: https://github.com/apache/seatunnel/pull/11155#issuecomment-4845339004
Thanks for the update. I rechecked the current head against the latest `dev`, and this branch is still behind upstream.
- base branch: `dev`
- head SHA: `2b1a5169152cb74c21340e77941d403475c4d03b`
- compare status: `diverged`
- ahead_by: `3`
- behind_by: `39`
- mergeable_state: `unknown`
- CI / merge gate snapshot: `failing` (failing: `Build [failure]`)
Because the PR is still behind the latest base, any CI result and merge gate signal here is mixed with upstream drift. The lowest-cost next step is to sync with the latest `dev` and rerun CI first. If anything still fails after the sync, I'm happy to take another look on top of the updated head.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Translation] Remove connector-specific test dependencies from translation-base [seatunnel]
Posted by "davidzollo (via GitHub)" <gi...@apache.org>.
davidzollo closed pull request #11155: [Fix][Translation] Remove connector-specific test dependencies from translation-base
URL: https://github.com/apache/seatunnel/pull/11155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Translation] Remove connector-specific test dependencies from translation-base [seatunnel]
Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11155:
URL: https://github.com/apache/seatunnel/pull/11155#issuecomment-4854228644
Thanks for the update. I rechecked the current head against the latest `dev`, and the source-level blockers from my previous Daniel review still stand on this branch.
- base branch: `dev`
- head SHA: `2b1a5169152cb74c21340e77941d403475c4d03b`
- compare status: `diverged`
- ahead_by: `3`
- behind_by: `47`
- CI / merge gate snapshot: `Build FAILURE`
The current failing CI signal does not look actionable on top of this stale head yet, so the lowest-cost next step is to sync with the latest `dev` and rerun CI first. If anything still fails after the sync, I am happy to take another look on top of the updated head.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org