You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by kalyan kumar kalvagadda via Review Board <no...@reviews.apache.org> on 2017/11/07 16:30:00 UTC
Review Request 63619: SENTRY-2033: Fix TestDbPrivilegeCleanupOnDrop
to use SentryMetastorePostEventListenerNotificationLog
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63619/
-----------------------------------------------------------
Review request for sentry, Na Li and Sergio Pena.
Bugs: SENTRY-2033
https://issues.apache.org/jira/browse/SENTRY-2033
Repository: sentry
Description
-------
TestDbPrivilegeCleanupOnDrop still uses SentryMetastorePostEventListener to get the updates on the changes in HMS data. SentryMetastorePostEventListener is obsolete, and the tests should not use it any more.Tests should use implementations of MetaStoreEventListener to process the notifications.
Here is the summary of code changes done:
1. Change the base class from AbstractTestWithStaticConfiguration to TestHDFSIntegrationBase. As AbstractTestWithStaticConfiguration does not creae/start HMS service.
2. Made code changes to update property "sentry.hive.server"
3. Code changes to TestDbPrivilegeCleanupOnDrop to be a child class for TestHDFSIntegrationBase.
Diffs
-----
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java 33c91244af40fabb9eca246a7664bed345e3c9f3
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java 3c96d553b34d6a9fe9c9eb0a6fa88b17a4fc7694
Diff: https://reviews.apache.org/r/63619/diff/1/
Testing
-------
Made sure that the tests pass
Thanks,
kalyan kumar kalvagadda
Re: Review Request 63619: SENTRY-2033: Fix
TestDbPrivilegeCleanupOnDrop to
use SentryMetastorePostEventListenerNotificationLog
Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63619/#review190337
-----------------------------------------------------------
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java
Line 44 (original), 38 (patched)
<https://reviews.apache.org/r/63619/#comment267640>
Why did it change to TestHDFSIntegrationBase if this is a Hive e2e test?
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java
Lines 103-105 (original), 104-113 (patched)
<https://reviews.apache.org/r/63619/#comment267641>
This code is repeated on every test. How was it working before? Why isn't created on a @before method?
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java
Lines 859 (patched)
<https://reviews.apache.org/r/63619/#comment267638>
Why was this removed?
- Sergio Pena
On Nov. 7, 2017, 4:29 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63619/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2017, 4:29 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Na Li, and Sergio Pena.
>
>
> Bugs: SENTRY-2033
> https://issues.apache.org/jira/browse/SENTRY-2033
>
>
> Repository: sentry
>
>
> Description
> -------
>
> TestDbPrivilegeCleanupOnDrop still uses SentryMetastorePostEventListener to get the updates on the changes in HMS data. SentryMetastorePostEventListener is obsolete, and the tests should not use it any more.Tests should use implementations of MetaStoreEventListener to process the notifications.
>
> Here is the summary of code changes done:
> 1. Change the base class from AbstractTestWithStaticConfiguration to TestHDFSIntegrationBase. As AbstractTestWithStaticConfiguration does not creae/start HMS service.
> 2. Made code changes to update property "sentry.hive.server"
> 3. Code changes to TestDbPrivilegeCleanupOnDrop to be a child class for TestHDFSIntegrationBase.
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java 33c91244af40fabb9eca246a7664bed345e3c9f3
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java 3c96d553b34d6a9fe9c9eb0a6fa88b17a4fc7694
>
>
> Diff: https://reviews.apache.org/r/63619/diff/1/
>
>
> Testing
> -------
>
> Made sure that the tests pass
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 63619: SENTRY-2033: Fix
TestDbPrivilegeCleanupOnDrop to
use SentryMetastorePostEventListenerNotificationLog
Posted by Na Li via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63619/#review190493
-----------------------------------------------------------
Ship it!
Ship It!
- Na Li
On Nov. 7, 2017, 6:17 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63619/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2017, 6:17 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Na Li, and Sergio Pena.
>
>
> Bugs: SENTRY-2033
> https://issues.apache.org/jira/browse/SENTRY-2033
>
>
> Repository: sentry
>
>
> Description
> -------
>
> TestDbPrivilegeCleanupOnDrop still uses SentryMetastorePostEventListener to get the updates on the changes in HMS data. SentryMetastorePostEventListener is obsolete, and the tests should not use it any more.Tests should use implementations of MetaStoreEventListener to process the notifications.
>
> Here is the summary of code changes done:
> 1. Change the base class from AbstractTestWithStaticConfiguration to TestHDFSIntegrationBase. As AbstractTestWithStaticConfiguration does not creae/start HMS service.
> 2. Made code changes to update property "sentry.hive.server"
> 3. Code changes to TestDbPrivilegeCleanupOnDrop to be a child class for TestHDFSIntegrationBase.
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java 33c91244af40fabb9eca246a7664bed345e3c9f3
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java 3c96d553b34d6a9fe9c9eb0a6fa88b17a4fc7694
>
>
> Diff: https://reviews.apache.org/r/63619/diff/2/
>
>
> Testing
> -------
>
> Made sure that the tests pass
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 63619: SENTRY-2033: Fix
TestDbPrivilegeCleanupOnDrop to
use SentryMetastorePostEventListenerNotificationLog
Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63619/#review190369
-----------------------------------------------------------
Ship it!
Ship It!
- Sergio Pena
On Nov. 7, 2017, 6:17 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63619/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2017, 6:17 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Na Li, and Sergio Pena.
>
>
> Bugs: SENTRY-2033
> https://issues.apache.org/jira/browse/SENTRY-2033
>
>
> Repository: sentry
>
>
> Description
> -------
>
> TestDbPrivilegeCleanupOnDrop still uses SentryMetastorePostEventListener to get the updates on the changes in HMS data. SentryMetastorePostEventListener is obsolete, and the tests should not use it any more.Tests should use implementations of MetaStoreEventListener to process the notifications.
>
> Here is the summary of code changes done:
> 1. Change the base class from AbstractTestWithStaticConfiguration to TestHDFSIntegrationBase. As AbstractTestWithStaticConfiguration does not creae/start HMS service.
> 2. Made code changes to update property "sentry.hive.server"
> 3. Code changes to TestDbPrivilegeCleanupOnDrop to be a child class for TestHDFSIntegrationBase.
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java 33c91244af40fabb9eca246a7664bed345e3c9f3
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java 3c96d553b34d6a9fe9c9eb0a6fa88b17a4fc7694
>
>
> Diff: https://reviews.apache.org/r/63619/diff/2/
>
>
> Testing
> -------
>
> Made sure that the tests pass
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 63619: SENTRY-2033: Fix
TestDbPrivilegeCleanupOnDrop to
use SentryMetastorePostEventListenerNotificationLog
Posted by kalyan kumar kalvagadda via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63619/
-----------------------------------------------------------
(Updated Nov. 7, 2017, 6:17 p.m.)
Review request for sentry, Alexander Kolbasov, Na Li, and Sergio Pena.
Changes
-------
addressed review comments.
Bugs: SENTRY-2033
https://issues.apache.org/jira/browse/SENTRY-2033
Repository: sentry
Description
-------
TestDbPrivilegeCleanupOnDrop still uses SentryMetastorePostEventListener to get the updates on the changes in HMS data. SentryMetastorePostEventListener is obsolete, and the tests should not use it any more.Tests should use implementations of MetaStoreEventListener to process the notifications.
Here is the summary of code changes done:
1. Change the base class from AbstractTestWithStaticConfiguration to TestHDFSIntegrationBase. As AbstractTestWithStaticConfiguration does not creae/start HMS service.
2. Made code changes to update property "sentry.hive.server"
3. Code changes to TestDbPrivilegeCleanupOnDrop to be a child class for TestHDFSIntegrationBase.
Diffs (updated)
-----
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java 33c91244af40fabb9eca246a7664bed345e3c9f3
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java 3c96d553b34d6a9fe9c9eb0a6fa88b17a4fc7694
Diff: https://reviews.apache.org/r/63619/diff/2/
Changes: https://reviews.apache.org/r/63619/diff/1-2/
Testing
-------
Made sure that the tests pass
Thanks,
kalyan kumar kalvagadda