[GitHub] [dubbo] EarthChen commented on a change in pull request #8871: [3.0-Triple] Add handler for reset frame

[GitBox <gi...@apache.org>]

EarthChen commented on a change in pull request #8871:
URL: https://github.com/apache/dubbo/pull/8871#discussion_r716156412



##########
File path: dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/ServerTransportObserver.java
##########
@@ -48,19 +59,38 @@ public void onMetadata(Metadata metadata, boolean endStream) {
             headers.set(TripleHeaderEnum.CONTENT_TYPE_KEY.getHeader(), TripleConstant.CONTENT_PROTO);
         }
         ctx.writeAndFlush(new DefaultHttp2HeadersFrame(headers, endStream))
-            .addListener(future -> {
-                if (!future.isSuccess()) {
-                    promise.tryFailure(future.cause());
-                }
-            });
+                .addListener(future -> {

Review comment:
       This PR has an explanation.
   https://github.com/apache/dubbo/pull/8922




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org