You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "li xu (JIRA)" <ji...@apache.org> on 2011/05/11 23:08:47 UTC
[jira] [Created] (SHINDIG-1534) detect Host and Port from
HttpServletRequest
detect Host and Port from HttpServletRequest
--------------------------------------------
Key: SHINDIG-1534
URL: https://issues.apache.org/jira/browse/SHINDIG-1534
Project: Shindig
Issue Type: Improvement
Components: Java
Affects Versions: 3.0.0
Reporter: li xu
Fix For: 3.0.0
Shindig.host and shindig.port currently can be configured in web.xml or system properties.
It's not convenient to update web.xml everytime for a new deployment.
It will also be problematic within reverse proxy environment.
This approach will detect value from HttpServletRequest and save it to a ThreadLocal variable. No configuration is required anymore.
Many thanks to Mark Nesbitt for the original idea.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1534) detect Host and Port from
HttpServletRequest
Posted by "li xu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13032084#comment-13032084 ]
li xu commented on SHINDIG-1534:
--------------------------------
Patch is uploaded here:
http://codereview.appspot.com/4534049/
> detect Host and Port from HttpServletRequest
> --------------------------------------------
>
> Key: SHINDIG-1534
> URL: https://issues.apache.org/jira/browse/SHINDIG-1534
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 3.0.0
> Reporter: li xu
> Fix For: 3.0.0
>
>
> Shindig.host and shindig.port currently can be configured in web.xml or system properties.
> It's not convenient to update web.xml everytime for a new deployment.
> It will also be problematic within reverse proxy environment.
> This approach will detect value from HttpServletRequest and save it to a ThreadLocal variable. No configuration is required anymore.
> Many thanks to Mark Nesbitt for the original idea.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (SHINDIG-1534) detect Host and Port from
HttpServletRequest
Posted by "li xu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
li xu closed SHINDIG-1534.
--------------------------
verified issue with following url and a couple of different port...
http://localhost:8080/samplecontainer/samplecontainer.html
http://localhost:8080/samplecontainer/examples/commoncontainer/index.html
> detect Host and Port from HttpServletRequest
> --------------------------------------------
>
> Key: SHINDIG-1534
> URL: https://issues.apache.org/jira/browse/SHINDIG-1534
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 3.0.0
> Reporter: li xu
> Fix For: 3.0.0
>
>
> Shindig.host and shindig.port currently can be configured in web.xml or system properties.
> It's not convenient to update web.xml everytime for a new deployment.
> It will also be problematic within reverse proxy environment.
> This approach will detect value from HttpServletRequest and save it to a ThreadLocal variable. No configuration is required anymore.
> Many thanks to Mark Nesbitt for the original idea.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SHINDIG-1534) detect Host and Port from
HttpServletRequest
Posted by "li xu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
li xu resolved SHINDIG-1534.
----------------------------
Resolution: Fixed
It's commited by Eric on 5/12.
> detect Host and Port from HttpServletRequest
> --------------------------------------------
>
> Key: SHINDIG-1534
> URL: https://issues.apache.org/jira/browse/SHINDIG-1534
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 3.0.0
> Reporter: li xu
> Fix For: 3.0.0
>
>
> Shindig.host and shindig.port currently can be configured in web.xml or system properties.
> It's not convenient to update web.xml everytime for a new deployment.
> It will also be problematic within reverse proxy environment.
> This approach will detect value from HttpServletRequest and save it to a ThreadLocal variable. No configuration is required anymore.
> Many thanks to Mark Nesbitt for the original idea.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1534) detect Host and Port from
HttpServletRequest
Posted by "Eric Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13032632#comment-13032632 ]
Eric Woods commented on SHINDIG-1534:
-------------------------------------
Committed. Make sure it's correct and update this issue's status. Thanks, Li!
> detect Host and Port from HttpServletRequest
> --------------------------------------------
>
> Key: SHINDIG-1534
> URL: https://issues.apache.org/jira/browse/SHINDIG-1534
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 3.0.0
> Reporter: li xu
> Fix For: 3.0.0
>
>
> Shindig.host and shindig.port currently can be configured in web.xml or system properties.
> It's not convenient to update web.xml everytime for a new deployment.
> It will also be problematic within reverse proxy environment.
> This approach will detect value from HttpServletRequest and save it to a ThreadLocal variable. No configuration is required anymore.
> Many thanks to Mark Nesbitt for the original idea.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira