[GitHub] [incubator-shardingsphere] TaoZhiMLND opened a new issue #5168: Simplify the configuration API of ShardingKeyGenerator on spring namespace

[GitBox <gi...@apache.org>]

TaoZhiMLND opened a new issue #5168: Simplify the configuration  API of ShardingKeyGenerator on spring namespace
URL: https://github.com/apache/incubator-shardingsphere/issues/5168
 
 
   Hi community,
   
   ShardingKeyGenerator configuration on spring namespace  is like this now,
   ```
   <bean id="incrementAlgorithm" class="org.apache.shardingsphere.shardingjdbc.spring.namespace.factorybean.KeyGenerateAlgorithmFactoryBean">   
      <property name="type" value="INCREMENT" />   
   </bean>   
   
   <sharding:key-generator id="orderKeyGenerator" column="order_id" algorithm-ref="incrementAlgorithm" />
   ```
   The following configuration will hide KeyGenerateAlgorithmFactoryBean may be more simplified,
   ```
   <sharding:key-generate-algorithm id="incrementAlgorithm" type="INCREMENT"/>
   
   <sharding:key-generator id="orderKeyGenerator" column="order_id" algorithm-ref="incrementAlgorithm" />
   ```
   But element `<sharding:key-generate-algorithm>` has some strange for keyGenerateAlgorithm itself has nothing to do with Sharding. Besides, the elements `<key-generate-algorithm>` and `<key-generator>` has a duplicate word.
   
   Do we need to make any changes to simplify this configuration? I will really appreciate any help on this. Thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services