You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/07/15 08:00:58 UTC
[GitHub] [solr] NazerkeBS opened a new pull request #221: getCurrentSchemaModificationVersion in ConfigSetService throws IOException
NazerkeBS opened a new pull request #221:
URL: https://github.com/apache/solr/pull/221
https://issues.apache.org/jira/browse/SOLR-XXXXX
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Solr:
* https://issues.apache.org/jira/projects/SOLR
You will need to create an account in Jira in order to create an issue.
The title of the PR should reference the Jira issue number in the form:
* SOLR-####: <short description of problem or changes>
SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
Please provide a short description of the changes you're making with this pull request.
# Solution
Please provide a short description of the approach taken to implement your solution.
# Tests
Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] NazerkeBS commented on pull request #221: getCurrentSchemaModificationVersion in ConfigSetService throws IOException
Posted by GitBox <gi...@apache.org>.
NazerkeBS commented on pull request #221:
URL: https://github.com/apache/solr/pull/221#issuecomment-881289527
As this change is trivial, it can be part of SOLR-15258 (ConfigSetService refactoring)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on pull request #221: SOLR-15258: ConfigSetService operations ought to throw IOException
Posted by GitBox <gi...@apache.org>.
madrob commented on pull request #221:
URL: https://github.com/apache/solr/pull/221#issuecomment-882802608
> if getCurrentSchemaModificationVersion throws an exception, then its caller doesn't have to catch the exception;
Is this an _is_ or _ought_ statement? In other words, are you saying that this is a problem currently? What would you expect a caller to do if there is an exception thrown? How is it different from the current case of catching SolrException?
> As this change is trivial, it can be part of SOLR-15258 (ConfigSetService refactoring)
Yes, that's fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on pull request #221: SOLR-15258: ConfigSetService operations ought to throw IOException
Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #221:
URL: https://github.com/apache/solr/pull/221#issuecomment-883013519
> Is this an is or ought statement?
"ought". It's a minor nuisance really.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #221: SOLR-15258: ConfigSetService operations ought to throw IOException
Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #221:
URL: https://github.com/apache/solr/pull/221#issuecomment-990950077
The JIRA for this PR is closed. Should this PR also be closed or is there still work that needs to be merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on pull request #221: getCurrentSchemaModificationVersion in ConfigSetService throws IOException
Posted by GitBox <gi...@apache.org>.
madrob commented on pull request #221:
URL: https://github.com/apache/solr/pull/221#issuecomment-880985173
I'm not sure I understand the motivation for this change, can you please open a JIRA issue describing what this aims to solve or improve? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on pull request #221: getCurrentSchemaModificationVersion in ConfigSetService throws IOException
Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #221:
URL: https://github.com/apache/solr/pull/221#issuecomment-881417808
I proposed to Nazerke that she file this PR and that it was too simple to warrant a JIRA issue as well. The issue description should have been filled to justify the PR's existence/purpose but wasn't.
Basically all operations of ConfigSetService that read/write ought to throw an IOException and most do but not this one, which I think was simply an oversight. Thus if you call this, perhaps delegating, and if you call something that might throw IOException, then you have to wrap it.
Other methods ought to throw IOException as well but don't declare it now:
* loadConfigSetFlags
That's it, as far as I can see.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on pull request #221: SOLR-15258: ConfigSetService operations ought to throw IOException
Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #221:
URL: https://github.com/apache/solr/pull/221#issuecomment-883013519
> Is this an is or ought statement?
"ought". It's a minor nuisance really.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on pull request #221: SOLR-15258: ConfigSetService operations ought to throw IOException
Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #221:
URL: https://github.com/apache/solr/pull/221#issuecomment-883013519
> Is this an is or ought statement?
"ought". It's a minor nuisance really.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on pull request #221: SOLR-15258: ConfigSetService operations ought to throw IOException
Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #221:
URL: https://github.com/apache/solr/pull/221#issuecomment-991257166
This wasn't done; it's follow-up tiny stuff. @NazerkeBS there are a couple things remaining I asked of you -- the empty catch, and loadConfigSetProperties
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] NazerkeBS commented on pull request #221: getCurrentSchemaModificationVersion in ConfigSetService throws IOException
Posted by GitBox <gi...@apache.org>.
NazerkeBS commented on pull request #221:
URL: https://github.com/apache/solr/pull/221#issuecomment-881287257
@madrob, if `getCurrentSchemaModificationVersion` throws an exception, then its caller doesn't have to catch the exception;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on pull request #221: SOLR-15258: ConfigSetService operations ought to throw IOException
Posted by GitBox <gi...@apache.org>.
madrob commented on pull request #221:
URL: https://github.com/apache/solr/pull/221#issuecomment-882802608
> if getCurrentSchemaModificationVersion throws an exception, then its caller doesn't have to catch the exception;
Is this an _is_ or _ought_ statement? In other words, are you saying that this is a problem currently? What would you expect a caller to do if there is an exception thrown? How is it different from the current case of catching SolrException?
> As this change is trivial, it can be part of SOLR-15258 (ConfigSetService refactoring)
Yes, that's fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on pull request #221: SOLR-15258: ConfigSetService operations ought to throw IOException
Posted by GitBox <gi...@apache.org>.
madrob commented on pull request #221:
URL: https://github.com/apache/solr/pull/221#issuecomment-882802608
> if getCurrentSchemaModificationVersion throws an exception, then its caller doesn't have to catch the exception;
Is this an _is_ or _ought_ statement? In other words, are you saying that this is a problem currently? What would you expect a caller to do if there is an exception thrown? How is it different from the current case of catching SolrException?
> As this change is trivial, it can be part of SOLR-15258 (ConfigSetService refactoring)
Yes, that's fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley merged pull request #221: SOLR-15258: ConfigSetService operations ought to throw IOException
Posted by GitBox <gi...@apache.org>.
dsmiley merged pull request #221:
URL: https://github.com/apache/solr/pull/221
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on pull request #221: SOLR-15258: ConfigSetService operations ought to throw IOException
Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #221:
URL: https://github.com/apache/solr/pull/221#issuecomment-991257166
This wasn't done; it's follow-up tiny stuff. @NazerkeBS there are a couple things remaining I asked of you -- the empty catch, and loadConfigSetProperties
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org