[GitHub] [iceberg] waltczhang commented on a diff in pull request #4154: Spark 3.2: Support mergeSchema option on write

[GitBox <gi...@apache.org>]

waltczhang commented on code in PR #4154:
URL: https://github.com/apache/iceberg/pull/4154#discussion_r878972045


##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkWriteBuilder.java:
##########
@@ -130,8 +131,7 @@ public Write build() {
     Preconditions.checkArgument(handleTimestampWithoutZone || !SparkUtil.hasTimestampWithoutZone(table.schema()),
         SparkUtil.TIMESTAMP_WITHOUT_TIMEZONE_ERROR);
 
-    Schema writeSchema = SparkSchemaUtil.convert(table.schema(), dsSchema);
-    TypeUtil.validateWriteSchema(table.schema(), writeSchema, writeConf.checkNullability(), writeConf.checkOrdering());

Review Comment:
   Updating Schema and commit  are not in transaction, this means that when writing data fails it will update schema, why not transaction？



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org