You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "codecov[bot] (via GitHub)" <gi...@apache.org> on 2023/06/07 20:25:28 UTC
[GitHub] [superset] codecov[bot] commented on pull request #24314: merge in fix with migration
codecov[bot] commented on PR #24314:
URL: https://github.com/apache/superset/pull/24314#issuecomment-1581459873
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24314?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24314](https://app.codecov.io/gh/apache/superset/pull/24314?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (eeabacc) into [2.1](https://app.codecov.io/gh/apache/superset/commit/54cb51a3bf841e93b15bedec6a01d6cd47c663c0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (54cb51a) will **decrease** coverage by `11.01%`.
> The diff coverage is `58.73%`.
> :exclamation: Current head eeabacc differs from pull request most recent head ccf2a09. Consider uploading reports for the commit ccf2a09 to get more accurate results
```diff
@@ Coverage Diff @@
## 2.1 #24314 +/- ##
===========================================
- Coverage 67.51% 56.50% -11.01%
===========================================
Files 1883 1883
Lines 72602 72639 +37
Branches 7887 7887
===========================================
- Hits 49014 41047 -7967
- Misses 21566 29570 +8004
Partials 2022 2022
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.75% <55.55%> (+<0.01%)` | :arrow_up: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `52.68% <55.55%> (+<0.01%)` | :arrow_up: |
| python | `59.29% <58.73%> (-22.80%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `52.53% <58.73%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/permalink/commands/create.py](https://app.codecov.io/gh/apache/superset/pull/24314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9wZXJtYWxpbmsvY29tbWFuZHMvY3JlYXRlLnB5) | `50.00% <ø> (-42.86%)` | :arrow_down: |
| [superset/dashboards/permalink/commands/get.py](https://app.codecov.io/gh/apache/superset/pull/24314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9wZXJtYWxpbmsvY29tbWFuZHMvZ2V0LnB5) | `50.00% <0.00%> (-31.25%)` | :arrow_down: |
| [superset/explore/permalink/commands/create.py](https://app.codecov.io/gh/apache/superset/pull/24314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZXhwbG9yZS9wZXJtYWxpbmsvY29tbWFuZHMvY3JlYXRlLnB5) | `42.42% <ø> (-48.49%)` | :arrow_down: |
| [superset/explore/permalink/commands/get.py](https://app.codecov.io/gh/apache/superset/pull/24314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZXhwbG9yZS9wZXJtYWxpbmsvY29tbWFuZHMvZ2V0LnB5) | `48.57% <ø> (-42.86%)` | :arrow_down: |
| [superset/key\_value/commands/update.py](https://app.codecov.io/gh/apache/superset/pull/24314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQva2V5X3ZhbHVlL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `0.00% <0.00%> (-90.91%)` | :arrow_down: |
| [superset/key\_value/commands/create.py](https://app.codecov.io/gh/apache/superset/pull/24314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQva2V5X3ZhbHVlL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `45.83% <37.50%> (-47.19%)` | :arrow_down: |
| [superset/key\_value/shared\_entries.py](https://app.codecov.io/gh/apache/superset/pull/24314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQva2V5X3ZhbHVlL3NoYXJlZF9lbnRyaWVzLnB5) | `47.61% <50.00%> (-52.39%)` | :arrow_down: |
| [superset/temporary\_cache/api.py](https://app.codecov.io/gh/apache/superset/pull/24314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvdGVtcG9yYXJ5X2NhY2hlL2FwaS5weQ==) | `40.00% <50.00%> (-46.37%)` | :arrow_down: |
| [superset/key\_value/commands/get.py](https://app.codecov.io/gh/apache/superset/pull/24314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQva2V5X3ZhbHVlL2NvbW1hbmRzL2dldC5weQ==) | `60.60% <60.00%> (-30.02%)` | :arrow_down: |
| [superset/key\_value/commands/upsert.py](https://app.codecov.io/gh/apache/superset/pull/24314?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQva2V5X3ZhbHVlL2NvbW1hbmRzL3Vwc2VydC5weQ==) | `52.17% <60.00%> (-38.94%)` | :arrow_down: |
| ... and [5 more](https://app.codecov.io/gh/apache/superset/pull/24314?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [284 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24314/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org